From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fhigh-a6-smtp.messagingengine.com (fhigh-a6-smtp.messagingengine.com [103.168.172.157]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED6CE3DBD42 for ; Thu, 19 Mar 2026 17:21:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.157 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773940872; cv=none; b=MGnWUYXObJuNq7WNdud/YvJm+cTDu2eq/ue5aT0nX5nICAlOz9yPiJ6v1PNp1OUHTiiUJr/dun+PW8b4bRqXNXROdfQgCQgMAODfLTHxNCzGXBmQxWnmXMP7EBjFvSClMdTMA5CACurfACm0WrPlNrSjpxmWjvpyWXIVkjLl/ag= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773940872; c=relaxed/simple; bh=QlOhEG5OQDBGTfbPzjW/FPCZGRkL42lTVctz4bOYBx4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UVPPbl9mb8erMirLqhsRxYzZufMhzSTkhRf4l3FFaUOYZExSvNtBsS49MMElGkyiLkVzfw1IHKLc8cuBAjg7yeCMb1U+lUY8vcpKiKhds6+Cu34wqlxIVl6D2kK2bIXL9N6/RO3rMCtpuGSo7M7LJYggw9Bu0BLDnKsh0Z2M4Go= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=queasysnail.net; spf=pass smtp.mailfrom=queasysnail.net; dkim=pass (2048-bit key) header.d=queasysnail.net header.i=@queasysnail.net header.b=HUFNqS3+; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=kl/6x2Y4; arc=none smtp.client-ip=103.168.172.157 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=queasysnail.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=queasysnail.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=queasysnail.net header.i=@queasysnail.net header.b="HUFNqS3+"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="kl/6x2Y4" Received: from phl-compute-04.internal (phl-compute-04.internal [10.202.2.44]) by mailfhigh.phl.internal (Postfix) with ESMTP id 870CF1400082; Thu, 19 Mar 2026 13:21:06 -0400 (EDT) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-04.internal (MEProxy); Thu, 19 Mar 2026 13:21:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=queasysnail.net; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm2; t=1773940866; x= 1774027266; bh=Kh7R68WmI/Muoq4kcOGMyf58Gpczi3668k+J0T0xvqs=; b=H UFNqS3+TQnjYkn81BHfsWcA2gq/LyqKYodZ1aC5/Y1QiGR+tK3QovsbpRTSwFiUU dBUGWMggUSlUafXIN4gTxlAPovM+AgC9N5CcVGcK1ucq1Iv46TCF448CoBZcX06p 5q9DLVisbepubmIAs3pMze9BJCEUMEqM/MqY8MT475OgmzCqUHUhlFQ8vyTRHArh uHtw9IOan6e1BN30tM4j3jCWXrpRB+fSbz41ash4DktbPV7aQQpr5u8bB+70lICf RqLRvGh6FKuBwOU2IAEtM9ay6XEY6DFWr62uqODLAUTZ0L4e/uJJAVGVRE9zLUs1 gC/QsygW5aib+bHFUEcZQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1773940866; x=1774027266; bh=Kh7R68WmI/Muoq4kcOGMyf58Gpczi3668k+ J0T0xvqs=; b=kl/6x2Y4PWoGM7dFApi4Q+haz8zPwi3eq6krq2dUIfjtQip5fvh ZjIDKBFyifrCx5z6SueHusz0BjTSpDBgTghz26rrSfLMByt0o0Uu9ESgUEx3E+QX nvxllAd6bxwgBXgE4jqS6JDrJMD87LLpuT0GpBgDdJG+AbrxNphrvYPTK+Rtvkzb sojFGvfOwMA8BNbLovEpcWfkbi6rFR/OK1EF7WgIgbvR98iCZGVLcj0ADqurug3b Bm8iqwJ5aqacXxcd0OZ4Q29h3GGGZ3AD1UR1/8hWwnwuwx+xtL4xNbEO0pI24W5I yeLGVcw2IuzjRj/FHu2Agre7dEtIpeMT9Rg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgdeftdejiedtucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhepfffhvfevuffkfhggtggujgesthdtredttddtjeenucfhrhhomhepufgrsghrihhn rgcuffhusghrohgtrgcuoehsugesqhhuvggrshihshhnrghilhdrnhgvtheqnecuggftrf grthhtvghrnhepuefhhfffgfffhfefueeiudegtdefhfekgeetheegheeifffguedvueff fefgudffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh epshgusehquhgvrghshihsnhgrihhlrdhnvghtpdhnsggprhgtphhtthhopeekpdhmohgu vgepshhmthhpohhuthdprhgtphhtthhopegtvghlsehkvghrnhgvlhdrohhrghdprhgtph htthhopehjohhhnhdrfhgrshhtrggsvghnugesghhmrghilhdrtghomhdprhgtphhtthho pehkuhgsrgeskhgvrhhnvghlrdhorhhgpdhrtghpthhtohepnhgvthguvghvsehvghgvrh drkhgvrhhnvghlrdhorhhgpdhrtghpthhtohepkhgvrhhnvghlqdhtlhhsqdhhrghnughs hhgrkhgvsehlihhsthhsrdhlihhnuhigrdguvghvpdhrtghpthhtoheptghhuhgtkhdrlh gvvhgvrhesohhrrggtlhgvrdgtohhmpdhrtghpthhtohephhgrrhgvsehsuhhsvgdruggv pdhrtghpthhtoheprghlihhsthgrihhrrdhfrhgrnhgtihhsseifuggtrdgtohhm X-ME-Proxy: Feedback-ID: i934648bf:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 19 Mar 2026 13:21:05 -0400 (EDT) Date: Thu, 19 Mar 2026 18:21:03 +0100 From: Sabrina Dubroca To: Chuck Lever Cc: john.fastabend@gmail.com, kuba@kernel.org, netdev@vger.kernel.org, kernel-tls-handshake@lists.linux.dev, Chuck Lever , Hannes Reinecke , Alistair Francis Subject: Re: [PATCH PATCH net-next v4 1/8] tls: Factor tls_decrypt_async_drain() from recvmsg Message-ID: References: <20260317-tls-read-sock-v4-0-ab1086ec600f@oracle.com> <20260317-tls-read-sock-v4-1-ab1086ec600f@oracle.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260317-tls-read-sock-v4-1-ab1086ec600f@oracle.com> 2026-03-17, 11:04:14 -0400, Chuck Lever wrote: > From: Chuck Lever > > The recvmsg path pairs tls_decrypt_async_wait() with > __skb_queue_purge(&ctx->async_hold). Bundling the two into > tls_decrypt_async_drain() gives later patches a single call > for async teardown. > > The purge is kept separate from tls_decrypt_async_wait() > because other callers (the -EBUSY fallback in > tls_do_decryption and the tls_strp_msg_hold error path) > need to synchronize without discarding held skbs that > are still awaiting delivery. Sorry, but why do we need to keep the encrypted skbs around in the async_hold queue once async decryption has completed? I guess I'm missing something. -- Sabrina