netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Arinzon, David" <darinzon@amazon.com>
To: Simon Horman <simon.horman@corigine.com>
Cc: David Miller <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"Woodhouse, David" <dwmw@amazon.co.uk>,
	"Machulsky, Zorik" <zorik@amazon.com>,
	"Matushevsky, Alexander" <matua@amazon.com>,
	"Bshara, Saeed" <saeedb@amazon.com>,
	"Wilson, Matt" <msw@amazon.com>,
	"Liguori, Anthony" <aliguori@amazon.com>,
	"Bshara, Nafea" <nafea@amazon.com>,
	"Saidi, Ali" <alisaidi@amazon.com>,
	"Herrenschmidt, Benjamin" <benh@amazon.com>,
	"Kiyanovski, Arthur" <akiyano@amazon.com>,
	"Dagan, Noam" <ndagan@amazon.com>,
	"Agroskin, Shay" <shayagr@amazon.com>,
	"Itzko, Shahar" <itzko@amazon.com>,
	"Abboud, Osama" <osamaabb@amazon.com>,
	kernel test robot <lkp@intel.com>
Subject: RE: [PATCH v1 net-next] net: ena: Add missing newline after markup
Date: Tue, 20 Jun 2023 13:25:14 +0000	[thread overview]
Message-ID: <ac10789c93aa40b5b3f601ad968630c3@amazon.com> (raw)
In-Reply-To: <ZJGf3K+oZ1x6wVYz@corigine.com>

> On Tue, Jun 20, 2023 at 07:02:06AM +0000, darinzon@amazon.com wrote:
> > From: David Arinzon <darinzon@amazon.com>
> >
> > This patch fixes a warning in the ena documentation file identified by
> > the kernel automatic tools.
> >
> > Signed-off-by: David Arinzon <darinzon@amazon.com>
> > Reported-by: kernel test robot <lkp@intel.com>
> > Closes:
> > https://lore.kernel.org/oe-kbuild-all/202306171804.U7E92zoE-lkp@intel.
> > com/
> > ---
> >  Documentation/networking/device_drivers/ethernet/amazon/ena.rst | 1
> +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git
> > a/Documentation/networking/device_drivers/ethernet/amazon/ena.rst
> > b/Documentation/networking/device_drivers/ethernet/amazon/ena.rst
> > index 491492677632..00851ec7b4ec 100644
> > ---
> a/Documentation/networking/device_drivers/ethernet/amazon/ena.rst
> > +++
> b/Documentation/networking/device_drivers/ethernet/amazon/ena.rst
> > @@ -206,6 +206,7 @@ More information about Adaptive Interrupt
> > Moderation (DIM) can be found in
> Documentation/networking/net_dim.rst
> >
> >  .. _`RX copybreak`:
> > +
> >  RX copybreak
> >  ============
> >  The rx_copybreak is initialized by default to
> > ENA_DEFAULT_RX_COPYBREAK
> 
> Thanks David,
> 
> this looks good to me.
> 
> Reviewed-by: Simon Horman <simon.horman@corigine.com>
> 
> Although it doesn't trigger a warning, the formatting of the text updated
> below doesn't seem right (I used make htmldocs).
> Feel free to take this if it is useful, or say the word and I'll submit it formally.
> 
> diff --git
> a/Documentation/networking/device_drivers/ethernet/amazon/ena.rst
> b/Documentation/networking/device_drivers/ethernet/amazon/ena.rst
> index 00851ec7b4ec..5eaa3ab6c73e 100644
> --- a/Documentation/networking/device_drivers/ethernet/amazon/ena.rst
> +++
> b/Documentation/networking/device_drivers/ethernet/amazon/ena.rst
> @@ -38,6 +38,7 @@ debug logs.
> 
>  Some of the ENA devices support a working mode called Low-latency
> Queue (LLQ), which saves several more microseconds.
> +
>  ENA Source Code Directory Structure
>  ===================================
> 
> 

Hi Simon,

Thank you for reviewing and identifying this formatting issue, I'll submit a v2 today.

      reply	other threads:[~2023-06-20 13:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-20  7:02 [PATCH v1 net-next] net: ena: Add missing newline after markup darinzon
2023-06-20 12:47 ` Simon Horman
2023-06-20 13:25   ` Arinzon, David [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ac10789c93aa40b5b3f601ad968630c3@amazon.com \
    --to=darinzon@amazon.com \
    --cc=akiyano@amazon.com \
    --cc=aliguori@amazon.com \
    --cc=alisaidi@amazon.com \
    --cc=benh@amazon.com \
    --cc=davem@davemloft.net \
    --cc=dwmw@amazon.co.uk \
    --cc=itzko@amazon.com \
    --cc=kuba@kernel.org \
    --cc=lkp@intel.com \
    --cc=matua@amazon.com \
    --cc=msw@amazon.com \
    --cc=nafea@amazon.com \
    --cc=ndagan@amazon.com \
    --cc=netdev@vger.kernel.org \
    --cc=osamaabb@amazon.com \
    --cc=saeedb@amazon.com \
    --cc=shayagr@amazon.com \
    --cc=simon.horman@corigine.com \
    --cc=zorik@amazon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).