* [PATCH v1 net-next] net: ena: Add missing newline after markup
@ 2023-06-20 7:02 darinzon
2023-06-20 12:47 ` Simon Horman
0 siblings, 1 reply; 3+ messages in thread
From: darinzon @ 2023-06-20 7:02 UTC (permalink / raw)
To: David Miller, Jakub Kicinski, netdev
Cc: David Arinzon, Woodhouse, David, Machulsky, Zorik,
Matushevsky, Alexander, Saeed Bshara, Wilson, Matt,
Liguori, Anthony, Bshara, Nafea, Saidi, Ali,
Herrenschmidt, Benjamin, Kiyanovski, Arthur, Dagan, Noam,
Agroskin, Shay, Itzko, Shahar, Abboud, Osama, kernel test robot
From: David Arinzon <darinzon@amazon.com>
This patch fixes a warning in the ena documentation
file identified by the kernel automatic tools.
Signed-off-by: David Arinzon <darinzon@amazon.com>
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202306171804.U7E92zoE-lkp@intel.com/
---
Documentation/networking/device_drivers/ethernet/amazon/ena.rst | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/networking/device_drivers/ethernet/amazon/ena.rst b/Documentation/networking/device_drivers/ethernet/amazon/ena.rst
index 491492677632..00851ec7b4ec 100644
--- a/Documentation/networking/device_drivers/ethernet/amazon/ena.rst
+++ b/Documentation/networking/device_drivers/ethernet/amazon/ena.rst
@@ -206,6 +206,7 @@ More information about Adaptive Interrupt Moderation (DIM) can be found in
Documentation/networking/net_dim.rst
.. _`RX copybreak`:
+
RX copybreak
============
The rx_copybreak is initialized by default to ENA_DEFAULT_RX_COPYBREAK
--
2.40.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1 net-next] net: ena: Add missing newline after markup
2023-06-20 7:02 [PATCH v1 net-next] net: ena: Add missing newline after markup darinzon
@ 2023-06-20 12:47 ` Simon Horman
2023-06-20 13:25 ` Arinzon, David
0 siblings, 1 reply; 3+ messages in thread
From: Simon Horman @ 2023-06-20 12:47 UTC (permalink / raw)
To: darinzon
Cc: David Miller, Jakub Kicinski, netdev, Woodhouse, David,
Machulsky, Zorik, Matushevsky, Alexander, Saeed Bshara,
Wilson, Matt, Liguori, Anthony, Bshara, Nafea, Saidi, Ali,
Herrenschmidt, Benjamin, Kiyanovski, Arthur, Dagan, Noam,
Agroskin, Shay, Itzko, Shahar, Abboud, Osama, kernel test robot
On Tue, Jun 20, 2023 at 07:02:06AM +0000, darinzon@amazon.com wrote:
> From: David Arinzon <darinzon@amazon.com>
>
> This patch fixes a warning in the ena documentation
> file identified by the kernel automatic tools.
>
> Signed-off-by: David Arinzon <darinzon@amazon.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202306171804.U7E92zoE-lkp@intel.com/
> ---
> Documentation/networking/device_drivers/ethernet/amazon/ena.rst | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/networking/device_drivers/ethernet/amazon/ena.rst b/Documentation/networking/device_drivers/ethernet/amazon/ena.rst
> index 491492677632..00851ec7b4ec 100644
> --- a/Documentation/networking/device_drivers/ethernet/amazon/ena.rst
> +++ b/Documentation/networking/device_drivers/ethernet/amazon/ena.rst
> @@ -206,6 +206,7 @@ More information about Adaptive Interrupt Moderation (DIM) can be found in
> Documentation/networking/net_dim.rst
>
> .. _`RX copybreak`:
> +
> RX copybreak
> ============
> The rx_copybreak is initialized by default to ENA_DEFAULT_RX_COPYBREAK
Thanks David,
this looks good to me.
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Although it doesn't trigger a warning, the formatting of the
text updated below doesn't seem right (I used make htmldocs).
Feel free to take this if it is useful, or say the word and I'll submit
it formally.
diff --git a/Documentation/networking/device_drivers/ethernet/amazon/ena.rst b/Documentation/networking/device_drivers/ethernet/amazon/ena.rst
index 00851ec7b4ec..5eaa3ab6c73e 100644
--- a/Documentation/networking/device_drivers/ethernet/amazon/ena.rst
+++ b/Documentation/networking/device_drivers/ethernet/amazon/ena.rst
@@ -38,6 +38,7 @@ debug logs.
Some of the ENA devices support a working mode called Low-latency
Queue (LLQ), which saves several more microseconds.
+
ENA Source Code Directory Structure
===================================
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH v1 net-next] net: ena: Add missing newline after markup
2023-06-20 12:47 ` Simon Horman
@ 2023-06-20 13:25 ` Arinzon, David
0 siblings, 0 replies; 3+ messages in thread
From: Arinzon, David @ 2023-06-20 13:25 UTC (permalink / raw)
To: Simon Horman
Cc: David Miller, Jakub Kicinski, netdev@vger.kernel.org,
Woodhouse, David, Machulsky, Zorik, Matushevsky, Alexander,
Bshara, Saeed, Wilson, Matt, Liguori, Anthony, Bshara, Nafea,
Saidi, Ali, Herrenschmidt, Benjamin, Kiyanovski, Arthur,
Dagan, Noam, Agroskin, Shay, Itzko, Shahar, Abboud, Osama,
kernel test robot
> On Tue, Jun 20, 2023 at 07:02:06AM +0000, darinzon@amazon.com wrote:
> > From: David Arinzon <darinzon@amazon.com>
> >
> > This patch fixes a warning in the ena documentation file identified by
> > the kernel automatic tools.
> >
> > Signed-off-by: David Arinzon <darinzon@amazon.com>
> > Reported-by: kernel test robot <lkp@intel.com>
> > Closes:
> > https://lore.kernel.org/oe-kbuild-all/202306171804.U7E92zoE-lkp@intel.
> > com/
> > ---
> > Documentation/networking/device_drivers/ethernet/amazon/ena.rst | 1
> +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git
> > a/Documentation/networking/device_drivers/ethernet/amazon/ena.rst
> > b/Documentation/networking/device_drivers/ethernet/amazon/ena.rst
> > index 491492677632..00851ec7b4ec 100644
> > ---
> a/Documentation/networking/device_drivers/ethernet/amazon/ena.rst
> > +++
> b/Documentation/networking/device_drivers/ethernet/amazon/ena.rst
> > @@ -206,6 +206,7 @@ More information about Adaptive Interrupt
> > Moderation (DIM) can be found in
> Documentation/networking/net_dim.rst
> >
> > .. _`RX copybreak`:
> > +
> > RX copybreak
> > ============
> > The rx_copybreak is initialized by default to
> > ENA_DEFAULT_RX_COPYBREAK
>
> Thanks David,
>
> this looks good to me.
>
> Reviewed-by: Simon Horman <simon.horman@corigine.com>
>
> Although it doesn't trigger a warning, the formatting of the text updated
> below doesn't seem right (I used make htmldocs).
> Feel free to take this if it is useful, or say the word and I'll submit it formally.
>
> diff --git
> a/Documentation/networking/device_drivers/ethernet/amazon/ena.rst
> b/Documentation/networking/device_drivers/ethernet/amazon/ena.rst
> index 00851ec7b4ec..5eaa3ab6c73e 100644
> --- a/Documentation/networking/device_drivers/ethernet/amazon/ena.rst
> +++
> b/Documentation/networking/device_drivers/ethernet/amazon/ena.rst
> @@ -38,6 +38,7 @@ debug logs.
>
> Some of the ENA devices support a working mode called Low-latency
> Queue (LLQ), which saves several more microseconds.
> +
> ENA Source Code Directory Structure
> ===================================
>
>
Hi Simon,
Thank you for reviewing and identifying this formatting issue, I'll submit a v2 today.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-06-20 13:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-20 7:02 [PATCH v1 net-next] net: ena: Add missing newline after markup darinzon
2023-06-20 12:47 ` Simon Horman
2023-06-20 13:25 ` Arinzon, David
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).