From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Gao Feng" Subject: Re:Re: Re: [PATCH net] net: Correct wrong skb_flow_limit check when enable RPS Date: Fri, 11 May 2018 22:44:23 +0800 (CST) Message-ID: References: <1525940884-21067-1-git-send-email-gfree.wind@vip.163.com> <7353417.5279.1634ddbc882.Coremail.gfree.wind@vip.163.com> Mime-Version: 1.0 Content-Type: text/plain; charset=GBK Content-Transfer-Encoding: base64 Cc: "davem@davemloft.net" , "daniel@iogearbox.net" , "jakub.kicinski@netronome.com" , "David Ahern" , "netdev@vger.kernel.org" To: "Willem de Bruijn" Return-path: Received: from m172-177.vip.163.com ([123.58.177.172]:52884 "EHLO m172-177.vip.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753191AbeEKOvV (ORCPT ); Fri, 11 May 2018 10:51:21 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: QXQgMjAxOC0wNS0xMSAyMToyMzo1NSwgIldpbGxlbSBkZSBCcnVpam4iIDx3aWxsZW1kZWJydWlq bi5rZXJuZWxAZ21haWwuY29tPiB3cm90ZToKPk9uIEZyaSwgTWF5IDExLCAyMDE4IGF0IDI6MjAg QU0sIEdhbyBGZW5nIDxnZnJlZS53aW5kQHZpcC4xNjMuY29tPiB3cm90ZToKPj4gQXQgMjAxOC0w NS0xMSAxMTo1NDo1NSwgIldpbGxlbSBkZSBCcnVpam4iIDx3aWxsZW1kZWJydWlqbi5rZXJuZWxA Z21haWwuY29tPiB3cm90ZToKPj4+T24gVGh1LCBNYXkgMTAsIDIwMTggYXQgNDoyOCBBTSwgIDxn ZnJlZS53aW5kQHZpcC4xNjMuY29tPiB3cm90ZToKPj4+PiBGcm9tOiBHYW8gRmVuZyA8Z2ZyZWUu d2luZEB2aXAuMTYzLmNvbT4KPj4+Pgo+Pj4+IFRoZSBza2IgZmxvdyBsaW1pdCBpcyBpbXBsZW1l bnRlZCBmb3IgZWFjaCBDUFUgaW5kZXBlbmRlbnRseS4gSW4gdGhlCj4+Pj4gY3VycmVudCBjb2Rl cywgdGhlIGZ1bmN0aW9uIHNrYl9mbG93X2xpbWl0IGdldHMgdGhlIHNvZnRuZXRfZGF0YSBieQo+ Pj4+IHRoaXNfY3B1X3B0ci4gQnV0IHRoZSB0YXJnZXQgY3B1IG9mIGVucXVldWVfdG9fYmFja2xv ZyB3b3VsZCBiZSBub3QKPj4+PiB0aGUgY3VycmVudCBjcHUgd2hlbiBlbmFibGUgUlBTLiBBcyB0 aGUgcmVzdWx0LCB0aGUgc2tiX2Zsb3dfbGltaXQgY2hlY2tzCj4+Pj4gdGhlIHN0YXRzIG9mIGN1 cnJlbnQgQ1BVLCB3aGlsZSB0aGUgc2tiIGlzIGdvaW5nIHRvIGFwcGVuZCB0aGUgcXVldWUgb2YK Pj4+PiBhbm90aGVyIENQVS4gSXQgaXNuJ3QgdGhlIGV4cGVjdGVkIGJlaGF2aW9yLgo+Pj4+Cj4+ Pj4gTm93IHBhc3MgdGhlIHNvZnRuZXRfZGF0YSBhcyBhIHBhcmFtIHRvIHNvZnRuZXRfZGF0YSB0 byBtYWtlIGNvbnNpc3RlbnQuCj4+Pgo+Pj5UaGUgbG9jYWwgY3B1IHNvZnRuZXRfZGF0YSBpcyB1 c2VkIG9uIHB1cnBvc2UuIFRoZSBvcGVyYXRpb25zIGluCj4+PnNrYl9mbG93X2xpbWl0KCkgb24g c2QgZmllbGRzIGNvdWxkIHJhY2UgaWYgbm90IGV4ZWN1dGVkIG9uIHRoZSBsb2NhbCBjcHUuCj4+ Cj4+IEkgdGhpbmsgdGhlIHJhY2UgZG9lc24ndCBleGlzdCBiZWNhdXNlIG9mIHRoZSBycHNfbG9j ay4KPj4gVGhlIGVucXVldWVfdG9fYmFja2xvZyBoYXMgaG9sZCB0aGUgcnBzX2xvY2sgYmVmb3Jl IHNrYl9mbG93X2xpbWl0Lgo+Cj5JbmRlZWQsIEkgb3Zlcmxvb2tlZCB0aGF0LiBUaGVyZSBzdGls bCBpcyB0aGUgbWF0dGVyIG9mIGNhY2hlIGNvbnRlbnRpb24uCgpUaGUgY2FjaGUgY29udGVudGlv biBpcyByZWFsbHkgaW1wb3J0YW50IGluIHRoaXMgY2FzZT8KSSBkb24ndCB0aGluayBzbywgYmVj YXVzZSB0aGUgZW5xdWV1ZV90b19iYWNrbG9nIGhhdmUgdG91Y2hlZCBhbmQgbW9kaWZpZWQgdGhl IHNvZnRuZXRfc3RhdApvZiB0YXJnZXQgY3B1LgoKPgo+Pj5GbG93IGxpbWl0IHRyaWVzIHRvIGRl dGVjdCBsYXJnZSAoImVsZXBoYW50IikgRG9TIGZsb3dzIHdpdGggYSBmaXhlZCBmb3VyLXR1cGxl Lgo+Pj5UaGVzZSB3b3VsZCBhbHdheXMgaGl0IHRoZSBzYW1lIFJQUyBjcHUsIHNvIHRoYXQgY3B1 IGJlaW5nIGJhY2tsb2dnZWQKPj4KPj4gVGhleSBtYXkgaGl0IHRoZSBkaWZmZXJlbnQgdGFyZ2V0 IENQVSB3aGVuIGVuYWJsZSBSRlMuIEJlY2F1c2UgdGhlIGFwcCBjb3VsZCBiZSBzY2hlZHVsZWQK Pj4gdG8gYW5vdGhlciBDUFUsIHRoZW4gUkZTIHRyaWVzIHRvIGRlbGl2ZXIgdGhlIHNrYiB0byBs YXRlc3QgY29yZSB3aGljaCBoYXMgaG90IGNhY2hlLgo+Cj5UaGlzIGV2ZW4gbW9yZSBzdWdnZXN0 IHVzaW5nIHRoZSBpbml0aWFsIChvciBJUlEpIGNwdSB0byB0cmFjayBzdGF0ZSwgaW5zdGVhZAo+ b2YgdGhlIGRlc3RpbmF0aW9uIChSUFMvUkZTKSBjcHUuCgpJIGNvdWxkbid0IHVuZGVyc3RhbmQg d2h5IGl0IGlzIGJldHRlciB0byB0cmFjayBzdGF0ZSBvbiBpbml0aWFsIGNwdSwgbm90IHRoZSB0 YXJnZXQgY3B1LgpUaGUgbGF0dGVyIG9uZSBjb3VsZCBnZXQgbW9yZSBhY2N1cmF0ZSByZXN1bHQu Cgo+Cj4+Pm1heSBiZSBhbiBpbmRpY2F0aW9uIHRoYXQgc3VjaCBhIGZsb3cgaXMgYWN0aXZlLiBC dXQgdGhlIGZsb3cgd2lsbCBhbHNvIGFsd2F5cwo+Pj5hcnJpdmUgb24gdGhlIHNhbWUgaW5pdGlh bCBjcHUgY291cnRlc3kgb2YgUlNTLiBTbyBzdG9yaW5nIHRoZSBsb29rdXAgdGFibGUKPj4KPj4g VGhlIFJTUyBjb3VsZG4ndCBtYWtlIHN1cmUgdGhlIGlycSBpcyBoYW5kbGVkIGJ5IHNhbWUgY3B1 LiBJdCB3b3VsZCBiZSBiYWxhbmNlZCBiZXR3ZWVuCj4+IHRoZSBjcHVzLgo+Cj5JUlFzIGFyZSB1 c3VhbGx5IHBpbm5lZCB0byBjb3Jlcy4gVW5sZXNzIHVzaW5nIHNvbWV0aGluZyBsaWtlIGlycWJh bGFuY2UsCj5idXQgdGhhdCBvcGVyYXRlcyBhdCB0b28gY29hcnNlIGEgdGltZXNjYWxlIHRvIGRv IGFueXRoaW5nIHVzZWZ1bCBhdCBNcHBzCj5wYWNrZXQgcmF0ZXMuCgpUaGVyZSBhcmUgc29tZSBt b3RoZXJib2FyZCB3aGljaCBjb3VsZG4ndCBtYWtlIHN1cmUgdGhlIGlycSBpcyBwaW5uZWQuClRo ZSBmbG93X2xpbWl0IHdvdWxkbid0IHdvcmsgYXMgd2VsbCBhcyBleHBlY3RlZC4KCj4KPj4+b24g dGhlIGluaXRpYWwgQ1BVIGlzIGFsc28gZmluZS4gVGhlcmUgbWF5IGJlIGZhbHNlIHBvc2l0aXZl cyBvbiBvdGhlciBDUFVzCj4+PndpdGggdGhlIHNhbWUgUlBTIGRlc3RpbmF0aW9uLCBidXQgdGhh dCBpcyB1bmxpa2VseSB3aXRoIGEgaGlnaGx5IGNvbmN1cnJlbnQKPj4+dHJhZmZpYyBzZXJ2ZXIg bWl4ICgibWljZSIpLgo+Pgo+PiBJZiBteSBjb21tZW50IGlzIHJpZ2h0LCB0aGUgZmxvdyBjb3Vs ZG4ndCBhbHdheXMgYXJyaXZlIG9uZSB0aGUgc2FtZSBpbml0aWFsIGNwdSwgIGFsdGhvdWdoCj4+ IGl0IG1heSBiZSBzZW50IHRvIG9uZSBzYW1lIHRhcmdldCBjcHUuCj4+Cj4+Pgo+Pj5Ob3RlIHRo YXQgdGhlIHN5c2N0bCBuZXQuY29yZS5mbG93X2xpbWl0X2NwdV9iaXRtYXAgZW5hYmxlcyB0aGUg ZmVhdHVyZQo+Pj5mb3IgdGhlIGNwdXMgb24gd2hpY2ggdHJhZmZpYyBpbml0aWFsbHkgbGFuZHMs IG5vdCB0aGUgUlBTIGRlc3RpbmF0aW9uIGNwdXMuCj4+PlNlZSBhbHNvIERvY3VtZW50YXRpb24v bmV0d29ya2luZy9zY2FsaW5nLnR4dAo+Pj4KPj4+VGhhdCBzYWlkLCBJIGhhZCB0byByZXJlYWQg dGhlIGNvZGUsIGFzIGl0IGRvZXMgc2VlbSBzZW5zaWJsZSB0aGF0IHRoZQo+Pj5zYW1lIHNvZnRu ZXRfZGF0YSBpcyBpbnRlbmRlZCB0byBiZSB1c2VkIGJvdGggd2hlbiB0ZXN0aW5nIHFsZW4gYW5k Cj4+PmZsb3dfbGltaXQuCj4+Cj4+IEluIG1vc3QgY2FzZXMsIHVzZXIgY29uZmlndXJlcyB0aGUg c2FtZSBSUFMgbWFwIHdpdGggZmxvd19saW1pdCBsaWtlIDB4ZmYuCj4+IEJlY2F1c2UgdXNlciBj b3VsZG4ndCBwcmVkaWN0IHdoaWNoIGNvcmUgdGhlIGV2aWwgZmxvdyB3b3VsZCBhcnJpdmUgb24u Cj4+Cj4+IFRha2UgYW4gZXhhbXBsZSwgdGhlcmUgYXJlIDIgY29yZXMsIGNwdTAgYW5kIGNwdTEu Cj4+IE9uZSBmbG93IGlzIHRoZSBhbiBldmlsIGZsb3csIGJ1dCB0aGUgaXJxIGlzIHNlbnQgdG8g Y3B1MC4gQWZ0ZXIgUlBTL1JGUywgdGhlIHRhcmdldCBjcHUgaXMgY3B1MS4KPj4gTm93IGNwdTAg aW52b2tlcyBlbnF1ZXVlX3RvX2JhY2tsb2csIHRoZW4gdGhlIHNrYl9mbG93X2xpbWl0IGNoZWNr ZXMgdGhlIHF1ZXVlIGxlbmd0aAo+PiBvZiBjcHUwLiBDZXJ0YWlubHkgaXQgY291bGQgcGFzcyB0 aGUgY2hlY2sgb2Ygc2tiX2Zsb3dfbGltaXQgYmVjYXVzZSB0aGVyZSBpcyBubyBhbnkgZXZpbCBm bG93IG9uIGNwdTAuCj4KPk5vLCBlbnF1ZXVlX3RvX2JhY2tsb2cgcGFzc2VzIHFsZW4gdG8gc2ti X2Zsb3dfbGltaXQsIHNvIHRoYXQgZG9lcwo+Y2hlY2sgdGhlIHF1ZXVlIGxlbmd0aCBvZiB0aGUg UlBTIGNwdS4KClNvcnJ5LCBJIG92ZXJsb29rZWQgdGhlIHFsZW4gaXMgdGhlIGxlbmd0aCBvZiB0 aGUgcnBzIGNwdS4KVGhlbiBpdCdzIG9rIHVubGVzcyB0aGUgc3RhdHMgbWF5IGJlIG5vdCBhY2N1 cmF0ZSB3aGVuIGlycSBpc24ndCBwaW5uZWQuCgpCdXQgSSBzdGlsbCBkb3VidCB0aGF0IGlzIGl0 IHJlYWxseSBpbXBvcnRhbnQgdG8gdHJhY2sgc3RhdGUgb24gaW5pdGlhbCBjcHUsIG5vdCB0YXJn ZXQgY3B1PwpCZWNhdXNlIHRoZSBlbnF1ZXVlX3RvX2JhY2tsb2cgaGF2ZSB0b3VjaGVkIHRoZSBz b2Z0bmV0X2RhdGEgb2YgdGFyZ2V0IGNwdS4KCkJlc3QgUmVnYXJkcwpGZW5nCgo+Cj4+IFRoZW4g dGhlIGNwdTAgaW5zZXJ0cyB0aGUgc2tiIGludG8gdGhlIHF1ZXVlIG9mIGNwdTEuCj4+IEFzIGEg cmVzdWx0LCB0aGUgc2tiX2Zsb3dfbGltaXQgZG9lc24ndCB3b3JrIGFzIGV4cGVjdGVkLgo+Pgo+ PiBCVFcsIEkgaGF2ZSBhbHJlYWR5IHNlbnQgdGhlIHYyIHBhdGNoIHdoaWNoIG9ubHkgYWRkcyB0 aGUgIkZpeGVzOiB0YWciLgo+Cj5UaGUgY2hhbmdlIGFsc28gbWFrZXMgdGhlIGNvZGUgaW5jb25z aXN0ZW50IHdpdGgKPkRvY3VtZW50YXRpb24vbmV0d29ya2luZy9zY2FsaW5nLnR4dAo+Cj4iSW4g c3VjaCBlbnZpcm9ubWVudHMsIGVuYWJsZSB0aGUgZmVhdHVyZSBvbiBhbGwgQ1BVcyB0aGF0IGhh bmRsZQo+bmV0d29yayByeCBpbnRlcnJ1cHRzIChhcyBzZXQgaW4gL3Byb2MvaXJxL04vc21wX2Fm ZmluaXR5KS4iCg==