From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78D1EC43381 for ; Fri, 1 Mar 2019 18:55:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4D3672070B for ; Fri, 1 Mar 2019 18:55:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="o/OJRPDW" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387949AbfCASzL (ORCPT ); Fri, 1 Mar 2019 13:55:11 -0500 Received: from mail-wr1-f68.google.com ([209.85.221.68]:35534 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726195AbfCASzK (ORCPT ); Fri, 1 Mar 2019 13:55:10 -0500 Received: by mail-wr1-f68.google.com with SMTP id t18so26998628wrx.2 for ; Fri, 01 Mar 2019 10:55:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:from:subject:cc:message-id:date:user-agent:mime-version :content-language:content-transfer-encoding; bh=eSJFKC3FooYWxCoy++c5NSyY/9nTyquG0uQ6ShIaxVo=; b=o/OJRPDWr6f8OAwN6Ys/Lws3tKKra197R+X02mQD0+7VxtPNHJRR2NdH2aNAGI0aYA Bh7Jd+rLtyjvDg8zxcBqNaBx1CYoIHlBc9N1uo8BnxjI2R67SMLT3taVQVyHb6RxvwmW FpIJLxYPsXIhbx31yzE7YTI3/kBPA5MJCCMlKR7FCZzlQ9Uh7Nhqswy/e9mYWZeMIQhI wRd1HFXrZyrt8GM8DpUbcEEVIejR1sBmRMZKN3RD5tVaLSTDdyE3VMmr9V+b6Gtq60M0 NMQ/UITvTT40IH4hlv+CmU8hqH91xLLJzlv/BPNzRiMyhORsE5bTJrn39GstWSN/kJ/c +Cfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:from:subject:cc:message-id:date:user-agent :mime-version:content-language:content-transfer-encoding; bh=eSJFKC3FooYWxCoy++c5NSyY/9nTyquG0uQ6ShIaxVo=; b=fIiCfQR+YUFfraJ2LKBRBeJROJKIX1K36C00ASyYHj8FPfkzHJzxyQ4qtI7hVA30bD QJzp1ubXtGqx8nh17+LIbmT6VDEdysXFjFvGKhvxtAJ08PEl/9PcqJZBIlmWV4+uQDtG otKkA1MdFSe0yZM5H9KQ7Bf7MkVhrI+qk7qsSQXWK3/aV5Vxk2EY6zB+UYrhFpBWNF7z cAOfXOc49WPkLNu7x9RCA3cIwulov2uBCmTx44qCbkgQjEkwsvUZAiB71yo3MXp4Ttkc hNZ9q4uvhC5b4l0Z8ax5SG9VxXbKW9zQmgE6QkwaiIG0/EKRQaSRs/hJlLTFVEr8/2XF gRuA== X-Gm-Message-State: APjAAAXxWYlRAMHu4qrDUTw4KXnPynsnp6+IO93ieUVBvNfS/QJ5yptd a3gRn8Jdv3CY7WVcLMJRzQGUm8JM X-Google-Smtp-Source: APXvYqw1RQncwIpmwJkL2EzAEZF42fCJzex7Tu6k6grDo/ZuF5ZaAvMCju1oNKnj1/y0YbvGOpS0kA== X-Received: by 2002:adf:e8cf:: with SMTP id k15mr4275484wrn.193.1551466508217; Fri, 01 Mar 2019 10:55:08 -0800 (PST) Received: from ?IPv6:2003:ea:8bf1:e200:1933:14e5:bff9:e5d0? (p200300EA8BF1E200193314E5BFF9E5D0.dip0.t-ipconnect.de. [2003:ea:8bf1:e200:1933:14e5:bff9:e5d0]) by smtp.googlemail.com with ESMTPSA id z198sm8243666wmc.10.2019.03.01.10.55.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 01 Mar 2019 10:55:07 -0800 (PST) To: Vivien Didelot , Andrew Lunn , Florian Fainelli , David Miller From: Heiner Kallweit Subject: [PATCH net] net: dsa: mv88e6xxx: handle unknown duplex modes gracefully in mv88e6xxx_port_set_duplex Cc: "netdev@vger.kernel.org" Message-ID: Date: Fri, 1 Mar 2019 19:53:57 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org When testing another issue I faced the problem that mv88e6xxx_port_setup_mac() failed due to DUPLEX_UNKNOWN being passed as argument to mv88e6xxx_port_set_duplex(). We should handle this case gracefully and return -EOPNOTSUPP, like e.g. mv88e6xxx_port_set_speed() is doing it. Fixes: 7f1ae07b51e8 ("net: dsa: mv88e6xxx: add port duplex setter") Signed-off-by: Heiner Kallweit --- drivers/net/dsa/mv88e6xxx/port.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/dsa/mv88e6xxx/port.c b/drivers/net/dsa/mv88e6xxx/port.c index e12e0bdfc..d907c8590 100644 --- a/drivers/net/dsa/mv88e6xxx/port.c +++ b/drivers/net/dsa/mv88e6xxx/port.c @@ -190,7 +190,7 @@ int mv88e6xxx_port_set_duplex(struct mv88e6xxx_chip *chip, int port, int dup) /* normal duplex detection */ break; default: - return -EINVAL; + return -EOPNOTSUPP; } err = mv88e6xxx_port_write(chip, port, MV88E6XXX_PORT_MAC_CTL, reg); -- 2.21.0