From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3341B38B982; Mon, 19 Jan 2026 15:33:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768836832; cv=none; b=QkhlWw67eUh898uoryHsX+b2S5hQymJ39rFyU1Bqy3SbhPraaIDG21CXffBbteQugk92GSqmD54zRSt4rtuWeUpkDiazFkAH9fNWnuXsqPI6dlU7Qoyg+4X/Gsrl5C8gpXJzwabwYJ22QaHOfmE+LbM15jD3nY6kfFen0R5EUnY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768836832; c=relaxed/simple; bh=qkvTJQax5W82pTYLAo87bYZdeR/1lwn1TQjZtjyXQ60=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lYCPmkJGqoBAt8wIVW846XxF/8hXYYPqxNnGOmxhDzbqR9FIKL2MBzwTLrCpROdBXSELJlHcRoRVVVfskEfhc/x6nwQ5P/AEZYJ7G+QAFRoRtiBJYud/teALdfGs02L4o6v9wC/d/4lwVkXHBGIeF069I55Ya6I2Ez9D+tWBiMM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=Ifh2Ust2; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="Ifh2Ust2" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id 941FD1A295C; Mon, 19 Jan 2026 15:33:48 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 5551B60731; Mon, 19 Jan 2026 15:33:48 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id A0C8410B6B141; Mon, 19 Jan 2026 16:33:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1768836827; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references; bh=fB4EnfaJdnHJwvic/r+gC6YvhHwxYFGBOmlA5frAe5M=; b=Ifh2Ust2NQlwh/7BaY2Io6qs9TzsJ0zMHAKcvN1s+yqoA5hMxq+fZgE+74huWRQL25ly16 EkgxZL97qepeaHxcjyZtRNrJ1nKWewL7FVISPN8PA0/jixiChOixncY6vmMFO50zwKTsSt Ag+vc7yI+MP47Gkw3HuNO6BhiIaQQb8c7JQ84jLNqzyGoe0vt+uBHxqtMqXH4QgjnS4ATw n7GNiaF1IIvdFJQe9pZm/tFVFT2wpXtBnS8gWGvLKb7usJ0MVXc9OWsuiJPZaxmFlHQFGU bvfmmoRy0BgN8PdEXlOAzWLwf9FFmJ+yRXptu1oFN+BpvT4FA7EFkUv6CvJ+sA== Message-ID: Date: Mon, 19 Jan 2026 16:33:35 +0100 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 net-next 2/5] net: phy: air_en8811h: deprecate "airoha,pnswap-rx" and "airoha,pnswap-tx" To: Vladimir Oltean , netdev@vger.kernel.org, devicetree@vger.kernel.org Cc: linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, Daniel Golle , Horatiu Vultur , =?UTF-8?Q?Bj=C3=B8rn_Mork?= , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Eric Woudstra , Alexander Couzens , "Chester A. Unal" , DENG Qingfang , Sean Wang , Felix Fietkau References: <20260119091220.1493761-1-vladimir.oltean@nxp.com> <20260119091220.1493761-3-vladimir.oltean@nxp.com> From: Maxime Chevallier Content-Language: en-US In-Reply-To: <20260119091220.1493761-3-vladimir.oltean@nxp.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Last-TLS-Session-Version: TLSv1.3 Hi Vladimir, On 19/01/2026 10:12, Vladimir Oltean wrote: > Prefer the new "rx-polarity" and "tx-polarity" properties, and use the > vendor specific ones as fallback if the standard description doesn't > exist. > > Signed-off-by: Vladimir Oltean Reviewed-by: Maxime Chevallier Thanks, Maxime > --- > v2->v4: none > v1->v2: > - adapt to API change: error code and returned value have been split > - bug fix: supported mask of polarities should be BIT(PHY_POL_NORMAL) | > BIT(PHY_POL_INVERT) rather than PHY_POL_NORMAL | PHY_POL_INVERT. > > drivers/net/phy/Kconfig | 1 + > drivers/net/phy/air_en8811h.c | 53 +++++++++++++++++++++++++---------- > 2 files changed, 39 insertions(+), 15 deletions(-) > > diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig > index a7ade7b95a2e..7b73332a13d9 100644 > --- a/drivers/net/phy/Kconfig > +++ b/drivers/net/phy/Kconfig > @@ -98,6 +98,7 @@ config AS21XXX_PHY > > config AIR_EN8811H_PHY > tristate "Airoha EN8811H 2.5 Gigabit PHY" > + select PHY_COMMON_PROPS > help > Currently supports the Airoha EN8811H PHY. > > diff --git a/drivers/net/phy/air_en8811h.c b/drivers/net/phy/air_en8811h.c > index badd65f0ccee..e890bb2c0aa8 100644 > --- a/drivers/net/phy/air_en8811h.c > +++ b/drivers/net/phy/air_en8811h.c > @@ -14,6 +14,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -966,11 +967,45 @@ static int en8811h_probe(struct phy_device *phydev) > return 0; > } > > +static int en8811h_config_serdes_polarity(struct phy_device *phydev) > +{ > + struct device *dev = &phydev->mdio.dev; > + unsigned int pol, default_pol; > + u32 pbus_value = 0; > + int ret; > + > + default_pol = PHY_POL_NORMAL; > + if (device_property_read_bool(dev, "airoha,pnswap-rx")) > + default_pol = PHY_POL_INVERT; > + > + ret = phy_get_rx_polarity(dev_fwnode(dev), phy_modes(phydev->interface), > + BIT(PHY_POL_NORMAL) | BIT(PHY_POL_INVERT), > + default_pol, &pol); > + if (ret) > + return ret; > + if (pol == PHY_POL_INVERT) > + pbus_value |= EN8811H_POLARITY_RX_REVERSE; > + > + default_pol = PHY_POL_NORMAL; > + if (device_property_read_bool(dev, "airoha,pnswap-tx")) > + default_pol = PHY_POL_INVERT; > + > + ret = phy_get_tx_polarity(dev_fwnode(dev), phy_modes(phydev->interface), > + BIT(PHY_POL_NORMAL) | BIT(PHY_POL_INVERT), > + default_pol, &pol); > + if (ret) > + return ret; > + if (pol == PHY_POL_NORMAL) > + pbus_value |= EN8811H_POLARITY_TX_NORMAL; > + > + return air_buckpbus_reg_modify(phydev, EN8811H_POLARITY, > + EN8811H_POLARITY_RX_REVERSE | > + EN8811H_POLARITY_TX_NORMAL, pbus_value); > +} > + > static int en8811h_config_init(struct phy_device *phydev) > { > struct en8811h_priv *priv = phydev->priv; > - struct device *dev = &phydev->mdio.dev; > - u32 pbus_value; > int ret; > > /* If restart happened in .probe(), no need to restart now */ > @@ -1003,19 +1038,7 @@ static int en8811h_config_init(struct phy_device *phydev) > if (ret < 0) > return ret; > > - /* Serdes polarity */ > - pbus_value = 0; > - if (device_property_read_bool(dev, "airoha,pnswap-rx")) > - pbus_value |= EN8811H_POLARITY_RX_REVERSE; > - else > - pbus_value &= ~EN8811H_POLARITY_RX_REVERSE; > - if (device_property_read_bool(dev, "airoha,pnswap-tx")) > - pbus_value &= ~EN8811H_POLARITY_TX_NORMAL; > - else > - pbus_value |= EN8811H_POLARITY_TX_NORMAL; > - ret = air_buckpbus_reg_modify(phydev, EN8811H_POLARITY, > - EN8811H_POLARITY_RX_REVERSE | > - EN8811H_POLARITY_TX_NORMAL, pbus_value); > + ret = en8811h_config_serdes_polarity(phydev); > if (ret < 0) > return ret; >