From: Karsten Graul <kgraul@linux.ibm.com>
To: Daxing Guo <guodaxing@huawei.com>, netdev@vger.kernel.org
Cc: chenzhe@huawei.com, linux-s390@vger.kernel.org, greg@kroah.com
Subject: Re: [PATCH] net/smc: loop in smc_listen
Date: Mon, 22 Nov 2021 08:28:33 +0100 [thread overview]
Message-ID: <ac52dbfe-edd9-dd8f-c2f8-a96fea10884d@linux.ibm.com> (raw)
In-Reply-To: <20211120075451.16764-1-guodaxing@huawei.com>
On 20/11/2021 08:54, Daxing Guo wrote:
> From: Guo DaXing <guodaxing@huawei.com>
>
> The kernel_listen function in smc_listen will fail when all the available
> ports are occupied. At this point smc->clcsock->sk->sk_data_ready has
> been changed to smc_clcsock_data_ready. When we call smc_listen again,
> now both smc->clcsock->sk->sk_data_ready and smc->clcsk_data_ready point
> to the smc_clcsock_data_ready function.
>
> The smc_clcsock_data_ready() function calls lsmc->clcsk_data_ready which
> now points to itself resulting in an infinite loop.
>
> This patch restores smc->clcsock->sk->sk_data_ready with the old value.
>
> Signed-off-by: Guo DaXing <guodaxing@huawei.com>
> ---
Thanks for your patch, I will pick it up and submit it to the net tree.
next prev parent reply other threads:[~2021-11-22 7:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-20 7:54 [PATCH] net/smc: loop in smc_listen Daxing Guo
2021-11-22 3:19 ` Tony Lu
2021-11-22 7:28 ` Karsten Graul [this message]
2021-11-22 8:37 ` Tony Lu
[not found] <aec0a1e1964b4696b8636ce3945e6551@huawei.com>
2021-11-19 7:09 ` greg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac52dbfe-edd9-dd8f-c2f8-a96fea10884d@linux.ibm.com \
--to=kgraul@linux.ibm.com \
--cc=chenzhe@huawei.com \
--cc=greg@kroah.com \
--cc=guodaxing@huawei.com \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).