From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fhigh-a1-smtp.messagingengine.com (fhigh-a1-smtp.messagingengine.com [103.168.172.152]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 82B273BE640; Thu, 2 Apr 2026 11:37:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.152 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775129836; cv=none; b=uGEi94fRBNxEYdyjuJnaCzsL+Yc1jb1SWUG+yGsPKR3HKIjviKhmoCt5i1PNRprMFvGPWHTK5Cas9//61ikReSPpirK38OXkWEYHDEy6u1nlgr6TlKoLOdoNJb0dZnwfgVbNF0WE5X1nlIirKeCrEjZZZ/F5OInl2dPxsXrfV1Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775129836; c=relaxed/simple; bh=YtVI4AgHwJtUENT6p3xzig+p7Q9T8b/oQ0tZTNdIFRc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=B9ecsZWFduURLSikTM9Gh32CYPNmQsKpCHwM1lZHtRgudr56AbW5x0OsZGOfNEFoJ18CKu3P29l4JBbPcWq3wc+wGi3bXRWM3lb9Tn239R7mckvads3u/V0N9mjPsF6XRB1b5taod7X3zpfCNAf6CuWF4Hr2cyaIhF0ZI1g7mRc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=queasysnail.net; spf=pass smtp.mailfrom=queasysnail.net; dkim=pass (2048-bit key) header.d=queasysnail.net header.i=@queasysnail.net header.b=RfFDkdtU; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=BkV3Czmh; arc=none smtp.client-ip=103.168.172.152 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=queasysnail.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=queasysnail.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=queasysnail.net header.i=@queasysnail.net header.b="RfFDkdtU"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="BkV3Czmh" Received: from phl-compute-02.internal (phl-compute-02.internal [10.202.2.42]) by mailfhigh.phl.internal (Postfix) with ESMTP id 7AB671400285; Thu, 2 Apr 2026 07:37:03 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-02.internal (MEProxy); Thu, 02 Apr 2026 07:37:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=queasysnail.net; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm3; t=1775129823; x= 1775216223; bh=3ax/Y5Jw8jmWhL4qQAuF/j7sP4Eeb8pjR3+iBd6r6aU=; b=R fFDkdtUbOAascrUk5Xcp1Wa922lBCba+2E54tOsnWrsln0RZCvCwhh8Fk13N0uFG uSMbXM+wqbwA5WqyZxDQ6Jr2gwBqKQnR80eILhrWywV9xOdAcohlB8yic0Cz2G4m 0jNgyDXjflEWnTDdwVdeKeYCuyjUmKC9d5YHsspwUwSLj0CMshuGbCH4uhGwTbug TJxpQpJWj4oeU+2Oyo9D5C9V9mYkBK+ryiexyfoeMDwhVGSDqq2RMwIUF3EBUDTz jKucHvo9y62vFTe5fI1KL9x9zEY1r7+A3Fr9ETpwre1akvoqBcVCJRJZeW/WDsqJ 8GpnFREKhGqgiNvJmwqbw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1775129823; x=1775216223; bh=3ax/Y5Jw8jmWhL4qQAuF/j7sP4Eeb8pjR3+ iBd6r6aU=; b=BkV3Czmh2cfUxv+2eS7kwP+T88JvYLjc3e3K19KLkN5dNHLGLPa efPTYkb++0Z5sHbw+V/gLZIIqEluAZPHemLYoQZmVlmwVu98dM42/EVibxTXY/Fq C4OB2rvasgwEps9Hj1TB3JEKxlqMKM4jIsHYqtdY+QqHNcgZX5CAUYRTcoekTN89 ESeqHvTP7BkTrBIi4Oj13K/JSFjvQ9q2VbqKCz7dvscX5Gk5XMZKdJFPYV/4+BEv G4w8y8qj6sJqxQf4UaQPo58Ielra6hxnt4RdTx501gqiim1AaOBMNqYu+gjIagiV YxduTf4hTTV9fAjM/GR6y3fciYFvjvH8E4Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefhedrtddtgdehleefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceurghi lhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurh epfffhvfevuffkfhggtggujgesthdtredttddtjeenucfhrhhomhepufgrsghrihhnrgcu ffhusghrohgtrgcuoehsugesqhhuvggrshihshhnrghilhdrnhgvtheqnecuggftrfgrth htvghrnhepuefhhfffgfffhfefueeiudegtdefhfekgeetheegheeifffguedvuefffefg udffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepsh gusehquhgvrghshihsnhgrihhlrdhnvghtpdhnsggprhgtphhtthhopeduvddpmhhouggv pehsmhhtphhouhhtpdhrtghpthhtoheptghrrghtihhusehnvhhiughirgdrtghomhdprh gtphhtthhopehnvghtuggvvhesvhhgvghrrdhkvghrnhgvlhdrohhrghdprhgtphhtthho pegrnhgurhgvfidonhgvthguvghvsehluhhnnhdrtghhpdhrtghpthhtohepuggrvhgvmh esuggrvhgvmhhlohhfthdrnhgvthdprhgtphhtthhopegvughumhgriigvthesghhoohhg lhgvrdgtohhmpdhrtghpthhtohepkhhusggrsehkvghrnhgvlhdrohhrghdprhgtphhtth hopehprggsvghnihesrhgvughhrghtrdgtohhmpdhrtghpthhtohephhhorhhmsheskhgv rhhnvghlrdhorhhgpdhrtghpthhtohepshgufhesfhhomhhitghhvghvrdhmvg X-ME-Proxy: Feedback-ID: i934648bf:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 2 Apr 2026 07:37:02 -0400 (EDT) Date: Thu, 2 Apr 2026 13:37:00 +0200 From: Sabrina Dubroca To: Cosmin Ratiu Cc: netdev@vger.kernel.org, Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Stanislav Fomichev , Shuah Khan , linux-kselftest@vger.kernel.org, Dragos Tatulea Subject: Re: [PATCH net v6 3/4] selftests: Add MACsec VLAN propagation traffic test Message-ID: References: <20260330130130.989236-1-cratiu@nvidia.com> <20260330130130.989236-4-cratiu@nvidia.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260330130130.989236-4-cratiu@nvidia.com> 2026-03-30, 16:01:29 +0300, Cosmin Ratiu wrote: > +def _get_mac(ifname, host=None): > + """Gets MAC address of an interface.""" > + dev = ip(f"-d link show dev {ifname}", json=True, host=host) nit: MAC address doesn't need '-d' I would have used fixed SCI on both ends to avoid this mess with the local/remote MAC address, but it's ok as you wrote it. > + return dev[0]["address"] [...] > +def _check_nsim_vid(cfg, vid, expected) -> None: > + """Checks if a VLAN is present. Only works on netdevsim.""" > + > + nsim = cfg.get_local_nsim_dev() > + if not nsim: > + return > + > + vlan_path = nsim.nsims[0].dfs_dir + "vlan" nit: os.path.join for consistency with other users > + with open(vlan_path, encoding="utf-8") as f: > + vids = f.read() > + found = f"ctag {vid}\n" in vids > + ksft_eq(found, expected, > + f"VLAN {vid} {'expected' if expected else 'not expected'}" > + f" in debugfs") -- Sabrina