public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Steffen Klassert <steffen.klassert@secunet.com>
To: Yasuaki Torimaru <yasuakitorimaru@gmail.com>
Cc: <netdev@vger.kernel.org>, <herbert@gondor.apana.org.au>,
	<davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
	<pabeni@redhat.com>, <horms@kernel.org>
Subject: Re: [PATCH] xfrm: clear trailing padding in build_polexpire()
Date: Mon, 23 Mar 2026 13:21:40 +0100	[thread overview]
Message-ID: <acEwVDyy7dDQs6og@secunet.com> (raw)
In-Reply-To: <20260321210421.2504711-1-yasuakitorimaru@gmail.com>

On Sun, Mar 22, 2026 at 06:04:21AM +0900, Yasuaki Torimaru wrote:
> build_expire() clears the trailing padding bytes of struct
> xfrm_user_expire after setting the hard field via memset_after(),
> but the analogous function build_polexpire() does not do this for
> struct xfrm_user_polexpire.
> 
> The 7 bytes of padding after the __u8 hard field are left
> uninitialized from the heap allocation, and are then sent to
> userspace via netlink multicast to XFRMNLGRP_EXPIRE listeners,
> leaking kernel heap memory contents.
> 
> Add the missing memset_after() call, matching build_expire().
> 
> Signed-off-by: Yasuaki Torimaru <yasuakitorimaru@gmail.com>

Can you please add a 'Fixes:' tag, so it can be backported?

Thanks!


  reply	other threads:[~2026-03-23 12:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-21 21:04 [PATCH] xfrm: clear trailing padding in build_polexpire() Yasuaki Torimaru
2026-03-23 12:21 ` Steffen Klassert [this message]
2026-03-24  1:37 ` [PATCH v2] " Yasuaki Torimaru
2026-03-25 17:15   ` Simon Horman
2026-03-26  5:55     ` Yasuaki Torimaru
2026-03-26  5:57     ` Yasuaki Torimaru

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=acEwVDyy7dDQs6og@secunet.com \
    --to=steffen.klassert@secunet.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=yasuakitorimaru@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox