From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fhigh-b8-smtp.messagingengine.com (fhigh-b8-smtp.messagingengine.com [202.12.124.159]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 097493C279E; Mon, 23 Mar 2026 17:17:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.12.124.159 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774286230; cv=none; b=kyHr0v7vjPgv/qt3dQfHUr0Bmyalqe+tx4RarlBVmgH06R05JJ1XhqsZXpOgS48/wVzIAXYNugI5GD22Q15Unrts+aMAm+C3Zh/NL/sYOxXkxd3C7EtGcaK3DmT71Q6Mo/eqdEvnlJmnJaOnhX6STPegxVTsoXoyrIQG5RHiNEI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774286230; c=relaxed/simple; bh=MFrZYJpprDoL0spYqxHqSFMH4VKZZi/mvJOw56ruEi4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=sPid03bQrzba6xm12jwRCmY4NR8H+tTfRAP/pHicoVEK1pg67tVWXtIOwURNqZEQEk+w9I2D9vQyczEc/ojsdjOl3EsTEfMLx+8x6ZN+7GHd9fMmxL3jUzjpIKO3svxSremA+Z8ZsqwVYlADZR3v9hcQB5v5DwU+wzHDJkxc0/0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=queasysnail.net; spf=pass smtp.mailfrom=queasysnail.net; dkim=pass (2048-bit key) header.d=queasysnail.net header.i=@queasysnail.net header.b=ZK+Xnnov; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=MpSTdqOp; arc=none smtp.client-ip=202.12.124.159 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=queasysnail.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=queasysnail.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=queasysnail.net header.i=@queasysnail.net header.b="ZK+Xnnov"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="MpSTdqOp" Received: from phl-compute-01.internal (phl-compute-01.internal [10.202.2.41]) by mailfhigh.stl.internal (Postfix) with ESMTP id 8F36B7A022D; Mon, 23 Mar 2026 13:17:04 -0400 (EDT) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-01.internal (MEProxy); Mon, 23 Mar 2026 13:17:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=queasysnail.net; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm2; t=1774286224; x= 1774372624; bh=CEUxeZYmAiHA8QMMvhe5S1fWFkCW3pXVm0T9S/tFENM=; b=Z K+Xnnov7oq0u0ERuJExW4bWxmaVds3AXxZRSx+wL0da1I6lrSkd30r+/x+B/VhOK kDK88mKMEAGsIFxGH+mn3/gjAuQtPoDP2Zl6IxLilNtRu5y5e9xceGcrjAblXah+ YqrvRroDk0QTqtnMn1s/vCqMvA2SKEmK+kbDLruVG7She3eKF838iELq1QaD+QpT /mOicFyzaMjeLiIpgF7vuJyt1kUsLNFl6ly8/Q8piF1jvIB/nhtoSw2RDGosYVVX aNKMg0W+lhWd1WKBenjvzdyvTUl0i+eKfLpDXlNplDKp5HkdeMXVE5fi3AOqpVWW TteZia4X5KaBmc+iakeZw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1774286224; x=1774372624; bh=CEUxeZYmAiHA8QMMvhe5S1fWFkCW3pXVm0T 9S/tFENM=; b=MpSTdqOpjxL6BN83BdQ8nWWxejoQudn8DkuaSoWiIL973fHYr/I a83OQjhDXSAQ7IWrqI2OgXXrdtYw4RmlhjcCqEB0vf3ype0u9XHmzM4NmkrP9ac3 EV/Du8LTHvu9SeNZkw0d3tirtIehzIBuq3smZRTaRbqi1TDzhwp0/f24E6zVvufG jfecRYAb0F2YeuPfb4z21ExuxnPGKg4iuf09TpNkHy+RZmvBwp5/u5YYei+f12Bw UDWpgKGrrhbjGTc9nbw4EsifeNSuwyNWTqVFxr3Qt4UgkI7LTWDSfYa+Deq0BSFf +YDaPsYOm9W/M7s58bUGHohuUTMYiR3CEAw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgdefudelvdekucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhepfffhvfevuffkfhggtggujgesthdtredttddtjeenucfhrhhomhepufgrsghrihhn rgcuffhusghrohgtrgcuoehsugesqhhuvggrshihshhnrghilhdrnhgvtheqnecuggftrf grthhtvghrnhepuefhhfffgfffhfefueeiudegtdefhfekgeetheegheeifffguedvueff fefgudffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh epshgusehquhgvrghshihsnhgrihhlrdhnvghtpdhnsggprhgtphhtthhopedutddpmhho uggvpehsmhhtphhouhhtpdhrtghpthhtohepkhhusggrsehkvghrnhgvlhdrohhrghdprh gtphhtthhopegtrhgrthhiuhesnhhvihguihgrrdgtohhmpdhrtghpthhtoheprghnughr vgifodhnvghtuggvvheslhhunhhnrdgthhdprhgtphhtthhopegurghvvghmsegurghvvg hmlhhofhhtrdhnvghtpdhrtghpthhtoheplhhinhhugidqkhhsvghlfhhtvghsthesvhhg vghrrdhkvghrnhgvlhdrohhrghdprhgtphhtthhopeguthgrthhulhgvrgesnhhvihguih grrdgtohhmpdhrtghpthhtohepshhhuhgrhheskhgvrhhnvghlrdhorhhgpdhrtghpthht ohepphgrsggvnhhisehrvgguhhgrthdrtghomhdprhgtphhtthhopegvughumhgriigvth esghhoohhglhgvrdgtohhm X-ME-Proxy: Feedback-ID: i934648bf:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 23 Mar 2026 13:17:03 -0400 (EDT) Date: Mon, 23 Mar 2026 18:17:01 +0100 From: Sabrina Dubroca To: Jakub Kicinski Cc: Cosmin Ratiu , "andrew+netdev@lunn.ch" , "davem@davemloft.net" , "linux-kselftest@vger.kernel.org" , Dragos Tatulea , "shuah@kernel.org" , "pabeni@redhat.com" , "edumazet@google.com" , "netdev@vger.kernel.org" Subject: Re: [PATCH net v5 0/3] macsec: Add support for VLAN filtering in offload mode Message-ID: References: <20260323123633.756163-1-cratiu@nvidia.com> <5ae5d08d578fce1a01a548fad8552a14df8c5679.camel@nvidia.com> <20260323093243.17c14edb@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260323093243.17c14edb@kernel.org> 2026-03-23, 09:32:43 -0700, Jakub Kicinski wrote: > On Mon, 23 Mar 2026 16:02:59 +0100 Sabrina Dubroca wrote: > > 2026-03-23, 14:42:00 +0000, Cosmin Ratiu wrote: > > > On Mon, 2026-03-23 at 15:28 +0100, Sabrina Dubroca wrote: > > > > Why not? Being able to test without accessing real HW is still > > > > useful. > > > > > > > The tests now send macsec traffic over VLANs and nsim, it's just that > > > nsim doesn't deal with VLAN filters at all and there are no stubbed > > > vlan filters in debugfs, since real hw doesn't have that interface. > > > > Since netdevsim doesn't deal with VLAN filters at all, the "tests > > should be written so that they can run both against ``netdevsim`` and > > a real device" bit of the docs doesn't fully apply here? > > > > Anyway, I think the original tests had value, even if they're more > > limited in some ways than traffic tests. HW/driver behavior could be > > hiding problems in the stack with VLAN propagation, those simpler > > tests don't have that risk. > > To be clear running the HW test without NETIF= should provide > similar functionality to what the old tests could do. It's entirely > okay to add netdevsim-specific subtests/test cases or asserts. > > Is there anything specific that you'd like to be tested? In v2/v3, nsim was exposing a debugfs file that contained the list of VLAN filters on that interface, and the selftest was grepping through that file to check if the correct entry was added/removed after each operation. I see that as testing the actual propagation of filters, while the traffic tests check the visible behavior of stack+driver+HW, which may not be correlated to actual propagation. > Let's not make this about HW tests vs nsim-only tests. That was not my intention. But since nsim doesn't currently implement VLAN filters, it seems running the HW test on nsim doesn't test anything at all. -- Sabrina