public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH net] selftests: drv-net: add missing tc config options for netkit tests
@ 2026-03-20 18:08 Bobby Eshleman
  2026-03-21 10:36 ` Simon Horman
  0 siblings, 1 reply; 3+ messages in thread
From: Bobby Eshleman @ 2026-03-20 18:08 UTC (permalink / raw)
  To: Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Shuah Khan, Daniel Borkmann, David Wei
  Cc: netdev, linux-kselftest, linux-kernel, Bobby Eshleman

From: Bobby Eshleman <bobbyeshleman@meta.com>

The NetDrvContEnv env context uses tc clsact qdiscs and BPF tc filters
for traffic redirection, but the kernel config options are missing from
the selftests config.

Without them, the tc qdisc installation trips on:

  CMD: tc qdisc add dev enp1s0 clsact
    EXIT: 2
    STDERR: Error: Specified qdisc kind is unknown.

  net.lib.py.utils.CmdExitFailure: Command failed

Add CONFIG_NET_CLS_ACT and CONFIG_NET_SCH_INGRESS to enable these tc
options.

Fixes: 3f74d5bb807e ("selftests/net: Add env for container based tests")
Signed-off-by: Bobby Eshleman <bobbyeshleman@meta.com>
---
 tools/testing/selftests/drivers/net/hw/config | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/testing/selftests/drivers/net/hw/config b/tools/testing/selftests/drivers/net/hw/config
index 235c0a1cd21e..dd50cb8a7911 100644
--- a/tools/testing/selftests/drivers/net/hw/config
+++ b/tools/testing/selftests/drivers/net/hw/config
@@ -6,9 +6,11 @@ CONFIG_FUNCTION_ERROR_INJECTION=y
 CONFIG_IO_URING=y
 CONFIG_IPV6=y
 CONFIG_IPV6_GRE=y
+CONFIG_NET_CLS_ACT=y
 CONFIG_NET_CLS_BPF=y
 CONFIG_NET_IPGRE=y
 CONFIG_NET_IPGRE_DEMUX=y
 CONFIG_NETKIT=y
+CONFIG_NET_SCH_INGRESS=y
 CONFIG_UDMABUF=y
 CONFIG_VXLAN=y

---
base-commit: edab1ca5ec6fffecbf340e26956ce73e502901d5
change-id: 20260320-config-fixes-for-nk-tests-64d77b7547df

Best regards,
-- 
Bobby Eshleman <bobbyeshleman@meta.com>


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH net] selftests: drv-net: add missing tc config options for netkit tests
  2026-03-20 18:08 [PATCH net] selftests: drv-net: add missing tc config options for netkit tests Bobby Eshleman
@ 2026-03-21 10:36 ` Simon Horman
  2026-03-24  0:05   ` Bobby Eshleman
  0 siblings, 1 reply; 3+ messages in thread
From: Simon Horman @ 2026-03-21 10:36 UTC (permalink / raw)
  To: Bobby Eshleman
  Cc: Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Shuah Khan, Daniel Borkmann, David Wei, netdev,
	linux-kselftest, linux-kernel, Bobby Eshleman

On Fri, Mar 20, 2026 at 11:08:35AM -0700, Bobby Eshleman wrote:
> From: Bobby Eshleman <bobbyeshleman@meta.com>
> 
> The NetDrvContEnv env context uses tc clsact qdiscs and BPF tc filters
> for traffic redirection, but the kernel config options are missing from
> the selftests config.
> 
> Without them, the tc qdisc installation trips on:
> 
>   CMD: tc qdisc add dev enp1s0 clsact
>     EXIT: 2
>     STDERR: Error: Specified qdisc kind is unknown.
> 
>   net.lib.py.utils.CmdExitFailure: Command failed
> 
> Add CONFIG_NET_CLS_ACT and CONFIG_NET_SCH_INGRESS to enable these tc
> options.
> 
> Fixes: 3f74d5bb807e ("selftests/net: Add env for container based tests")
> Signed-off-by: Bobby Eshleman <bobbyeshleman@meta.com>

Hi Bobby,

Unfortunately this does not apply cleanly to net.
Which breaks CI.

Please rebase and repost.

-- 
pw-bot: cr

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net] selftests: drv-net: add missing tc config options for netkit tests
  2026-03-21 10:36 ` Simon Horman
@ 2026-03-24  0:05   ` Bobby Eshleman
  0 siblings, 0 replies; 3+ messages in thread
From: Bobby Eshleman @ 2026-03-24  0:05 UTC (permalink / raw)
  To: Simon Horman
  Cc: Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Shuah Khan, Daniel Borkmann, David Wei, netdev,
	linux-kselftest, linux-kernel, Bobby Eshleman

On Sat, Mar 21, 2026 at 10:36:07AM +0000, Simon Horman wrote:
> On Fri, Mar 20, 2026 at 11:08:35AM -0700, Bobby Eshleman wrote:
> > From: Bobby Eshleman <bobbyeshleman@meta.com>
> > 
> > The NetDrvContEnv env context uses tc clsact qdiscs and BPF tc filters
> > for traffic redirection, but the kernel config options are missing from
> > the selftests config.
> > 
> > Without them, the tc qdisc installation trips on:
> > 
> >   CMD: tc qdisc add dev enp1s0 clsact
> >     EXIT: 2
> >     STDERR: Error: Specified qdisc kind is unknown.
> > 
> >   net.lib.py.utils.CmdExitFailure: Command failed
> > 
> > Add CONFIG_NET_CLS_ACT and CONFIG_NET_SCH_INGRESS to enable these tc
> > options.
> > 
> > Fixes: 3f74d5bb807e ("selftests/net: Add env for container based tests")
> > Signed-off-by: Bobby Eshleman <bobbyeshleman@meta.com>
> 
> Hi Bobby,
> 
> Unfortunately this does not apply cleanly to net.
> Which breaks CI.
> 
> Please rebase and repost.
> 
> -- 
> pw-bot: cr

Oh, I see now that 3f74d5bb807e ("selftests/net: Add env for container
based tests") is only in net-next, not net yet.

I'll resend with the proper tag.

Best,
Bobby

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-03-24  0:05 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-20 18:08 [PATCH net] selftests: drv-net: add missing tc config options for netkit tests Bobby Eshleman
2026-03-21 10:36 ` Simon Horman
2026-03-24  0:05   ` Bobby Eshleman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox