From: Joe Damato <joe@dama.to>
To: Matteo Croce <technoboy85@gmail.com>
Cc: Mohsin Bashir <mohsin.bashr@gmail.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Jesper Dangaard Brouer <hawk@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
netdev@vger.kernel.org, bpf@vger.kernel.org,
intel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v3 1/2] e1000e: add basic XDP support
Date: Tue, 24 Mar 2026 09:41:51 -0700 [thread overview]
Message-ID: <acK+z8Udlg1qyDeu@devvm20253.cco0.facebook.com> (raw)
In-Reply-To: <CAFnufp0LRVxwh50cLrg=hUe6itshTqrNy53HkvBWk6MQ7uL0KA@mail.gmail.com>
On Sun, Mar 22, 2026 at 03:11:56AM +0100, Matteo Croce wrote:
> Il giorno ven 20 mar 2026 alle ore 22:23 Mohsin Bashir
> <mohsin.bashr@gmail.com> ha scritto:
[...]
> I addressed all the comments and I'll send a v4 soon, thanks!
I was paging through the code last night and I was wondering: have you
considered splitting this patch into multiple smaller patches?
It would probably make it easier for reviewers to read and comment on.
Just my 2 cents since you are sending a v4.
next prev parent reply other threads:[~2026-03-24 16:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-20 13:23 [PATCH net-next v3 0/2] e1000e: add XDP support Matteo Croce
2026-03-20 13:23 ` [PATCH net-next v3 1/2] e1000e: add basic " Matteo Croce
2026-03-20 21:23 ` Mohsin Bashir
2026-03-22 2:11 ` Matteo Croce
2026-03-24 16:41 ` Joe Damato [this message]
2026-03-24 16:48 ` Matteo Croce
2026-03-20 13:23 ` [PATCH net-next v3 2/2] e1000e: add XDP_REDIRECT support Matteo Croce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acK+z8Udlg1qyDeu@devvm20253.cco0.facebook.com \
--to=joe@dama.to \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mohsin.bashr@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=technoboy85@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox