From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 247783A1693 for ; Tue, 24 Mar 2026 16:41:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774370514; cv=none; b=SiluVzlW5ABeLjPXcYHGCkkakGgDAVdlvCNXoZVMvk5G+vpc3jEB6GyHEUk/EdV14gmWG/INP0SkwRq0fJd/gKaKTx2QtmzY36bZL1jEYQagrM2veEtSw9dS+ASqgEzbdftBVNODKffqY+tv902m/vS+eESPydwePHOWGLIYkI4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774370514; c=relaxed/simple; bh=7MatbDgQaWgyh+g+DD4yZjrx8Tdr7YMJC0zFSYrDllM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mvG8GfaGQ43Qkqp8kCwGJ1gNzEPmaB0WPY2ZOq5kSlbqXQUuDfxsqgcZyh+oLZpIhfpgJvlYcbl+yg/i6SR3x5cGnILU47dGQsN9AJ9l0Jz+azltztU9Nk064j+84gnr1d9QTif/gfQNbBZT0ijNkjG5KBQZN49Qu1tOoxiW/a4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to; spf=none smtp.mailfrom=dama.to; dkim=pass (2048-bit key) header.d=dama-to.20230601.gappssmtp.com header.i=@dama-to.20230601.gappssmtp.com header.b=vbxFv6Bp; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=dama.to Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=dama-to.20230601.gappssmtp.com header.i=@dama-to.20230601.gappssmtp.com header.b="vbxFv6Bp" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2b05761bec1so224095ad.1 for ; Tue, 24 Mar 2026 09:41:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dama-to.20230601.gappssmtp.com; s=20230601; t=1774370512; x=1774975312; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=7MatbDgQaWgyh+g+DD4yZjrx8Tdr7YMJC0zFSYrDllM=; b=vbxFv6BpcqIkm4AeKu4gyPUI1iEFsAyCEl24gZHOyAdza8EdaWF5k2vTgofZ8ULd7U SqbNmZmGm/cq7IpxfaILIWCpyFxg6OYMHvNFlwTfZSL3t/w4+m2fdTQmjybYB0lEPGJZ 025SQy1ldvBeNF3XEuLBqzWR6Q3Ix96oRIurRN5aHrY03Ujnz/f7Kq4hkgbI0SZr2nav FKAa+6zZAHE37XN+BBgNeXhsnwhEJNoY8eQD+wWd0stw1it+HNWScHefkkGc+BeXGcv9 JiLzcQlcits5/rHdm/3u1O9BGE9iDfJbJj8R+iX7beD+Q3czz/kzf7E+4UAN3IBbjezu 5s7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774370512; x=1774975312; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7MatbDgQaWgyh+g+DD4yZjrx8Tdr7YMJC0zFSYrDllM=; b=mjpS2j00Ly1fr+aW4vbLXHqR9r1yI1piFcm2bFQHz1wJFiD0MrbZAQTmu7NsBTJKau HbRoRcVDkHeCl23vMrmnYDP1Q8w1icGPAla5eg4JgN8CIZ9WEIWkJO7k8xPuvIGHQBwF tWZ/6bD2zxXPeqGuyItdodbrd4p37GJ81QtfP+ADqu+YpvoYtWLJdosCpXepVrWL0803 Wv2kFzuU1nobIBFFb9lN4eIbQGqeQl30vR7LP6mvRdhgimFDKLScvD684GIhbdYvB7Sl gHv1hDUG9xifumVxL2xsQ9I6hnePLvQFOhy6LZ3++oH3hi94zblgR5FgaaJB5ZHE7mH4 eliA== X-Forwarded-Encrypted: i=1; AJvYcCUw4amjY43A29bCR1Ok/2FiWmp0U8Ma+8e6zxEQknI21dyNxv3k/BjS9Lmb35FRkPmY/cO4J0g=@vger.kernel.org X-Gm-Message-State: AOJu0YxhWNJen8V2yMC7q+n1wAiFJQexjOTfPRMLORdgSNWj0A6Hfq7C CKb71r+XMfFaZkuZhnyau/wYTNZdWTPV+1p9QpvR7VocrEuupLdFkLdydE6nIkCQiQM= X-Gm-Gg: ATEYQzy2vXi6E0ka/M6ygprW3opx70EZlXvOINLRahTyWTX2VX0V1Nm+7vSH1cNCLsj sDedFxoYEUQ8QrdQxxdSXk1kMCgLAPAMMJ/pAkaQfSY4wrjYnUXPBjNRYy/7Rj96OmLSwH2Kiob iG5eLJqGLcnB68tsUQt0ETif4xaLWelCQrpuf6GQ/mg2P2u3IBPJcEUS6SGVpf/pFyg3E2Oibiw mCwTnFZyJOUmlUQJJKUWKrDkrPbvKN5WRFoTX6Es6dfueWtTPYmsxXPL/zvoiROVsMi5BQj5/xM l/yTNSKOpZo2POJr9paK5vwQZFe0Q+8JjnwAjqztPx2aZskpEy8fHHgilSxvFwVWqJdQaooZ6dE 6/3Pb1k3LMZdKbvJQDl+rYIsLdKnTBJwYX5kZwvC9QJ1swgHRYHgYUbBGMyvRDkPX/kJu5xkdDI Jh7AC2 X-Received: by 2002:a17:902:db0e:b0:2b0:5a4c:726f with SMTP id d9443c01a7336-2b0a4e0f962mr38951665ad.15.1774370512477; Tue, 24 Mar 2026 09:41:52 -0700 (PDT) Received: from localhost ([2a03:2880:2ff:50::]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b083516b96sm191790655ad.7.2026.03.24.09.41.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2026 09:41:52 -0700 (PDT) Date: Tue, 24 Mar 2026 09:41:51 -0700 From: Joe Damato To: Matteo Croce Cc: Mohsin Bashir , Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , netdev@vger.kernel.org, bpf@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v3 1/2] e1000e: add basic XDP support Message-ID: Mail-Followup-To: Joe Damato , Matteo Croce , Mohsin Bashir , Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , netdev@vger.kernel.org, bpf@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org References: <20260320132356.63194-1-teknoraver@meta.com> <20260320132356.63194-2-teknoraver@meta.com> <1d708196-7b89-431f-bb17-177564196894@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Sun, Mar 22, 2026 at 03:11:56AM +0100, Matteo Croce wrote: > Il giorno ven 20 mar 2026 alle ore 22:23 Mohsin Bashir > ha scritto: [...] > I addressed all the comments and I'll send a v4 soon, thanks! I was paging through the code last night and I was wondering: have you considered splitting this patch into multiple smaller patches? It would probably make it easier for reviewers to read and comment on. Just my 2 cents since you are sending a v4.