From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6DFF038F65F; Tue, 24 Mar 2026 16:00:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.32.30.218 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774368006; cv=none; b=ltu9Fxoblp6BtLET16Fr8pQoDbzUQo9F8+p1XGCBjkPvHQVxy78hHEwAqcR1aWaQhmp0oqBbGM/MImiui8Btc8fekUEXO+M4kMrAx1XGf+8Gvb8yRGKcJKXLktKidekMlBaQAfG6pxe493+1/EnsiGuOS4U3lNCLNfk9SAkxLMI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774368006; c=relaxed/simple; bh=w93yOgRwZrXUr8HP+PVDBIDCftif6wc3/aWhomcJ/6U=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pBCMN50oQG1J2YnEG86FR3XLdF3zNw98LTRdhyrys8DiSEk5FTYTCE5R/+VH2Yukpr6tmWuD4MqhbrcH2izOsE7KAYI8FzagDVZKNVfMBL6N2WElBNbr3VeeVwrhEAn+Ah3Ovc8YJaIRT5jHTfI5DsfbYWmODvtRTeFaLy039ZM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk; spf=none smtp.mailfrom=armlinux.org.uk; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b=lgFhXA8R; arc=none smtp.client-ip=78.32.30.218 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="lgFhXA8R" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=zf0/9XCuKjKNRx7wtM4tESz8aRDpD2HLpkH9lTB+IIA=; b=lgFhXA8REvNp111NhY4I0709M1 NK3B3KQHkcib7fhl1e7BukTgkeUJM5aQJKcxW5RnafIlp5nQgaxa2NfEQGzcu+zoyc0vI+vJx/4IW lA6ZIBfVFrYaE0pOulcKZJaKgJw1O82umOBC9QLWI7o4voEMSUA/8Ea0sj6WJ4OaLR7sGofJF+I/N 9Ockuh5cyEAHxptwBdx5Bb0GDXY778sXNtfyqlxKCp5izHivWUgTm62a+DoF7PrbOshI1SnkhkGc8 treb6nUxPH2r/oCuV1HGFr5vO36v8s1u9PMcGwIA77cbE2IhyrAI5abfOMnAAmoQS55Vmcohd7WFK SLMWJ+Ww==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:59014) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1w54Ab-000000002Hk-2C8t; Tue, 24 Mar 2026 15:59:53 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.98.2) (envelope-from ) id 1w54AY-000000005BX-2SMV; Tue, 24 Mar 2026 15:59:50 +0000 Date: Tue, 24 Mar 2026 15:59:50 +0000 From: "Russell King (Oracle)" To: Ovidiu Panait Cc: Paolo Abeni , Michal Piekos , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Maxime Coquelin , Alexandre Torgue , "netdev@vger.kernel.org" , "linux-stm32@st-md-mailman.stormreply.com" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2] net: stmmac: skip VLAN restore when VLAN hash ops are missing Message-ID: References: <20260321-vlan-restore-error-v2-1-45cf56a5223d@mmpsystems.pl> <5e5706bb-0f04-4bb1-94f4-45083a3c76fd@redhat.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Russell King (Oracle) On Tue, Mar 24, 2026 at 03:37:24PM +0000, Ovidiu Panait wrote: > Hi, > > My understanding is that the code in stmmac_vlan_update() that checks for > !priv->dma_cap.vlhash is dead code, this condition cannot be true inside > the ndo_vlan_rx_add_vid and ndo_vlan_rx_kill_vid callbacks because the > callbacks are only called when priv->dma_cap.vlhash is true. > > This seems to be a long-standing issue in the VLAN code. If you're certain that there's dead code here, please consider submitting patches to clean it up thereby making the code easier to understand. > I only have access to a board that uses the DWMAC4 IP, but I'll have > a look in the documentation I have to check how to improve VLAN > features handling. Definitely please do! Having more effort to clean up parts of stmmac would be very welcome (but please bear in mind that I have had quite a large patch set, but that's reducing now.) Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!