From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f171.google.com (mail-dy1-f171.google.com [74.125.82.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C6D0B3A5454 for ; Tue, 24 Mar 2026 18:29:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774376951; cv=none; b=H8cKmLHSYRoPzLBGS0vQy1HWyKA53NOfNOfxJaaKr4ezzg4u+u6E5GEzOYbXDXCAQiWX+7DBswF3L7y85vBy26qHQFWNd0yPCEuT2GzZ04lhtipXO2100BhjOcppfwKkGB1EqABQqWsU6b03N4zluEkpPNk8PqZFvZRxYsOgLQQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774376951; c=relaxed/simple; bh=sGV42ckhq/fpPos7s40zEY8GgVxzQ5KkyRYafuhMkVo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=s7jPBrpCfFoI8fLwl/e3t4F2NMCmJHfM6m/btCK6y+kcESy/FyTDPsuF8+RRMX9ESzPHJc8pw31Kr6M/vmys3YN0fXihmObAV5ZuitaEA1V+cinH2UpBaH1z6YtJekvXXhkyN8IrhQ2xZNxA+pG60EsUPoE+M0ElhtTaJXSOGsc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UlTbLApi; arc=none smtp.client-ip=74.125.82.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UlTbLApi" Received: by mail-dy1-f171.google.com with SMTP id 5a478bee46e88-2c0ea57fea7so7060743eec.0 for ; Tue, 24 Mar 2026 11:29:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774376945; x=1774981745; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:mail-followup-to:message-id:subject:cc:to :from:date:from:to:cc:subject:date:message-id:reply-to; bh=5VMp4SS5F3P0M1XmfAAhBrmRFWjAnWFpCGzWfd4HYYM=; b=UlTbLApi/yiqSES7xvrNTuMl8VBz70aaRv2J43Yz5hg2KooLZd+hECbG+sfl+qFuoW YaHHx4ihw6UNAYiKDhThOa0j4aKui1rIz5j/HQaegBkijjzNP2YY8mna6f/5H12BU13N ZdMZyEGlLWGmJfN/O+93dEqgpCv+ST3xQTchihtscA9E8KOgLNHz8VuvvAqfY0Iy3ff1 UNibaxjYlTv/PBab3bbrZ5Hx4YJvTk7Na7ZpNVG/T/4wRfraU4IfS+yN0FczyTqTRy84 3ZDnXwaDWe13HFgDfvgbqsaydL6NHoEElNYapnMFNbEaQnaNHB6QWlBbqcDtldkITC9U gEBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774376945; x=1774981745; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:mail-followup-to:message-id:subject:cc:to :from:date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5VMp4SS5F3P0M1XmfAAhBrmRFWjAnWFpCGzWfd4HYYM=; b=iqtZA6XEh30Vg+fbpRk/9yZI0IzhTO3zgDTX8pEhuIrHwpiDzEww3dsXVYTrt3tJ2L OxoqRKIXt/0OwU6Q6n/v8yLJXZ3C0GGRaXh9Y3NYl/ulvsxNKzvIMXeJcE+mUQ24Pe3N RBoloTErpFBZtvwM0doRHAc1lLWljF8d5CPFxmZca+w4oYcUEczYz9ZZzuDjzTwss2oo FOcaOTduIaJmwCCM4kAEotvl7WfbT3LZNRu7Ex5hPoUnIPTIvXEnOEMrIcjGTQexPDR1 SrPxGMLiINLM+nCALYCwO/PSSH49NprF4ejSMZkJ8xYKeec63WWKCGzS6vmCbiiAYb17 jkNA== X-Forwarded-Encrypted: i=1; AJvYcCXrISdBGNfBrZI2x3KbuXfx47JEDi5vFqfhTbwfFWemf6kZljj/9l9yBulcg6Ee/fBg7d9kb0s=@vger.kernel.org X-Gm-Message-State: AOJu0YwJsROxczl/cFN5qrm2NdujiI0TwIXp//svZK0bO+EX25ELWyan gscvGIDyf1InCOkpDohaAG90PeJym+9rluJwehnvcl+OXg5jTuQJ9bI= X-Gm-Gg: ATEYQzw8Ydr+AsrBA0oFwNm8FICI/z5uZYXCWlJQ+ftMeTGLRVFophTse52fGOpDKP9 hQnPNukatn00Jbn0pA+8lBnKPmMU0gBqrKxfFV984eQJAkWfxgw9Cl3lcXoa8YcAkSJw9sk6D+/ 4m1StvBOgTX8OchHN9Fvxhj7Wqm4sgHC6fHM1X7jbgh4ND+1eZoX0C4vrYWMmUN7s0EI9p/MGnT BSVHJUTcqvibQ1LE86eaT8hX2jsCqJPWmlQZD0/MnuaoV4sjYL9DHmF8ckj3aALwZce92VY4iB3 MMbr8KuZwOsi8HiHDT2gonWoQKfm9IrA7elISMtFi73GIfqL+H71ILQ2aseZjaxIPxAc6mxyovk 4xB31M+U5uQ7qn7qWONQEMky9ADk3Tt6WBqKfUNh3cIXSiR/umfJmGGzY4X2DsTweobsNxr03sf m+KRjAahIfup/0EZpGXeYDuVkyNRRe28VpQSLuF9xOJ9PEzNtNnwHaKlRNKtx2xSF/jXI8EKqkL W/tguC6ZEQf0bVEFger+rBT6BDP X-Received: by 2002:a05:7300:7b90:b0:2b0:48f7:837d with SMTP id 5a478bee46e88-2c15d2dfa68mr213205eec.11.1774376942754; Tue, 24 Mar 2026 11:29:02 -0700 (PDT) Received: from localhost (c-76-102-12-149.hsd1.ca.comcast.net. [76.102.12.149]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2c10b14c299sm15827125eec.6.2026.03.24.11.29.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2026 11:29:02 -0700 (PDT) Date: Tue, 24 Mar 2026 11:29:01 -0700 From: Stanislav Fomichev To: Michael Chan Cc: Stanislav Fomichev , netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, corbet@lwn.net, skhan@linuxfoundation.org, andrew+netdev@lunn.ch, pavan.chebbi@broadcom.com, anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com, saeedm@nvidia.com, tariqt@nvidia.com, mbloch@nvidia.com, alexanderduyck@fb.com, kernel-team@meta.com, johannes@sipsolutions.net, sd@queasysnail.net, jianbol@nvidia.com, dtatulea@nvidia.com, mohsin.bashr@gmail.com, jacob.e.keller@intel.com, willemb@google.com, skhawaja@google.com, bestswngs@gmail.com, aleksandr.loktionov@intel.com, kees@kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kselftest@vger.kernel.org, leon@kernel.org Subject: Re: [PATCH net-next v3 08/13] bnxt: use snapshot in bnxt_cfg_rx_mode Message-ID: Mail-Followup-To: Stanislav Fomichev , Michael Chan , Stanislav Fomichev , netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, corbet@lwn.net, skhan@linuxfoundation.org, andrew+netdev@lunn.ch, pavan.chebbi@broadcom.com, anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com, saeedm@nvidia.com, tariqt@nvidia.com, mbloch@nvidia.com, alexanderduyck@fb.com, kernel-team@meta.com, johannes@sipsolutions.net, sd@queasysnail.net, jianbol@nvidia.com, dtatulea@nvidia.com, mohsin.bashr@gmail.com, jacob.e.keller@intel.com, willemb@google.com, skhawaja@google.com, bestswngs@gmail.com, aleksandr.loktionov@intel.com, kees@kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kselftest@vger.kernel.org, leon@kernel.org References: <20260320012501.2033548-1-sdf@fomichev.me> <20260320012501.2033548-9-sdf@fomichev.me> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On 03/23, Michael Chan wrote: > On Thu, Mar 19, 2026 at 6:25 PM Stanislav Fomichev wrote: > > > > With the introduction of ndo_set_rx_mode_async (as discussed in [0]) > > we can call bnxt_cfg_rx_mode directly. Convert bnxt_cfg_rx_mode to > > use uc/mc snapshots and move its call in bnxt_sp_task to the > > section that resets BNXT_STATE_IN_SP_TASK. Switch to direct call in > > bnxt_set_rx_mode. > > > > 0: https://lore.kernel.org/netdev/CACKFLi=5vj8hPqEUKDd8RTw3au5G+zRgQEqjF+6NZnyoNm90KA@mail.gmail.com/ > > > > Cc: Michael Chan > > Cc: Pavan Chebbi > > Signed-off-by: Stanislav Fomichev > > --- > > drivers/net/ethernet/broadcom/bnxt/bnxt.c | 26 ++++++++++++++--------- > > 1 file changed, 16 insertions(+), 10 deletions(-) > > > > diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c > > index 225217b32e4b..12265bd7fda4 100644 > > --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c > > +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c > > @@ -11039,7 +11039,8 @@ static int bnxt_setup_nitroa0_vnic(struct bnxt *bp) > > return rc; > > } > > > > -static int bnxt_cfg_rx_mode(struct bnxt *); > > +static int bnxt_cfg_rx_mode(struct bnxt *, struct netdev_hw_addr_list *, > > + struct netdev_hw_addr_list *); > > static bool bnxt_mc_list_updated(struct bnxt *, u32 *, > > const struct netdev_hw_addr_list *); > > > > @@ -11135,7 +11136,7 @@ static int bnxt_init_chip(struct bnxt *bp, bool irq_re_init) > > vnic->rx_mask |= mask; > > } > > > > - rc = bnxt_cfg_rx_mode(bp); > > + rc = bnxt_cfg_rx_mode(bp, &bp->dev->uc, &bp->dev->mc); > > if (rc) > > goto err_out; > > > > @@ -13610,11 +13611,12 @@ static void bnxt_set_rx_mode(struct net_device *dev, > > if (mask != vnic->rx_mask || uc_update || mc_update) { > > vnic->rx_mask = mask; > > > > - bnxt_queue_sp_work(bp, BNXT_RX_MASK_SP_EVENT); > > + bnxt_cfg_rx_mode(bp, uc, mc); > > } > > } > > > > -static int bnxt_cfg_rx_mode(struct bnxt *bp) > > +static int bnxt_cfg_rx_mode(struct bnxt *bp, struct netdev_hw_addr_list *uc, > > + struct netdev_hw_addr_list *mc) > > { > > struct net_device *dev = bp->dev; > > struct bnxt_vnic_info *vnic = &bp->vnic_info[BNXT_VNIC_DEFAULT]; > > @@ -13623,7 +13625,7 @@ static int bnxt_cfg_rx_mode(struct bnxt *bp) > > bool uc_update; > > > > netif_addr_lock_bh(dev); > > - uc_update = bnxt_uc_list_updated(bp, &dev->uc); > > + uc_update = bnxt_uc_list_updated(bp, uc); > > Will the uc list snapshot change between bnxt_set_rx_mode() and > bnxt_cfg_rx_mode() with the direct call now? In the original deferred > update implementation, the uc list can change and that's why we check > in both functions. The snapshot is gonna be the same for bnxt_set_rx_mode->bnxt_cfg_rx_mode path. So you're saying that it's ok to remove the one in bnxt_cfg_rx_mode because it's called either from bnxt_set_rx_mode (with a new list) or, explicitly, via the BNXT_RX_MASK_SP_EVENT retry mechanism (where we know that we need to redo the updates anyway)? This makes me wonder whether I need to push the retrying mechanism to the core stack... Right now, if some of the allocations in wq handler fail, we just give up, maybe I should handle it better. And I can plug the signal from the driver (make ndo_set_rx_mode_async return int) in the same retry mechanism.