From: Breno Leitao <leitao@debian.org>
To: Izabela Bakollari <ibakolla@redhat.com>
Cc: Edward Cree <ecree.xilinx@gmail.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-net-drivers@amd.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] sfc: add transmit timestamping support
Date: Wed, 25 Mar 2026 02:35:12 -0700 [thread overview]
Message-ID: <acOrt0LqV__xh_93@gmail.com> (raw)
In-Reply-To: <20260324160823.151472-1-ibakolla@redhat.com>
On Tue, Mar 24, 2026 at 05:08:21PM +0100, Izabela Bakollari wrote:
> Enable software TX Timestamping. The out of tree driver
> also implements this.
"The out of tree driver also implements this" is not the most technical
justification.
>
> Signed-off-by: Izabela Bakollari <ibakolla@redhat.com>
> ---
> drivers/net/ethernet/sfc/ethtool.c | 2 ++
> drivers/net/ethernet/sfc/tx.c | 2 ++
> 2 files changed, 4 insertions(+)
>
> diff --git a/drivers/net/ethernet/sfc/ethtool.c b/drivers/net/ethernet/sfc/ethtool.c
> index 362388754a29..c0038b942913 100644
> --- a/drivers/net/ethernet/sfc/ethtool.c
> +++ b/drivers/net/ethernet/sfc/ethtool.c
> @@ -231,6 +231,8 @@ static int efx_ethtool_get_ts_info(struct net_device *net_dev,
> {
> struct efx_nic *efx = efx_netdev_priv(net_dev);
>
> + ts_info->so_timestamping = SOF_TIMESTAMPING_TX_SOFTWARE;
Don't you need to append SOF_TIMESTAMPING_TX_SOFTWARE instead of
assinging it?
ts_info->so_timestamping |= SOF_TIMESTAMPING_TX_SOFTWARE;
prev parent reply other threads:[~2026-03-25 9:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-24 16:08 [PATCH net-next] sfc: add transmit timestamping support Izabela Bakollari
2026-03-25 0:58 ` Edward Cree
2026-03-25 9:35 ` Breno Leitao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acOrt0LqV__xh_93@gmail.com \
--to=leitao@debian.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=ibakolla@redhat.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net-drivers@amd.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox