From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 95F5434B1B0; Wed, 25 Mar 2026 21:14:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.32.30.218 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774473300; cv=none; b=RIkaC9xNZmPFfzR4CK+vG6KWn9+YRRU8IKX3pV3eUNCES6VRam6ng/UB/2gtQYgmF4GsDwoLkRDCThm/lEPcEdhQ2HWUKxnHvrXwaD723Lu4SiSh+8qVsdGmloKkOwleBJtbWlAQOHVN6B4NaxyysIpnhaGoncO4eV5RF5C7vGQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774473300; c=relaxed/simple; bh=inSsd9F7dfooKB81GS0hABhVhpWOhoy17TwPWXiUcD0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Hs25Rzp3orzwReAoEpR1eFitWbCfTEP3HQGDuKtPHC8678xUkLWCS3IUbHOswDHGapEvc8nv6BRARVO48JbIYwr6T3g4xE2W6m0JcxraU0Y5/Wnyo0OhCZ9yis+Fhj6C8hj6lTeH2lCPsoCAMVslgLnmhELidd9h1Ms+gTLAPCE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk; spf=none smtp.mailfrom=armlinux.org.uk; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b=wrp8frWY; arc=none smtp.client-ip=78.32.30.218 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="wrp8frWY" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=9T4ILjzpSI8Km2SYP2+R54L0ASfcwMMayhnKu46qcs4=; b=wrp8frWYdflVifRHX74kmry/Q2 r/4/Pg35KjXCbZvWTgAj4EASo/gshPXzA5HWOrsZr9QyIMPzKmsOw0d8yr+g8Gl4HWfax7TOiXvKS cjGemaSaFRDRSqeArT+DX9tYxZ95k89H+XEeM8Nwyy3h0NLcnAyp21hkkC7SvjdFVGtFq8gjI/mqK QHWw0MzyFnDe38O26aNmCE/mxx6vg4TgBtU5/Yw3f5xiURVzP9s7HXJ9DDPV5ymuz9KL/HeZXpsI+ RreCpn5SAG+W/aNkLtWY1LUIFgfZROeJpLARzV/qAlzMt5R9arFb9osgBB34l9Xm1/+F6s0G5uRae c7lA2VKQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:40038) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1w5VYh-000000003wd-1uuC; Wed, 25 Mar 2026 21:14:35 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.98.2) (envelope-from ) id 1w5VYe-000000006NW-3R79; Wed, 25 Mar 2026 21:14:32 +0000 Date: Wed, 25 Mar 2026 21:14:32 +0000 From: "Russell King (Oracle)" To: Bartosz Golaszewski Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Alexandre Torgue , Vinod Koul , Giuseppe Cavallaro , Chen-Yu Tsai , Jernej Skrabec , Neil Armstrong , Kevin Hilman , Jerome Brunet , Shawn Guo , Fabio Estevam , Jan Petrous , s32@nxp.com, Mohd Ayaan Anwar , Romain Gantois , Geert Uytterhoeven , Magnus Damm , Maxime Ripard , Christophe Roullier , Bartosz Golaszewski , Radu Rendec , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Drew Fustini , linux-sunxi@lists.linux.dev, linux-amlogic@lists.infradead.org, linux-mips@vger.kernel.org, imx@lists.linux.dev, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, sophgo@lists.linux.dev, linux-riscv@lists.infradead.org, Bartosz Golaszewski Subject: Re: [PATCH net-next v10 2/6] net: stmmac: qcom-ethqos: use generic device properties Message-ID: References: <20260323-qcom-sa8255p-emac-v10-0-79302b238a16@oss.qualcomm.com> <20260323-qcom-sa8255p-emac-v10-2-79302b238a16@oss.qualcomm.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260323-qcom-sa8255p-emac-v10-2-79302b238a16@oss.qualcomm.com> Sender: Russell King (Oracle) The comments I just gave to v9 (which is incomplete as received) apply to v10 as well, although I have no idea what the differences are between v9 and v10 as I never received the cover message. I only seem to receive patches 2, 4, 5 and 6. On Mon, Mar 23, 2026 at 02:20:54PM +0100, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > In order to drop the dependency on CONFIG_OF, convert all device property > getters from OF-specific to generic device properties and stop pulling > in any linux/of.h symbols. > > Signed-off-by: Bartosz Golaszewski > Signed-off-by: Bartosz Golaszewski > --- > drivers/net/ethernet/stmicro/stmmac/Kconfig | 2 +- > drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 9 ++++----- > 2 files changed, 5 insertions(+), 6 deletions(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/Kconfig b/drivers/net/ethernet/stmicro/stmmac/Kconfig > index d3a6ab7383fc1e1b2e4b12c670b12a8ad1606e6c..4148805a82b106471a25f9496b60be5bb9ce5c00 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/Kconfig > +++ b/drivers/net/ethernet/stmicro/stmmac/Kconfig > @@ -135,7 +135,7 @@ config DWMAC_MESON > config DWMAC_QCOM_ETHQOS > tristate "Qualcomm ETHQOS support" > default ARCH_QCOM > - depends on OF && (ARCH_QCOM || COMPILE_TEST) > + depends on ARCH_QCOM || COMPILE_TEST > help > Support for the Qualcomm ETHQOS core. > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c > index 3ccf20fdf52a8ec4649b43ade8ee7b85d613e1c5..66fd2ed2c2c8428694c07d89220d0e1608546791 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c > @@ -1,8 +1,8 @@ > // SPDX-License-Identifier: GPL-2.0 > // Copyright (c) 2018-19, Linaro Limited > > +#include > #include > -#include > #include > #include > #include > @@ -728,7 +728,6 @@ static void ethqos_ptp_clk_freq_config(struct stmmac_priv *priv) > > static int qcom_ethqos_probe(struct platform_device *pdev) > { > - struct device_node *np = pdev->dev.of_node; > const struct ethqos_emac_driver_data *data; > struct plat_stmmacenet_data *plat_dat; > struct stmmac_resources stmmac_res; > @@ -778,7 +777,7 @@ static int qcom_ethqos_probe(struct platform_device *pdev) > return dev_err_probe(dev, PTR_ERR(ethqos->rgmii_base), > "Failed to map rgmii resource\n"); > > - data = of_device_get_match_data(dev); > + data = device_get_match_data(dev); > ethqos->rgmii_por = data->rgmii_por; > ethqos->num_rgmii_por = data->num_rgmii_por; > ethqos->rgmii_config_loopback_en = data->rgmii_config_loopback_en; > @@ -818,9 +817,9 @@ static int qcom_ethqos_probe(struct platform_device *pdev) > if (ethqos->has_emac_ge_3) > plat_dat->dwmac4_addrs = &data->dwmac4_addrs; > plat_dat->pmt = true; > - if (of_property_read_bool(np, "snps,tso")) > + if (device_property_present(dev, "snps,tso")) > plat_dat->flags |= STMMAC_FLAG_TSO_EN; > - if (of_device_is_compatible(np, "qcom,qcs404-ethqos")) > + if (device_is_compatible(dev, "qcom,qcs404-ethqos")) > plat_dat->flags |= STMMAC_FLAG_RX_CLK_RUNS_IN_LPI; > if (data->dma_addr_width) > plat_dat->host_dma_width = data->dma_addr_width; > > -- > 2.47.3 > > > -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!