From: Breno Leitao <leitao@debian.org>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Edward Cree <ecree.xilinx@gmail.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
Nathan Chancellor <nathan@kernel.org>,
Jeff Garzik <jgarzik@redhat.com>,
Ben Hutchings <bhutchings@solarflare.com>,
Arnd Bergmann <arnd@arndb.de>,
Nick Desaulniers <nick.desaulniers+lkml@gmail.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
Brett Creeley <brett.creeley@amd.com>,
Kees Cook <kees@kernel.org>,
netdev@vger.kernel.org, linux-net-drivers@amd.com,
linux-kernel@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH] [v2] net: sfc: avoid format string warning
Date: Thu, 26 Mar 2026 02:17:59 -0700 [thread overview]
Message-ID: <acT4fg86n7kpdm8e@gmail.com> (raw)
In-Reply-To: <20260325134557.3406655-1-arnd@kernel.org>
On Wed, Mar 25, 2026 at 02:45:44PM +0100, Arnd Bergmann wrote:
> /* Event queues */
> efx_for_each_channel(channel, efx) {
> + char unit_str[ETH_GSTRING_LEN];
> +
> + snprintf(unit_str, sizeof(unit_str), "txq%d", channel->channel);
The original EFX_CHANNEL_NAME macro expanded to "chan%d", didn't it?.
Shouldn't replace txq by chan in the line above?
snprintf(unit_str, sizeof(unit_str), "chan%d", channel->channel);
> @@ -258,23 +253,23 @@ static int efx_fill_loopback_test(struct efx_nic *efx,
> struct efx_tx_queue *tx_queue;
>
> efx_for_each_channel_tx_queue(tx_queue, channel) {
> + char unit_str[ETH_GSTRING_LEN];
> +
> + snprintf(unit_str, sizeof(unit_str), "txq%d",tx_queue->label);
You probably want a space after the comma here:
snprintf(unit_str, sizeof(unit_str), "txq%d", tx_queue->label);
prev parent reply other threads:[~2026-03-26 9:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-25 13:45 [PATCH] [v2] net: sfc: avoid format string warning Arnd Bergmann
2026-03-26 2:00 ` Edward Cree
2026-03-26 9:17 ` Breno Leitao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acT4fg86n7kpdm8e@gmail.com \
--to=leitao@debian.org \
--cc=andrew+netdev@lunn.ch \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=bhutchings@solarflare.com \
--cc=brett.creeley@amd.com \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=jgarzik@redhat.com \
--cc=justinstitt@google.com \
--cc=kees@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net-drivers@amd.com \
--cc=llvm@lists.linux.dev \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nick.desaulniers+lkml@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox