From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from stravinsky.debian.org (stravinsky.debian.org [82.195.75.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E70DA314B84; Thu, 26 Mar 2026 09:18:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=82.195.75.108 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774516712; cv=none; b=ecY7nu+rqdUW/gwwHSBGAyEkgSJaTBKX6WDDNk+SFIqnnKn8Z/mS+YMdeeZguy2yu1bf3gWJE2+m0xjAYiAZ11+YxhRfpT09u1qXZpyK089Yl7ml6kKHZ4GHVS1T3Ahn32ELef4gCcdbD0CHwg6ncnxoafgV0g3PBWJnVMhII2Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774516712; c=relaxed/simple; bh=vvbrnA0+898pMRQlJ9PQpXwM80nzyirRDqrs56qTSnU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=IPNw4tt+aqfZZClA3xGOvcretFChp0RsJk+XNfIW90RUEsdAaF4+MK4amRQNrlAHXW7iBghyELuFjltFPMJWeyQj8J0n9hDgfLkIL8A0VjpRLRD+Hf7Oli3XeLkIXG5EvJ1Mwx/8OIkCjp3TybMBgcOlHRbwYKw7MDAdehXpXho= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org; spf=none smtp.mailfrom=debian.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b=U53i+EXs; arc=none smtp.client-ip=82.195.75.108 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=debian.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b="U53i+EXs" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debian.org; s=smtpauto.stravinsky; h=X-Debian-User:In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=rQFc9TaMPa+MJvbas5O7gxSnkgSoNa81YzdAVy0iL4c=; b=U53i+EXs40w+2RO57CuIxtBEvV a/eRL+yyV0sDg9RwSPdxSOhWmisdR/bATD35Kt8IINksMi/rAsAM3OqpKqSh2BdSrGh9/yXAW1lNj ECWxn6jsWNeQGKPPF1nh5sOR0iEr2bIdDOWqrX16OblKuRWeHdDwAMouYC9Zgqt8tJKkxwGX1OCpd nxedaaxfHgGH3eWjsXG8/qKWcJtMdbRtRm3X/5nOhGZNSne9OsVFQVU4ostMuxSbD3+saAXpvy47e 4T2Q7g+QjQn5EhrZfJwtTbMXly46uzJAz6PKtTgZsa9NbOUPniFdl0+uTFDgmlho2Rb/jysly+buX lyU3lV/A==; Received: from authenticated user by stravinsky.debian.org with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94.2) (envelope-from ) id 1w5gqr-009kHn-V9; Thu, 26 Mar 2026 09:18:06 +0000 Date: Thu, 26 Mar 2026 02:17:59 -0700 From: Breno Leitao To: Arnd Bergmann Cc: Edward Cree , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Nathan Chancellor , Jeff Garzik , Ben Hutchings , Arnd Bergmann , Nick Desaulniers , Bill Wendling , Justin Stitt , Brett Creeley , Kees Cook , netdev@vger.kernel.org, linux-net-drivers@amd.com, linux-kernel@vger.kernel.org, llvm@lists.linux.dev Subject: Re: [PATCH] [v2] net: sfc: avoid format string warning Message-ID: References: <20260325134557.3406655-1-arnd@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260325134557.3406655-1-arnd@kernel.org> X-Debian-User: leitao On Wed, Mar 25, 2026 at 02:45:44PM +0100, Arnd Bergmann wrote: > /* Event queues */ > efx_for_each_channel(channel, efx) { > + char unit_str[ETH_GSTRING_LEN]; > + > + snprintf(unit_str, sizeof(unit_str), "txq%d", channel->channel); The original EFX_CHANNEL_NAME macro expanded to "chan%d", didn't it?. Shouldn't replace txq by chan in the line above? snprintf(unit_str, sizeof(unit_str), "chan%d", channel->channel); > @@ -258,23 +253,23 @@ static int efx_fill_loopback_test(struct efx_nic *efx, > struct efx_tx_queue *tx_queue; > > efx_for_each_channel_tx_queue(tx_queue, channel) { > + char unit_str[ETH_GSTRING_LEN]; > + > + snprintf(unit_str, sizeof(unit_str), "txq%d",tx_queue->label); You probably want a space after the comma here: snprintf(unit_str, sizeof(unit_str), "txq%d", tx_queue->label);