From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66ADA224B05; Thu, 26 Mar 2026 18:12:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.32.30.218 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774548735; cv=none; b=Lg9FQGLhrKKZBGru4dbte68JNzAw/QJlsOy7wu78x1hG+Snk8TxRthpvPFUgVX/m8pkeVdKEG6oQkMQuExAMvLTGRdNiq8Nuby85F0YSAYhlyifn0j/WiVAn7A0UqODCQTFcjvYqjnA3I/xfUhF52UbMQU8IPUDIx5dSahh3wTc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774548735; c=relaxed/simple; bh=sxAmqw1lLIBgSH7InHiLoA7p1BK5TNUSniY9DyPN35E=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mJcis83NT9vjMXRuF6h+W8QoyfssXVsse4UCbX5xi3JgoZsu0W/3utVehHaMOOBrs7tFw8Yr3C/Sq8yLuWRFwysYRONfffFf/xH5xs8ORNT2zglvwfRxbGpvv0bWGva1JoyIjj0M988+fI3/Q4uKi+dwlnGHiIfv05ZnGkXZ7zo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk; spf=none smtp.mailfrom=armlinux.org.uk; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b=mAWrfpvO; arc=none smtp.client-ip=78.32.30.218 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="mAWrfpvO" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Ji45NUWbwmYmtJWis87trG6dXs16U0uRXqDBTnsy5d4=; b=mAWrfpvOlFfajgP5bFr/ohHOiA 1QPBL3YZnDhT3I0lLAI2A8ejzh1khwXIIIlePLo6ivYWUVBAGAQy6A2GU1zBq5zM1kgnU1ILI/7aT 6+bckNXZKZfbJrK+n5XOCoOxHpWJwkcBYCUd8Py71xIDe2hKglU2ktIDZA62zvZq4GzIFu+Z42HZf 4tD/jRwlnJmeiVEMZbzZDyxj2F3YdFmBbLa9BCXi3otIaZb1H+xuGGgTjvazJhCCtIbuLplgyZwGm zOMVqdlpSrwJxH6wuXq+dbMDonDyugML57jeQwYfois/7z+HMwrPJM4W3foKfQI8eEMy3WOE3WilH SXgUClFw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:53576) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1w5pBg-0000000059C-218X; Thu, 26 Mar 2026 18:12:08 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.98.2) (envelope-from ) id 1w5pBe-000000007Fq-2PgA; Thu, 26 Mar 2026 18:12:06 +0000 Date: Thu, 26 Mar 2026 18:12:06 +0000 From: "Russell King (Oracle)" To: Simon Horman Cc: Andrew Lunn , Alexandre Torgue , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, Mohd Ayaan Anwar , netdev@vger.kernel.org, Paolo Abeni Subject: Re: [PATCH net-next 03/15] net: stmmac: qcom-ethqos: eliminate configure_func Message-ID: References: <20260326180453.GU111839@horms.kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260326180453.GU111839@horms.kernel.org> Sender: Russell King (Oracle) On Thu, Mar 26, 2026 at 06:04:53PM +0000, Simon Horman wrote: > On Tue, Mar 24, 2026 at 01:11:44PM +0000, Russell King (Oracle) wrote: > > Since ethqos_fix_mac_speed() is called via a function pointer, and only > > indirects via the configure_func function pointer, eliminate this > > unnecessary indirection. > > > > Signed-off-by: Russell King (Oracle) > > ... > > > @@ -623,14 +627,6 @@ static void ethqos_configure_sgmii(struct qcom_ethqos *ethqos, > > ethqos_pcs_set_inband(ethqos, interface == PHY_INTERFACE_MODE_SGMII); > > } > > > > -static void ethqos_fix_mac_speed(void *priv, phy_interface_t interface, > > - int speed, unsigned int mode) > > -{ > > - struct qcom_ethqos *ethqos = priv; > > - > > - ethqos->configure_func(ethqos, interface, speed); > > -} > > - > > static int qcom_ethqos_serdes_powerup(struct net_device *ndev, void *priv) > > { > > struct qcom_ethqos *ethqos = priv; > > Hi Russell, > > FYI, AI generated review reports that the comment in ethqos_clks_config() > that references ethqos_fix_mac_speed() should also be updated. Also already noted (yesterday). I do keep an eye on patchwork for my own patches - I have a firefox tab permanently open for my patches in patchwork: https://patchwork.kernel.org/project/netdevbpf/list/?submitter=165511 Thanks anyway. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!