From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A83DB3FCB18 for ; Thu, 26 Mar 2026 14:30:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774535428; cv=none; b=JMdDvqzA4nMIOuY0rrbfg8gEDcwC2w+Mtspd7AGfJ+hbHsZhiYiqedz5iTTjt1ch9u2jxf+ICEvzv6oaZznY4Qnz7DWEPLKPaGxEz5xdsdLILDH91jj/bXOVFigtnOF0AWizbi0Pbc/Ny9iMPejzDwwcRY3V8mxJSkaltWIvET4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774535428; c=relaxed/simple; bh=kJ5DEvmEC6COhuG5ZifY0ak91bfECvqTWHiIvmlWccs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BeWiNGR2QwzKT4cN7xk+q/ZxP0K37Ex38g6tDy2/tcOmPLHJ3RuHcZYcSxHxEgGBHRyADTg2rB4wvPLxIYxrtKczfgSX3MynhgyQLd8fuZaAJvmaoDTmSWWDiwfc2Y9RUvH9wYWeqoyA8I0FPCZsxBWze5G56OdKjd/bT7NDFJA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=N3SNlSbC; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="N3SNlSbC" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774535426; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6VW0YNLGPuLqDA6b95OWVGdGDmHTWKVFeGTWyx240+M=; b=N3SNlSbCBINq5xf/sHmHgg1DHZdZdxabILqZ/ndrVhCSiyqZiGc6pAgnHgJUsDDUbZBlUi T4K+wX7VPjTuw6gM9Xr2gpVwdBADyKz8UvXQN+u5wgwISjafRiYW7U+VXPBg4zbXZwk5y/ uqb19XYCxw23p9QvfeLuGkNPEOwHX9k= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-43-9e5ZRQ2pMpaT1HwQL31v9Q-1; Thu, 26 Mar 2026 10:30:23 -0400 X-MC-Unique: 9e5ZRQ2pMpaT1HwQL31v9Q-1 X-Mimecast-MFC-AGG-ID: 9e5ZRQ2pMpaT1HwQL31v9Q_1774535421 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 71E491955BCE; Thu, 26 Mar 2026 14:30:21 +0000 (UTC) Received: from thinkpad (dhcp-64-111.muc.redhat.com [10.32.64.111]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 21C91180036E; Thu, 26 Mar 2026 14:30:18 +0000 (UTC) Date: Thu, 26 Mar 2026 15:30:16 +0100 From: Felix Maurer To: luka.gejak@linux.dev Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, horms@kernel.org, liuhangbin@gmail.com, bigeasy@linutronix.de, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v1 4/4] net: hsr: reject unresolved interlink ifindex Message-ID: References: <20260324143503.187642-1-luka.gejak@linux.dev> <20260324143503.187642-5-luka.gejak@linux.dev> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260324143503.187642-5-luka.gejak@linux.dev> X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 On Tue, Mar 24, 2026 at 03:35:03PM +0100, luka.gejak@linux.dev wrote: > From: Luka Gejak > > In hsr_newlink(), a provided but invalid IFLA_HSR_INTERLINK attribute > was silently ignored if __dev_get_by_index() returned NULL. This leads > to incorrect RedBox topology creation without notifying the user. Not really incorrect, it's just not a RedBox at all. > Fix this by returning -EINVAL and an extack message when the > interlink attribute is present but cannot be resolved. > > Signed-off-by: Luka Gejak Reviewed-by: Felix Maurer > --- > net/hsr/hsr_netlink.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/net/hsr/hsr_netlink.c b/net/hsr/hsr_netlink.c > index db0b0af7a692..f0ca23da3ab9 100644 > --- a/net/hsr/hsr_netlink.c > +++ b/net/hsr/hsr_netlink.c > @@ -76,9 +76,14 @@ static int hsr_newlink(struct net_device *dev, > return -EINVAL; > } > > - if (data[IFLA_HSR_INTERLINK]) > + if (data[IFLA_HSR_INTERLINK]) { > interlink = __dev_get_by_index(link_net, > nla_get_u32(data[IFLA_HSR_INTERLINK])); > + if (!interlink) { > + NL_SET_ERR_MSG_MOD(extack, "Interlink does not exist"); > + return -EINVAL; > + } > + } > > if (interlink && interlink == link[0]) { > NL_SET_ERR_MSG_MOD(extack, "Interlink and Slave1 are the same"); > -- > 2.53.0 >