From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pidgin.makrotopia.org (pidgin.makrotopia.org [185.142.180.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D1467351C10; Thu, 26 Mar 2026 23:11:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.142.180.65 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774566694; cv=none; b=QsdXGo45FC7wgqnBRuFxXR2xmHiL2hFL659ct9p5UleSfdYdZIN2xPEEXjFR7H1tZVBeRMRUyjAdJzPO0GQQ5unm1J8MlOjIH0rQ6QB9S/gSiOwoIIfyAuzSO+lTYq8/P99X7OSVi3Hf4L+d0F16dvzvNDNc+0iNKSG1L+ch8V4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774566694; c=relaxed/simple; bh=aiNzbg55Me8/6ra6ON8VHicbaEbyNwmfMoAes3c0TC0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=CnbAdnif1oiWScMbtgcEgvCF1rWqetdH60NA6y1FSedCY7ydNQxwP0P+OcDeEBoZaZpUpX1k9z56ZCSGNmB+fKsCmeQHUKMyFkAFGlZNSgWMR1vLGJfnipC6+D1CxTuzaiTSEWZXR1fhEJH5CiMO+vAzqdkvRizbeKhkSuIlRZM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=makrotopia.org; spf=pass smtp.mailfrom=makrotopia.org; arc=none smtp.client-ip=185.142.180.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=makrotopia.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=makrotopia.org Received: from local by pidgin.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.99) (envelope-from ) id 1w5trK-000000006dg-0Zct; Thu, 26 Mar 2026 23:11:26 +0000 Date: Thu, 26 Mar 2026 23:11:23 +0000 From: Daniel Golle To: Joris Vaisvila Cc: netdev@vger.kernel.org, horms@kernel.org, pabeni@redhat.com, kuba@kernel.org, edumazet@google.com, davem@davemloft.net, olteanv@gmail.com, Andrew Lunn , devicetree@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley Subject: Re: [PATCH net-next 1/4] dt-bindings: net: dsa: add MT7628 ESW Message-ID: References: <20260326204413.3317584-1-joey@tinyisr.com> <20260326204413.3317584-2-joey@tinyisr.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260326204413.3317584-2-joey@tinyisr.com> On Thu, Mar 26, 2026 at 10:44:10PM +0200, Joris Vaisvila wrote: > Add bindings for MT7628 SoC's Embedded Switch. > [...] > diff --git a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7628-esw.yaml b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7628-esw.yaml > new file mode 100644 > index 000000000000..d3c9df30ed5a > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7628-esw.yaml > @@ -0,0 +1,101 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/dsa/mediatek,mt7628-esw.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Mediatek MT7628 Embedded Ethernet Switch > + > +maintainers: > + - Joris Vaisvila > + > +description: > + The MT7628 SoC's built-in Ethernet Switch is a five port switch with > + integrated 10/100 PHYs. The switch registers are directly mapped in the SoC's > + memory. The switch has an internally connected 1G CPU port and 5 user ports > + connected to the built-in Fast Ethernet PHYs. > + > [...] > + port@6 { > + reg = <6>; > + ethernet = <ðernet>; > + phy-mode = "rgmii"; Is this actually RGMII internally? Or some unknown internal way to wire the switch CPU port to the CPU MAC? In this case, "internal" should be used here as well.