From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sendmail.purelymail.com (sendmail.purelymail.com [34.202.193.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A9AC723EA8A for ; Fri, 27 Mar 2026 06:01:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=34.202.193.197 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774591283; cv=none; b=tDtPnuc3HlMyrnaSIsklfBOeME0xRoL0ChhjkHwwpoJSnoAZiM+DVsY9inmaNaZIFTjCpHACxfyYHDRv7s+hxqV6qFFZvXA201U/hrblC7nvWMWDp6jvFy+FBUhtv6RZV7D25uFXJAGWYTZsI5NonmlfiHC6BsZiEqkWK6riyhU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774591283; c=relaxed/simple; bh=Z5Jo+6Hp+Ie1MkZalrd3zjOs7QYWJ+eZe1Mk5hz3lA8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WKS2rapxqVxEtcikaKhXOXjHXuSi7jIL3KkZEp7fTsGS2A50X5ysfiLGP7BHGyA8p0ez/aNji/YiyJ07z9wjmHG5ZsXc/K2cM+a5eFAJ70lLzfqu9Cuk1UknwKXku/Dq1U7V1jzZ9rifI/FY2WbcZbeo9B9S2QBQjPmAyQULRuc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=tinyisr.com; spf=pass smtp.mailfrom=tinyisr.com; dkim=pass (2048-bit key) header.d=tinyisr.com header.i=@tinyisr.com header.b=hEfqOV4L; dkim=pass (2048-bit key) header.d=purelymail.com header.i=@purelymail.com header.b=dsDUD+Vj; arc=none smtp.client-ip=34.202.193.197 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=tinyisr.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tinyisr.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tinyisr.com header.i=@tinyisr.com header.b="hEfqOV4L"; dkim=pass (2048-bit key) header.d=purelymail.com header.i=@purelymail.com header.b="dsDUD+Vj" DKIM-Signature: a=rsa-sha256; b=hEfqOV4Ll6XzCLtGoYp4eXwZ7za1C92JJVNDWVO6I0xKundBGUekw3Dj7SgVSJXFG7i+tPUmOpikcPFnHNNcSXJco9Lm03P2XId3jGHeTLB00JA85twpjAYqJWP7vI12IP6OTjD9h2Ly9x+NNmpvXIHmnS+b46thHYWbSxzbVJUwRzjDSpwkIK/Ckza70w5UFkGeMYe0Q9cciAp8ruVKgmL280Stzz+komSJ6ayezS9qaW5OTtyif+9tTgw8JrVtlZrCw6PWQfBSwaDnHhS9TpfjE40dfrWwk/SrDsoUuKQ0t7P8Js1P08ghV4R/R43lyyJ0Oecj6s8piP3xjXDGBA==; s=purelymail1; d=tinyisr.com; v=1; bh=Z5Jo+6Hp+Ie1MkZalrd3zjOs7QYWJ+eZe1Mk5hz3lA8=; h=Received:Date:From:To:Subject; DKIM-Signature: a=rsa-sha256; b=dsDUD+VjXfLjfmCDVTLOErO0aaDucx/rDM69bMiW1B5mYfDKcJ6tD09BzP75Oykqf3WITYSJTe3vDULkup9QJs0Z9WBq8z7MgBHqTTHa4Qv6JcuxcROjH5Yth74LPdgWjHQN1cjBOn+e/BqnRhrsSSrUDkF3TiyRhfg2+QUuPVLPt9h/GBNSurxYIS8u6vfbIRYYOuGIpcTp03va3GGlISMYaJPfB0c+TXPb9ffzaNQ10hPu6e0+xK1RCfufY63mnHXAL3RPWMWPAmC1d9jDBAE2um/EqGtXr6p3BgTzpwydkQrwGcd4Rt69hZetW2aSysmDNhJMC9kEe0LvDVRoJA==; s=purelymail1; d=purelymail.com; v=1; bh=Z5Jo+6Hp+Ie1MkZalrd3zjOs7QYWJ+eZe1Mk5hz3lA8=; h=Feedback-ID:Received:Date:From:To:Subject; Feedback-ID: 99681:12517:null:purelymail X-Pm-Original-To: netdev@vger.kernel.org Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id 703749943; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Fri, 27 Mar 2026 06:01:03 +0000 (UTC) Date: Fri, 27 Mar 2026 08:00:51 +0200 From: Joris Vaisvila To: Daniel Golle Cc: netdev@vger.kernel.org, horms@kernel.org, pabeni@redhat.com, kuba@kernel.org, edumazet@google.com, davem@davemloft.net, olteanv@gmail.com, Andrew Lunn , devicetree@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley Subject: Re: [PATCH net-next 1/4] dt-bindings: net: dsa: add MT7628 ESW Message-ID: References: <20260326204413.3317584-1-joey@tinyisr.com> <20260326204413.3317584-2-joey@tinyisr.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Hi Daniel, thanks for the feedback On Thu, Mar 26, 2026 at 11:11:23PM +0000, Daniel Golle wrote: > > [...] > > + port@6 { > > + reg = <6>; > > + ethernet = <ðernet>; > > + phy-mode = "rgmii"; > > Is this actually RGMII internally? Or some unknown internal way to > wire the switch CPU port to the CPU MAC? In this case, "internal" > should be used here as well. I don't know how to find this out for sure. In the MT7628 doc (https://vonger.cn/upload/MT7628_Full.pdf) port 6 is refered to as RGMII port 1 (RGMII port 0 being the non-existent port 5), but there are no clock registers to be seen. In RT3050 docs there are RGMII clock registers for port 5, but nothing for port 6, so maybe the CPU port is really using some mystery internal connection and only uses "RGMII" as a way to say it's a Gigabit port? On the hardware I'm testing on, it works fine with the port set to "internal" or "rgmii". Would it make more sense to set "internal" then? Thanks, Joris