Netdev List
 help / color / mirror / Atom feed
From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: Stefan Metzmacher <metze@samba.org>, <intel-wired-lan@lists.osuosl.org>
Cc: Przemek Kitszel <przemyslaw.kitszel@intel.com>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ice: fix double dereference in TP_printk problems in ice_{rx,tx}_dim_template
Date: Thu, 10 Sep 2026 14:11:34 -0700	[thread overview]
Message-ID: <aca8d358-7edc-4939-9e2e-10616fe4d1f6@intel.com> (raw)
In-Reply-To: <20260907164810.1048081-1-metze@samba.org>



On 9/7/2026 9:48 AM, Stefan Metzmacher wrote:
> ice_tx_dim_work and ice_rx_dim_work generate the
> following: "has double dereference in TP_printk" errors:
> 
>   REC->q_vector->tx.tx_ring->q_index
>   REC->dim->state
>   REC->dim->profile_ix
>   REC->dim->tune_state
>   REC->dim->steps_right
>   REC->dim->steps_left
>   REC->dim->tired

Thanks for the patch Stefan but Jakub has already submitted a patch [1] 
that's en route to fix this.

Thanks,
Tony

[1] 
https://lore.kernel.org/intel-wired-lan/aqFp78nsYmT8gRDO@gmail.com/T/#ma04a6a8301063209e8eae383e31293953f4eba46 

> And the first one hits a WARN_ONCE()...
> 
> Fixes: 3089cf6d3caa ("ice: add tracepoints")
> Cc: Tony Nguyen <anthony.l.nguyen@intel.com>
> Cc: Przemek Kitszel <przemyslaw.kitszel@intel.com>
> Cc: Andrew Lunn <andrew+netdev@lunn.ch>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Eric Dumazet <edumazet@google.com>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Paolo Abeni <pabeni@redhat.com>
> Cc: intel-wired-lan@lists.osuosl.org
> Cc: netdev@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Stefan Metzmacher <metze@samba.org>



      reply	other threads:[~2026-09-10 21:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-07 16:48 [PATCH] ice: fix double dereference in TP_printk problems in ice_{rx,tx}_dim_template Stefan Metzmacher
2026-09-10 21:11 ` Tony Nguyen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aca8d358-7edc-4939-9e2e-10616fe4d1f6@intel.com \
    --to=anthony.l.nguyen@intel.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=metze@samba.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=przemyslaw.kitszel@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox