From: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: <netdev@vger.kernel.org>, <bpf@vger.kernel.org>,
<magnus.karlsson@intel.com>, <stfomichev@gmail.com>,
<pabeni@redhat.com>, <horms@kernel.org>,
<larysa.zaremba@intel.com>, <aleksander.lobakin@intel.com>,
<bjorn@kernel.org>, Ihor Solodrai <ihor.solodrai@linux.dev>
Subject: Re: [PATCH v3 net 0/8] xsk: tailroom reservation and MTU validation
Date: Fri, 27 Mar 2026 15:20:38 +0100 [thread overview]
Message-ID: <acaSNnW8moIFNCMb@boxer> (raw)
In-Reply-To: <20260326202721.37382070@kernel.org>
On Thu, Mar 26, 2026 at 08:27:21PM -0700, Jakub Kicinski wrote:
> On Mon, 23 Mar 2026 20:24:49 +0100 Maciej Fijalkowski wrote:
> > here we fix a long-standing issue regarding multi-buffer scenario in ZC
> > mode - we have not been providing space at the end of the buffer where
> > multi-buffer XDP works on skb_shared_info. This has been brought to our
> > attention via [0].
> >
> > Unaligned mode does not get any specific treatment, it is user's
> > responsibility to properly handle XSK addresses in queues.
> >
> > With adjustments included here in this set against xskxceiver I have
> > been able to pass the full test suite on ice.
>
> Please scream at me if I'm wrong but I _think_ this is somehow
> breaking BPF CI ?? It's the only BPF change we have AFAICT and
> CI has been failing like this all day:
>
> Root directory input is valid!
> Error: The path for one of the files in artifact is not valid: /packets-132-3-net_timestamping__INET4:_bpf_timestamping-net_timestamping_ns.log. Contains the following character: Colon :
>
> Invalid characters include: Double quote ", Colon :, Less than <, Greater than >, Vertical bar |, Asterisk *, Question mark ?, Carriage return \r, Line feed \n
>
> https://github.com/kernel-patches/bpf/actions/runs/23624136123/job/68809559810
That is probably due to this hang:
WATCHDOG: test case ns_xsk_drv/STAT_RX_DROPPED executes for 10 seconds...
Sorry for that! Please toss away v3 and v4 and let me resolve this.
I was too focused on the outcome of HW tests which I have been running via
xskxceiver. I need to see how to satisfy both sides.
Maciej
prev parent reply other threads:[~2026-03-27 14:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 19:24 [PATCH v3 net 0/8] xsk: tailroom reservation and MTU validation Maciej Fijalkowski
2026-03-23 19:24 ` [PATCH v3 net 1/8] xsk: tighten UMEM headroom validation to account for tailroom and min frame Maciej Fijalkowski
2026-03-23 19:24 ` [PATCH v3 net 2/8] xsk: respect tailroom for ZC setups Maciej Fijalkowski
2026-03-23 19:24 ` [PATCH v3 net 3/8] xsk: fix XDP_UMEM_SG_FLAG issues Maciej Fijalkowski
2026-03-23 19:24 ` [PATCH v3 net 4/8] xsk: validate MTU against usable frame size on bind Maciej Fijalkowski
2026-03-23 19:24 ` [PATCH v3 net 5/8] selftests: bpf: fix pkt grow tests Maciej Fijalkowski
2026-03-23 19:24 ` [PATCH v3 net 6/8] selftests: bpf: have a separate variable for drop test Maciej Fijalkowski
2026-03-23 19:24 ` [PATCH v3 net 7/8] selftests: bpf: adjust rx_dropped xskxceiver's test to respect tailroom Maciej Fijalkowski
2026-03-23 19:24 ` [PATCH v3 net 8/8] idpf: remove xsk frame size check against alignment Maciej Fijalkowski
2026-03-27 3:27 ` [PATCH v3 net 0/8] xsk: tailroom reservation and MTU validation Jakub Kicinski
2026-03-27 14:20 ` Maciej Fijalkowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acaSNnW8moIFNCMb@boxer \
--to=maciej.fijalkowski@intel.com \
--cc=aleksander.lobakin@intel.com \
--cc=bjorn@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=horms@kernel.org \
--cc=ihor.solodrai@linux.dev \
--cc=kuba@kernel.org \
--cc=larysa.zaremba@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stfomichev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox