From: Felix Maurer <fmaurer@redhat.com>
To: Luka Gejak <luka.gejak@linux.dev>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, netdev@vger.kernel.org, horms@kernel.org,
liuhangbin@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 2/4] net: hsr: fix VLAN add unwind on slave errors
Date: Fri, 27 Mar 2026 19:39:31 +0100 [thread overview]
Message-ID: <acbO48xPc--SBzOu@thinkpad> (raw)
In-Reply-To: <F40ED495-9115-489C-A010-0011A9229C4A@linux.dev>
On Fri, Mar 27, 2026 at 05:03:18PM +0100, Luka Gejak wrote:
> On March 27, 2026 12:52:02 PM GMT+01:00, Felix Maurer <fmaurer@redhat.com> wrote:
[...]
> >nit: superflous empty line (it's inconsistent with the other case
> >blocks)
> Good catch. I'll drop the extra newline in v3.
> >I think this would look cleaner with the good and the bad paths in
> >the same switch-case, but that may be a matter of (my) taste. What do
> > you think?
> Very well. I will take your preference into consideration and will
> make mentioned changes in v3. However I am not currently home and will
> send v3 once I come home in 1-2 days.
Alright, thank you! No hurry, take your time. Just fyi, I'll be out of
office next week, but I'll definitely review v3 as soon as I'm back (if
nobody else did it in the meantime).
Thanks,
Felix
next prev parent reply other threads:[~2026-03-27 18:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-26 15:47 [PATCH net-next v2 0/4] net: hsr: address functional and concurrency bugs luka.gejak
2026-03-26 15:47 ` [PATCH net-next v2 1/4] net: hsr: serialize seq_blocks merge across nodes luka.gejak
2026-03-26 15:47 ` [PATCH net-next v2 2/4] net: hsr: fix VLAN add unwind on slave errors luka.gejak
2026-03-27 11:52 ` Felix Maurer
2026-03-27 16:03 ` Luka Gejak
2026-03-27 18:39 ` Felix Maurer [this message]
2026-03-26 15:47 ` [PATCH net-next v2 3/4] net: hsr: require valid EOT supervision TLV luka.gejak
2026-03-26 15:47 ` [PATCH net-next v2 4/4] net: hsr: reject unresolved interlink ifindex luka.gejak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acbO48xPc--SBzOu@thinkpad \
--to=fmaurer@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuhangbin@gmail.com \
--cc=luka.gejak@linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox