From: kuznet@ms2.inr.ac.ru
To: george@mvista.com (george anzinger)
Cc: netdev@oss.sgi.com, linux-net@vger.kernel.org, davem@redhat.com,
ak@muc.de, pekkas@netcore.fi
Subject: Re: System crash in tcp_fragment()
Date: Tue, 21 May 2002 01:25:53 +0400 (MSD) [thread overview]
Message-ID: <acbpoe$udd$2@main.gmane.org> (raw)
In-Reply-To: <3CE95190.75C52E2D@mvista.com> from "george anzinger" at May 20, 2 12:42:08 pm
Hello!
> Is is possible for the other cpu (or even this one given the
> ksoftirqd stuff) to remove or alter the skb that
> tcp_fragment() is processing?
No.
> What locks, if any, are needed to prevent this.
They are already applied.
Looking at the last lines of the bugzilla thread, I see the answer:
> - Observation, the BUG_TRAP assertion likely should have done something better
> than just report the condition, wonder if an earlier panic or other corrective
> action may have kept the TCP stack moving instead of the oops? Looks lazy to
> me...
Well, add BUG() to BIG_TRAP() to oops it earlier. Maybe this will move
you closer to real problem.
And also your reasoning about smp_processor_id() sounds strange,
preemption code must reschedule thread preemted in the kernel to the
same cpu, it is enough to avoid troubles with this.
Alexey
next prev parent reply other threads:[~2002-05-20 21:25 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <3CE95190.75C52E2D@mvista.com>
2002-05-20 20:29 ` System crash in tcp_fragment() Andi Kleen
[not found] ` <20020520222937.A1467@averell>
2002-05-20 21:18 ` george anzinger
2002-05-20 21:25 ` kuznet [this message]
2002-05-20 22:08 ` David S. Miller
[not found] ` <200205202125.BAA03545@sex.inr.ac.ru>
2002-05-20 23:01 ` george anzinger
2002-05-20 23:54 ` Andi Kleen
2002-06-09 17:31 ` Network oops george anzinger
[not found] ` <3D0390E2.1B80ADEE@mvista.com>
2002-06-10 4:31 ` David S. Miller
2002-06-10 4:32 ` David S. Miller
[not found] ` <20020609.213150.32126725.davem@redhat.com>
2002-06-10 4:48 ` george anzinger
[not found] ` <3D042F8F.72764243@mvista.com>
2002-06-10 5:06 ` David S. Miller
2002-06-20 17:19 ` george anzinger
[not found] ` <3D120EAE.5A0D365E@mvista.com>
2002-06-21 0:38 ` David S. Miller
[not found] ` <20020620.173805.55219901.davem@redhat.com>
2002-06-21 14:16 ` george anzinger
[not found] ` <3D133538.60B6810C@mvista.com>
2002-06-21 14:17 ` David S. Miller
[not found] ` <20020621.071720.07439917.davem@redhat.com>
2002-06-21 15:12 ` george anzinger
2002-06-22 0:55 ` Andi Kleen
[not found] ` <20020622025551.A1919@averell>
2002-06-28 19:56 ` george anzinger
[not found] ` <20020609.213224.01016187.davem@redhat.com>
2002-06-10 8:11 ` george anzinger
[not found] ` <3D045F15.578E1DA9@mvista.com>
2002-06-10 8:31 ` David S. Miller
[not found] ` <20020610.013110.81671593.davem@redhat.com>
2002-06-10 14:12 ` george anzinger
[not found] <Pine.LNX.4.33.0205201836160.9301-100000@w-nivedita2.des.beaverton.ibm.com>
[not found] ` <3CE9E466.AC2358EE@mvista.com>
2002-05-21 6:00 ` System crash in tcp_fragment() David S. Miller
[not found] ` <20020520.230021.29510217.davem@redhat.com>
2002-05-21 7:25 ` george anzinger
2002-05-21 9:49 ` Andi Kleen
[not found] ` <3CE9F679.90ACF597@mvista.com>
2002-05-21 7:22 ` David S. Miller
2002-05-21 12:47 ` kuznet
2002-05-21 15:42 ` george anzinger
2002-05-21 12:54 ` Andi Kleen
2002-05-21 6:08 ` george anzinger
[not found] <20020520.173416.105610032.davem@redhat.com>
2002-05-21 1:00 ` kuznet
2002-05-21 1:49 ` Nivedita Singhvi
[not found] <3CE9960D.15D41380@mvista.com>
[not found] ` <200205210041.EAA04407@sex.inr.ac.ru>
2002-05-21 0:34 ` David S. Miller
2002-05-21 0:41 ` kuznet
[not found] <20020521015407.A1296@wotan.suse.de>
2002-05-21 0:11 ` kuznet
2002-05-21 0:20 ` Andi Kleen
2002-05-21 0:26 ` george anzinger
[not found] ` <20020521022007.A6248@wotan.suse.de>
2002-05-21 0:34 ` george anzinger
[not found] ` <3CE99434.20E7479C@mvista.com>
2002-05-21 0:18 ` David S. Miller
2002-05-21 0:39 ` Andi Kleen
2002-05-20 19:42 george anzinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='acbpoe$udd$2@main.gmane.org' \
--to=kuznet@ms2.inr.ac.ru \
--cc=ak@muc.de \
--cc=davem@redhat.com \
--cc=george@mvista.com \
--cc=linux-net@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=pekkas@netcore.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).