From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nikolay Aleksandrov Subject: Re: [PATCH net-next 2/9] net: bridge: Propagate extack to switchdev Date: Wed, 12 Dec 2018 14:20:02 +0200 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Jiri Pirko , Ido Schimmel , "davem@davemloft.net" , "ivecera@redhat.com" , Roopa Prabhu , David Ahern , "bridge@lists.linux-foundation.org" To: Petr Machata , "netdev@vger.kernel.org" Return-path: Received: from mail-wm1-f65.google.com ([209.85.128.65]:54094 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727067AbeLLMUG (ORCPT ); Wed, 12 Dec 2018 07:20:06 -0500 Received: by mail-wm1-f65.google.com with SMTP id y1so5509946wmi.3 for ; Wed, 12 Dec 2018 04:20:05 -0800 (PST) In-Reply-To: Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 12/12/2018 13:52, Petr Machata wrote: > ndo_bridge_setlink has been updated in the previous patch to have extack > available, and changelink RTNL op has had this argument since the time > extack was added. Propagate both through the bridge driver to eventually > reach br_switchdev_port_vlan_add(), where it will be used by subsequent > patches. > > Signed-off-by: Petr Machata > Acked-by: Jiri Pirko > --- > net/bridge/br_if.c | 2 +- > net/bridge/br_netlink.c | 27 +++++++++++++--------- > net/bridge/br_private.h | 22 ++++++++++-------- > net/bridge/br_switchdev.c | 3 ++- > net/bridge/br_vlan.c | 59 ++++++++++++++++++++++++++--------------------- > 5 files changed, 65 insertions(+), 48 deletions(-) > +CC Roopa & bridge list Looks good to me. Acked-by: Nikolay Aleksandrov