From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F99BC43381 for ; Tue, 26 Feb 2019 07:33:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1A3B0217F9 for ; Tue, 26 Feb 2019 07:33:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gJzlpkHH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726677AbfBZHdW (ORCPT ); Tue, 26 Feb 2019 02:33:22 -0500 Received: from mail-wm1-f67.google.com ([209.85.128.67]:34860 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725901AbfBZHdV (ORCPT ); Tue, 26 Feb 2019 02:33:21 -0500 Received: by mail-wm1-f67.google.com with SMTP id y15so1234539wma.0 for ; Mon, 25 Feb 2019 23:33:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=3+iYP6h/ghAjfSw/97L3zWd3IoCiNGC88JAkfPgrkRs=; b=gJzlpkHHqTx54fzhOsWvJCr8K7ABNQZXul9wQM2vy5OFNMwWJzBZRAqBohjNDQOd4E Jb+3FJxK4vxsNQEkoFchquNCjs0JmxrMGSOeB4R31Fpuc+DFA25kf32vmxyQ49Yn9+UF EtINTBaEiaEX6UB8pGfeb7/KmH+uqo/Q54iD4l6/edSPcHdbFTZ3VilcpI6e8mSlKxVY kwTLlpBNlDgDGfOWHjJNgmbSKo6fwIgP734SuwnUs/rztlBTriWVrvCEhWat45DwIOOK TBI1G1o+B12PGf5NIzh2hBZ+wmjRPipgilmX53qYL0rxRxpBQRwhj0mmWKRq/FFS7U70 7rYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=3+iYP6h/ghAjfSw/97L3zWd3IoCiNGC88JAkfPgrkRs=; b=B15QDtuCGczPjc+zaalM2zR/4tRr9IQPyZxoQ7Y8oOW/wouOrDwAY8HJwxWxvLZdR6 FUn1jr7NRWCcdRaiv/JlVw+sC6+Sswe39MAs1JVLX+eIGl8RmXM1XI79mcdjJF0ud2bw VAd/BCXViTsvwCoK/6Zk9t8UWSHohEL8CSHaluKfGcUOh1nf88+gsQUzXCkB4ntxVxsD dFrLfeOIIp0kRQY0yUnwXrGCrorBaZaZl0yiIlnK/CcQbvYO7I0OACiwU2kbp9c+m/dj dXtoIXuEvnkbJRr20fBZCDw3he+OOHG1JfpLQcJlXOVoOEVglp+nDFgWm/EvGMWmn4nW Dq4w== X-Gm-Message-State: AHQUAuaAUpu73vfRXQ2Op4qx23YdWHYC8K84AOLnxkBRrsR1BvBCLDOS qaS8BiLZ1heGPnp49C1CFLS6ePrc X-Google-Smtp-Source: AHgI3IaqHk9R1dX8HoG1CsGMHzqawRpuONxNrg/xljzn3oE0is4SBkx8ggVVQ0s02AinqB2bhQfuig== X-Received: by 2002:a1c:228b:: with SMTP id i133mr1667070wmi.105.1551166399079; Mon, 25 Feb 2019 23:33:19 -0800 (PST) Received: from ?IPv6:2003:ea:8bf1:e200:10cc:f3cd:165b:9669? (p200300EA8BF1E20010CCF3CD165B9669.dip0.t-ipconnect.de. [2003:ea:8bf1:e200:10cc:f3cd:165b:9669]) by smtp.googlemail.com with ESMTPSA id a24sm18500123wmm.1.2019.02.25.23.33.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Feb 2019 23:33:18 -0800 (PST) Subject: Re: [RFC] net: dsa: qca8k: CPU port broken with commit 5502b218e001 ("net: phy: use phy_resolve_aneg_linkmode in genphy_read_status") To: =?UTF-8?B?TWljaGFsIFZva8OhxI0=?= , Andrew Lunn , Vinod Koul Cc: "David S. Miller" , Florian Fainelli , netdev@vger.kernel.org References: From: Heiner Kallweit Message-ID: Date: Tue, 26 Feb 2019 08:33:16 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 20.02.2019 16:02, Michal Vokáč wrote: > Hi, > > Another issue in a row with networking on imx6dl-yapp4 platform [1] > that uses QCA8334 Ethernet switch. > > Very recently, with Vinod and Andrew, we solved an issue with > RGMII_ID mode by patch[2][3]. I tested those with next-20190215 > and it worked just fine. > > The patch[2] was merged into next-20190220 so I tested the latest version. > Now the cpu port does not work again. I tracked it down to this commit > 5502b218e001 ("net: phy: use phy_resolve_aneg_linkmode in > genphy_read_status") [4] > > If I revert the offending commit, cpu port works fine. I suspect the > problem is on the qca8k driver side but I am not really sure. > AFAICT autonegotiation is not available on the QCA833x cpu port (MAC0). > > Any ideas what may be the root cause of the problem? > Hi Michal, I faced the same issue on a system with Marvell switch. Should be fixed with 0f3b1cf23f0e ("net: phy: fix reading fixed phy status"). This patch is in net-next currently and should show up in linux-next today. > Thank you, > Michal > Heiner > [1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=87489ec3a77f3e01bcf0d46e353ae7112ec8c4f0 > [2] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=a968b5e9d5879f9535d6099505f9e14abcafb623 > [3] https://lore.kernel.org/patchwork/patch/1043817/ > [4] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=5502b218e001 >