public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Hangbin Liu <liuhangbin@gmail.com>
To: Jiayuan Chen <mrpre@163.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	David Ahern <dsahern@kernel.org>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Simon Horman <horms@kernel.org>,
	Jiayuan Chen <jiayuan.chen@linux.dev>,
	David Ahern <dsahern@gmail.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	Fei Liu <feliu@redhat.com>
Subject: Re: [PATCH net v2] ipv6: fix data race in fib6_metric_set() using cmpxchg
Date: Tue, 31 Mar 2026 01:34:21 +0000	[thread overview]
Message-ID: <acsknTbxa3REYrlS@fedora> (raw)
In-Reply-To: <7e8c45cb-b5dd-4694-80e9-7c8e5ad9ade7@163.com>

On Sat, Mar 28, 2026 at 07:22:48PM +0800, Jiayuan Chen wrote:
> https://sashiko.dev/#/patchset/20260327-b4-fib6_metric_set-kmemleak-v2-1-366b2c78b5c2%40gmail.com
> 
> 
> The concern about reader paths (e.g., ip_dst_init_metrics, fib6_pmtu)
> lacking READ_ONCE()
> annotations is valid — if the compiler reloads from->fib6_metrics after
> inlining, it could produce
> an inconsistent pointer/flags combination in dst->_metrics, potentially
> leading to a refcount_dec
> on the read-only dst_default_metrics.

Thanks, I will fix the reader path separately in case I missed anything and
slow down this one's process.

Thanks
Hangbin

  reply	other threads:[~2026-03-31  1:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-27  2:24 [PATCH net v2] ipv6: fix data race in fib6_metric_set() using cmpxchg Hangbin Liu
2026-03-28 11:22 ` Jiayuan Chen
2026-03-31  1:34   ` Hangbin Liu [this message]
2026-03-31  0:46 ` Jakub Kicinski
2026-03-31  1:12   ` Hangbin Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=acsknTbxa3REYrlS@fedora \
    --to=liuhangbin@gmail.com \
    --cc=davem@davemloft.net \
    --cc=dsahern@gmail.com \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=feliu@redhat.com \
    --cc=horms@kernel.org \
    --cc=jiayuan.chen@linux.dev \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mrpre@163.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox