From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Charles Perry <charles.perry@microchip.com>
Cc: netdev@vger.kernel.org,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v3 2/2] net: mdio: add a driver for PIC64-HPSC/HX MDIO controller
Date: Tue, 31 Mar 2026 13:57:10 +0100 [thread overview]
Message-ID: <acvEpk1grDFAahzd@shell.armlinux.org.uk> (raw)
In-Reply-To: <20260331123858.1912449-3-charles.perry@microchip.com>
On Tue, Mar 31, 2026 at 05:38:54AM -0700, Charles Perry wrote:
> + if (!(bus->phy_ignore_ta_mask & 1 << mii_id) &&
> + !FIELD_GET(MDIO_READOK_BIT, val)) {
> + dev_dbg(&bus->dev, "READOK bit cleared\n");
> + return -EIO;
> + }
> +
> + ret = FIELD_GET(MDIO_RDATA_MASK, val);
> +
> + return ret;
You don't need "ret" here, this can simply be:
return FIELD_GET(MDIO_RDATA_MASK, val);
...
> + writel(MDIO_TRIGGER_BIT | FIELD_PREP(MDIO_REG_DEV_ADDR_MASK, regnum) |
> + FIELD_PREP(MDIO_PHY_PRT_ADDR_MASK, mii_id) |
> + FIELD_PREP(MDIO_OPERATION_MASK, MDIO_OPERATION_WRITE) |
> + FIELD_PREP(MDIO_START_OF_FRAME_MASK, 1),
> + priv->regs + MDIO_REG_FRAME_CFG_2);
Shouldn't this wait for the write to complete?
Thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2026-03-31 12:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-31 12:38 [PATCH net-next v3 0/2] Add support for PIC64-HPSC/HX MDIO controller Charles Perry
2026-03-31 12:38 ` [PATCH net-next v3 1/2] dt-bindings: net: document Microchip " Charles Perry
2026-03-31 12:38 ` [PATCH net-next v3 2/2] net: mdio: add a driver for " Charles Perry
2026-03-31 12:51 ` Andrew Lunn
2026-03-31 12:57 ` Russell King (Oracle) [this message]
2026-03-31 13:42 ` Charles Perry
2026-03-31 14:05 ` Russell King (Oracle)
2026-03-31 14:20 ` Andrew Lunn
2026-03-31 14:43 ` Charles Perry
2026-03-31 14:57 ` Russell King (Oracle)
2026-03-31 23:43 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acvEpk1grDFAahzd@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=charles.perry@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox