From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E82A3E5EC9; Tue, 31 Mar 2026 13:07:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.32.30.218 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774962478; cv=none; b=HQnTLVGC8j3ZO9lw7gzEzeytbPmf5jyBYwtPdGJlBxdudMho7P0NLmgFPVt0W65Isn//KanMScR3XnTWgGPk68JJ7+fE1SXLy2/WPrlawz3FIbNcMUzmObVJ2wNroC0zjWn6jB551sW6jBoQNUdOqh34Ob6asoCUewFB50zQRkE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774962478; c=relaxed/simple; bh=eosv1AZxzlSDL5rb2/xDDZuxQtW9KHKcYbpvcjA+Eb0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mZI9qWENb3j6o+PPZnRMs6gRooOplAnP8HzjRkxerQAlMsFmKwobgHO/TS0Xlr9fcqbuTzgQMUvutRXQGTmgnxXhYoMcQXOH3Gt9pdy7hnN3qTZgeHEdfWPHmIpGTfxiNArlEM/B7HYR7Pi1CG96gELKDASQpL3gPabV2ibTAEA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk; spf=none smtp.mailfrom=armlinux.org.uk; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b=i+xuOMXf; arc=none smtp.client-ip=78.32.30.218 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="i+xuOMXf" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=1sO/3nA/45rKDmeI79eubvzryv2xW7zUpGf4TvMjB2I=; b=i+xuOMXfN/z1pnGaVlTZDVBVej +OQUKTtgErtR8OHs/RNH7L4DczjIUnF6sAqFDKbQy2KtZ4ol5qHg1GToJDrofCPjxlZyGUumF405x YKMpxCq5IU5XVWjerIwF7cY6ed9qDVX/HK1Wd13hIFlHZbXOROciiFEVqMqcC3jvmkFYSs/2hdmu3 7AzaHWFPdMbAONzqh298d0KZf5VksL87ZTmceUBTY37hlZJatiPKTEI+5UME+17ZTvPfxUMMD2gX7 Aif15E+MzsYSapEUP0VexHYi1NqmHbOSJvs4FbYsczTX/HPw97hTywaM90WdbfMkTpwb9N3+OG/OB pLx2gvcw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:42808) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1w7Yox-000000001rh-1uLR; Tue, 31 Mar 2026 14:07:51 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.98.2) (envelope-from ) id 1w7Yos-000000003kB-2g58; Tue, 31 Mar 2026 14:07:46 +0100 Date: Tue, 31 Mar 2026 14:07:46 +0100 From: "Russell King (Oracle)" To: Jiawen Wu Cc: netdev@vger.kernel.org, Mengyuan Lou , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Jacob Keller , Abdun Nihaal , stable@vger.kernel.org Subject: Re: [PATCH net] net: txgbe: fix RTNL assertion warning when remove module Message-ID: References: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Russell King (Oracle) On Tue, Mar 31, 2026 at 03:11:07PM +0800, Jiawen Wu wrote: > For the copper NIC with external PHY, the driver called > phylink_connect_phy() during probe and phylink_disconnect_phy() during > remove. It caused an RTNL assertion warning in phylink_disconnect_phy() > upon module remove. > > To fix this, move the phylink connect/disconnect PHY to ndo_open/close. Wouldn't it be simpler to just wrap the phylink_disconnect_phy() in the remove function with rtnl_lock()..rtnl_unlock() ? -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!