From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B97723958D; Tue, 31 Mar 2026 13:38:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.32.30.218 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774964302; cv=none; b=Ys2BhaqI7e58wnVx+1v2vy4vexgOFEuipvlaZnl1liUynJf3wzYp20m+8qbyziYRS/IrU2/9S4IXAfCop7pBfSDyhzPh6ZmWFoMgZoXna46aG8rb+yINMZi5vmpmJ7p1K7oT0XJ6hbbv7xGMU+QKZzRfaOST3Vuc4a26k5MqxE8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774964302; c=relaxed/simple; bh=fM0kCdNQKvtQ3Sw8jKAxEzWo5iK4fm4bQbsosa1F5lg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=iT2WYBXnPdd3vBzKJix4V1DfdyOdmlilwsCzP3rW6h9auzHphXpbzsKFyQrtjhYqWnXNrREDdEuuXLzo87VBXM7VUKMxnBt/0NeVZfXAmvxOXRPj7KivUWPo4sU9n/R0oQ0uWLmjIMybRv0WcEeTfR8SlXhXJ/7GcdY0NPe5cos= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk; spf=none smtp.mailfrom=armlinux.org.uk; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b=kdEZvqlE; arc=none smtp.client-ip=78.32.30.218 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="kdEZvqlE" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=8SfiYxYPsCmBQN0cjhyBPejDkbLaM0G7dokSuXlFabI=; b=kdEZvqlEYcPTes5uvkczlOSatZ WGsTV9x/GXoHkkrCfMbDf32NEDxsB3QV6WKqzQKMycmJUeMY0wkbgiYhD2koL+oOvCLpMXHckXDTd Dt6Aj53q+wkqNzd9B/WaFoIgQDCgrXNym8IPYf63FcWYQRyZEnMtzKZhZJGxcfFeeaGT8jZrRGfPl 8Ro7CImCYu2MIOm8IhxbtVAGDWTMDlGvc8a/03Z74R2gfb89ULYIgFzIny40xkwvHyndSTlIpq7W1 IXi9988wv+CzCYVK/4Oz/lSobHoR1XqLVB3J2M/vkGV4RzE/3/hPLCuVwdeVCv2lMi/cw7PjjCicH aSL4EtMw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:51508) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1w7ZIG-000000001tK-3bYE; Tue, 31 Mar 2026 14:38:09 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.98.2) (envelope-from ) id 1w7ZIA-000000003lU-3Zkg; Tue, 31 Mar 2026 14:38:02 +0100 Date: Tue, 31 Mar 2026 14:38:02 +0100 From: "Russell King (Oracle)" To: Jan Hoffmann Cc: Andrew Lunn , Heiner Kallweit , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Daniel Golle , Markus Stockhausen , Damien Dejean , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v2] net: phy: realtek: support MDI swapping for RTL8226-CG Message-ID: References: <20260327202001.413280-1-jan@3e8.eu> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260327202001.413280-1-jan@3e8.eu> Sender: Russell King (Oracle) On Fri, Mar 27, 2026 at 08:32:28PM +0100, Jan Hoffmann wrote: > +static int rtl8226_config_init(struct phy_device *phydev) > +{ > + int ret; > + > + ret = rtl8226_config_mdi_order(phydev); > + if (ret) > + return ret; As I've been pointing out in other patches, putting this "defaulting" here is not a good idea - this path gets called when the PHY is attached to the netdev and also when the PHY is being resumed - which will wipe out the user's configuration just because their system suspended. I don't think that gives the user a good experience. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!