* [REGRESSION] net: add xmit recursion limit to tunnel xmit functions
@ 2026-03-31 20:09 Chris Arges
2026-04-02 0:38 ` Jakub Kicinski
0 siblings, 1 reply; 3+ messages in thread
From: Chris Arges @ 2026-03-31 20:09 UTC (permalink / raw)
To: Weiming Shi, Eric Dumazet, Paolo Abeni; +Cc: netdev, kernel-team, jgriege
Hello,
Commit 6f1a9140ecda ("net: add xmit recursion limit to tunnel xmit functions")
introduces a regression in our systems using legitimate multi-level tunnel
encapsulation stacks. Our testing was with stable 6.12.y and 6.18.y where this
patch was backported.
One of the usecases we have are packets being sent to a GRE device, then
MPLS/LWT route, then IPIP device, then SIT/FOU device. What we observed is that
packets are getting dropped at the last device and we get the message "Dead
loop on virtual device" sent from the iptunnel_xmit function.
I'm looking for some approaches to retain the mitigation while still having a
recursion limit. One idea is to just increase the limit. Happy to provide
additional testing and debugging.
Thanks,
--chris
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [REGRESSION] net: add xmit recursion limit to tunnel xmit functions
2026-03-31 20:09 [REGRESSION] net: add xmit recursion limit to tunnel xmit functions Chris Arges
@ 2026-04-02 0:38 ` Jakub Kicinski
2026-04-02 9:31 ` Paolo Abeni
0 siblings, 1 reply; 3+ messages in thread
From: Jakub Kicinski @ 2026-04-02 0:38 UTC (permalink / raw)
To: Chris Arges
Cc: Weiming Shi, Eric Dumazet, Paolo Abeni, netdev, kernel-team,
jgriege
On Tue, 31 Mar 2026 15:09:33 -0500 Chris Arges wrote:
> Commit 6f1a9140ecda ("net: add xmit recursion limit to tunnel xmit functions")
> introduces a regression in our systems using legitimate multi-level tunnel
> encapsulation stacks. Our testing was with stable 6.12.y and 6.18.y where this
> patch was backported.
>
> One of the usecases we have are packets being sent to a GRE device, then
> MPLS/LWT route, then IPIP device, then SIT/FOU device. What we observed is that
> packets are getting dropped at the last device and we get the message "Dead
> loop on virtual device" sent from the iptunnel_xmit function.
Last device meaning limit of 5 would have worked for you?
I don't think there was any hard math behind the 4 so ++
on the limit may be simplest, but I defer to Paolo..
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [REGRESSION] net: add xmit recursion limit to tunnel xmit functions
2026-04-02 0:38 ` Jakub Kicinski
@ 2026-04-02 9:31 ` Paolo Abeni
0 siblings, 0 replies; 3+ messages in thread
From: Paolo Abeni @ 2026-04-02 9:31 UTC (permalink / raw)
To: Jakub Kicinski, Chris Arges
Cc: Weiming Shi, Eric Dumazet, netdev, kernel-team, jgriege
On 4/2/26 2:38 AM, Jakub Kicinski wrote:
> On Tue, 31 Mar 2026 15:09:33 -0500 Chris Arges wrote:
>> Commit 6f1a9140ecda ("net: add xmit recursion limit to tunnel xmit functions")
>> introduces a regression in our systems using legitimate multi-level tunnel
>> encapsulation stacks. Our testing was with stable 6.12.y and 6.18.y where this
>> patch was backported.
>>
>> One of the usecases we have are packets being sent to a GRE device, then
>> MPLS/LWT route, then IPIP device, then SIT/FOU device. What we observed is that
>> packets are getting dropped at the last device and we get the message "Dead
>> loop on virtual device" sent from the iptunnel_xmit function.
>
> Last device meaning limit of 5 would have worked for you?
> I don't think there was any hard math behind the 4 so ++
> on the limit may be simplest, but I defer to Paolo..
AFAICS the '4' limit was an empirical choice, and the reported splat
used 7 devices, so moving to 5 should fit, even if I must admit it feels
a bit a whack a mole situation. On the flip side a revert of the blamed
commit feels not safe.
@Chris, could you please share a patch increasing the limit to 5?
Thanks,
Paolo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-04-02 9:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-31 20:09 [REGRESSION] net: add xmit recursion limit to tunnel xmit functions Chris Arges
2026-04-02 0:38 ` Jakub Kicinski
2026-04-02 9:31 ` Paolo Abeni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox