Re: [PATCH net-next 3/4] net: macb: Factor out the handling of non-hot IRQ events into a separate function

Kevin Hao
2026-04-01T09:31:32Z

[-- Attachment #1: Type: text/plain, Size: 444 bytes --]

On Tue, Mar 31, 2026 at 07:54:31PM -0700, Jakub Kicinski wrote:
> On Sat, 28 Mar 2026 18:17:47 +0800 Kevin Hao wrote:
> > struct macb_queue *queue = dev_id;
> > struct macb *bp = queue->bp;
> > struct net_device *dev = bp->dev;
> > - u32 status, ctrl;
> > + u32 status;
> > bool isr_clear;
>
> nit: please try to keep the variable declaration lines sorted longest to
> shortest

Will address this in v2.

Thanks,
Kevin

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]