Re: [PATCH net-next 0/4] net: macb: Remove dedicated IRQ handler for WoL

Simon Horman
2026-04-03T16:17:11Z

On Sat, Mar 28, 2026 at 06:17:44PM +0800, Kevin Hao wrote:
> During debugging of a suspend/resume issue, I observed that the macb driver
> employs a dedicated IRQ handler for Wake-on-LAN (WoL) support. To my knowledge,
> no other Ethernet driver adopts this approach. This implementation unnecessarily
> complicates the suspend/resume process without providing any clear benefit.
> Instead, we can easily modify the existing IRQ handler to manage WoL events,
> avoiding any overhead in the TX/RX hot path.
>
> I am skeptical that the minor optimizations to the IRQ handler proposed in this
> patch series would yield any measurable performance improvement. However, it
> does appear that the execution time of the macb_interrupt() function is
> slightly reduced.
>
> The following data(net throughput and execution time of macb_interrupt) were
> collected from my AMD Zynqmp board using the commands:
> taskset -c 1,2,3 iperf3 -c 192.168.3.4 -t 60 -Z -P 3 -R
> cat /sys/kernel/debug/tracing/trace_stat/function0

...

For the series:

Reviewed-by: Simon Horman <horms@kernel.org>