From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C66935C197 for ; Wed, 15 Apr 2026 12:59:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.32.30.218 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776257985; cv=none; b=uaJv41mtpMfbn4u0edfgu1EUUcklo5CEnA8D+LS1YJ031tvTj+iHlGiu3EVjBpMx66gtP2dmuEMXnvO9MCDFZ+Ph/fR+eL4cgjPxHOB6M3HA3vHvoXnWRuk3GinVUOR2fFCdTUTNC+sDoVBdq64i1ind/xmoOHZ0jpufu7NWN9U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776257985; c=relaxed/simple; bh=QI8hvSFR4MG7toHeGfU6mUaxTYPzK5OvM+q+8pgdxDM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JYQu9/KvUlPB39nR3y31G6tO9D//8tcX7HIW7Z1EjbcFZVxxKThX8MSQr76bXSOT3jjVwX6Hn84jMjI/J7LFExdhiweWrK8Mp3Y1FgJnCqZCt3BgCTcdJ1UcjWZtezofkQNgM9XQnR1ESdUOWEBL1hi+lrIiGOJ9j8udCVXvSuA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk; spf=none smtp.mailfrom=armlinux.org.uk; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b=aFyriBXu; arc=none smtp.client-ip=78.32.30.218 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="aFyriBXu" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=k1puqjkx70xR77cxDwbqQolTS/KLwYlYFTOWLOqnzlM=; b=aFyriBXuIy8LHVTejW1TUXwLSI SOGtjKg/MRydcxHRxyQwoWq1ZMD5bmH+zHEXuwt9s/TgJKEIQvXYmU/CVhy/JjHCom2U4e8bU6qLo 87W1gK0L3wGZJMrRowFSZIdUb+E5XAcib8X4LG7+rupk+ph3+nYjveF29ZNvTl7ss6iIIRG/g6FZK mcPmRJ4JcBkbfPOt09h5TjV0eVBiQPuuQ3xMWChxR/IXz3YuKsLinJOie1NfDpQDAxDgIo7K1PSuK TL5zcIE/On68zsFvm6Mc7BgNzAyjhZay+pKmXU5Qcc3uqdKZTDhOF93nE+/MPpFU6TeMtUwXoDDkv m8g+Ib8A==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:59050) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wCzqA-0000000026f-2wkF; Wed, 15 Apr 2026 13:59:34 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.98.2) (envelope-from ) id 1wCzq8-000000002EM-3sFk; Wed, 15 Apr 2026 13:59:32 +0100 Date: Wed, 15 Apr 2026 13:59:32 +0100 From: "Russell King (Oracle)" To: Alexander Stein Cc: Andrew Lunn , Heiner Kallweit , Alexandre Torgue , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, Maxime Coquelin , netdev@vger.kernel.org, Paolo Abeni Subject: Re: [PATCH net-next 5/6] net: stmmac: move PHY handling out of __stmmac_open()/release() Message-ID: References: <8409022.LvFx2qVVIh@steina-w> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8409022.LvFx2qVVIh@steina-w> Sender: Russell King (Oracle) On Wed, Apr 15, 2026 at 08:08:40AM +0200, Alexander Stein wrote: > Hi, > > Am Dienstag, 23. September 2025, 13:26:19 CEST schrieb Russell King (Oracle): > > Move the PHY attachment/detachment from the network driver out of > > __stmmac_open() and __stmmac_release() into stmmac_open() and > > stmmac_release() where these actions will only happen when the > > interface is administratively brought up or down. It does not make > > sense to detach and re-attach the PHY during a change of MTU. > > Sorry for coming up now. But I recently noticed this commit breaks changing > the MTU on i.MX8MP. Once I simply change the MTU I run into some DMA error: > $ ip link set dev end1 mtu 1400 > imx-dwmac 30bf0000.ethernet end1: Register MEM_TYPE_PAGE_POOL RxQ-0 > imx-dwmac 30bf0000.ethernet end1: Register MEM_TYPE_PAGE_POOL RxQ-1 > imx-dwmac 30bf0000.ethernet end1: Register MEM_TYPE_PAGE_POOL RxQ-2 > imx-dwmac 30bf0000.ethernet end1: Register MEM_TYPE_PAGE_POOL RxQ-3 > imx-dwmac 30bf0000.ethernet end1: Register MEM_TYPE_PAGE_POOL RxQ-4 > imx-dwmac 30bf0000.ethernet end1: Link is Down > imx-dwmac 30bf0000.ethernet end1: Failed to reset the dma > imx-dwmac 30bf0000.ethernet end1: stmmac_hw_setup: DMA engine initialization failed This basically means that a clock is missing. Please provide more information: - what kernel version are you using? - has EEE been negotiated? - does the problem persist when EEE is disabled? - which PHY is attached to stmmac? - which PHY interface mode is being used to connect the PHY to stmmac? Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!