From: Vadim Fedorenko <vadim.fedorenko@linux.dev>
To: Leon Romanovsky <leon@kernel.org>,
Maxim Korotkov <korotkov.maxim.s@gmail.com>
Cc: Rasesh Mody <rmody@marvell.com>,
GR-Linux-NIC-Dev@marvell.com,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Michael Chan <mchan@broadcom.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
lvc-project@linuxtesting.org
Subject: Re: [PATCH v2] bnx2: remove deadcode in bnx2_init_cpus()
Date: Mon, 20 Feb 2023 16:30:50 +0000 [thread overview]
Message-ID: <ad25cce1-108c-76b0-fd46-739603e87d1c@linux.dev> (raw)
In-Reply-To: <Y/Mv4nhHLq2Ms8d4@unreal>
On 20/02/2023 08:31, Leon Romanovsky wrote:
> On Sun, Feb 19, 2023 at 06:22:25PM +0300, Maxim Korotkov wrote:
>> The load_cpu_fw function has no error return code
>> and always returns zero. Checking the value returned by
>> this function does not make sense.
>> As a result, bnx2_init_cpus() will also return only zero
>> Therefore, it will be safe to change the type of functions
>> to void and remove checking
>>
>> Found by Security Code and Linux Verification
>> Center (linuxtesting.org) with SVACE
>>
>> Fixes: 57579f7629a3 ("bnx2: Use request_firmware()")
>> Signed-off-by: Maxim Korotkov <korotkov.maxim.s@gmail.com>
>> ---
>> changes v2:
>> - bnx2_init_cpu_fw() and bnx2_init_cpus() are void
>> - delete casts to void
>> - remove check of bnx2_init_cpus() in bnx2_init_chip()
>>
>
> Thanks,
> Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Not sure if it should go to -net, because it doesn't actually fix any
bug, more like refactoring which goes to -next, I believe.
next prev parent reply other threads:[~2023-02-20 16:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-19 15:22 [PATCH v2] bnx2: remove deadcode in bnx2_init_cpus() Maxim Korotkov
2023-02-20 8:31 ` Leon Romanovsky
2023-02-20 16:30 ` Vadim Fedorenko [this message]
2023-02-21 9:38 ` Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad25cce1-108c-76b0-fd46-739603e87d1c@linux.dev \
--to=vadim.fedorenko@linux.dev \
--cc=GR-Linux-NIC-Dev@marvell.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=korotkov.maxim.s@gmail.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rmody@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).