From: David Ahern <dsahern@kernel.org>
To: Vladimir Vdovin <deliran@verdict.gg>, Ido Schimmel <idosch@idosch.org>
Cc: netdev@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCH] net: ipv4: Cache pmtu for all packet paths if multipath enabled
Date: Wed, 6 Nov 2024 11:57:25 -0700 [thread overview]
Message-ID: <ad29493c-9e48-4a94-b327-e47af3a9d137@kernel.org> (raw)
In-Reply-To: <D5F9OJYSMFXS.2HOGXNFVKTOLL@verdict.gg>
On 11/6/24 10:20 AM, Vladimir Vdovin wrote:
> On Tue Nov 5, 2024 at 6:52 AM MSK, David Ahern wrote:
>> On 11/2/24 10:20 AM, Vladimir Vdovin wrote:
>>>>
>>>> Doesn't IPv6 suffer from a similar problem?
>>
>> I believe the answer is yes, but do not have time to find a reproducer
>> right now.
>>
>>>
>>> I am not very familiar with ipv6,
>>> but I tried to reproduce same problem with my tests with same topology.
>>>
>>> ip netns exec ns_a-AHtoRb ip -6 r g fc00:1001::2:2 sport 30003 dport 443
>>> fc00:1001::2:2 via fc00:2::2 dev veth_A-R2 src fc00:1000::1:1 metric 1024 expires 495sec mtu 1500 pref medium
>>>
>>> ip netns exec ns_a-AHtoRb ip -6 r g fc00:1001::2:2 sport 30013 dport 443
>>> fc00:1001::2:2 via fc00:1::2 dev veth_A-R1 src fc00:1000::1:1 metric 1024 expires 484sec mtu 1500 pref medium
you should dump the cache to see the full exception list.
>>>
>>> It seems that there are no problems with ipv6. We have nhce entries for both paths.
>>
>> Does rt6_cache_allowed_for_pmtu return true or false for this test?
> It returns true.
>
>
Looking at the code, it is creating a single exception - not one per
path. I am fine with deferring the ipv6 patch until someone with time
and interest can work on it.
next prev parent reply other threads:[~2024-11-06 18:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-29 15:21 [PATCH] net: ipv4: Cache pmtu for all packet paths if multipath enabled Vladimir Vdovin
2024-10-29 23:22 ` David Ahern
2024-10-30 17:11 ` Ido Schimmel
2024-11-02 16:20 ` Vladimir Vdovin
2024-11-05 3:52 ` David Ahern
2024-11-06 17:20 ` Vladimir Vdovin
2024-11-06 18:57 ` David Ahern [this message]
2024-10-31 15:42 ` [PATCH v3] " Vladimir Vdovin
2024-11-01 10:21 ` [PATCH v4] " Vladimir Vdovin
2024-11-01 10:48 ` [PATCH v5] " Vladimir Vdovin
2024-11-01 13:45 ` Jakub Kicinski
2024-11-01 17:34 ` Vladimir Vdovin
2024-11-02 8:49 ` Paolo Abeni
2024-11-02 15:58 ` Vladimir Vdovin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad29493c-9e48-4a94-b327-e47af3a9d137@kernel.org \
--to=dsahern@kernel.org \
--cc=davem@davemloft.net \
--cc=deliran@verdict.gg \
--cc=idosch@idosch.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).