Re: [PATCH bpf-next] bpf_load: add map name to load_maps error message

[John Fastabend <john.fastabend@gmail.com>]

On 10/29/2018 02:14 PM, Shannon Nelson wrote:
> To help when debugging bpf/xdp load issues, have the load_map()
> error message include the number and name of the map that
> failed.
> 
> Signed-off-by: Shannon Nelson <shannon.nelson@oracle.com>
> ---
>  samples/bpf/bpf_load.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/samples/bpf/bpf_load.c b/samples/bpf/bpf_load.c
> index 89161c9..5de0357 100644
> --- a/samples/bpf/bpf_load.c
> +++ b/samples/bpf/bpf_load.c
> @@ -282,8 +282,8 @@ static int load_maps(struct bpf_map_data *maps, int nr_maps,
>  							numa_node);
>  		}
>  		if (map_fd[i] < 0) {
> -			printf("failed to create a map: %d %s\n",
> -			       errno, strerror(errno));
> +			printf("failed to create map %d (%s): %d %s\n",
> +			       i, maps[i].name, errno, strerror(errno));
>  			return 1;
>  		}
>  		maps[i].fd = map_fd[i];
> 

LGTM

Acked-by: John Fastabend <john.fastabend@gmail.com>