From: Andrew Lunn <andrew@lunn.ch>
To: Daniel Thompson <daniel@riscstar.com>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Jesper Dangaard Brouer <hawk@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
Stanislav Fomichev <sdf@fomichev.me>,
Alex Elder <elder@riscstar.com>,
netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, bpf@vger.kernel.org
Subject: Re: [PATCH] net: stmmac: Avoid freeing and re-requesting IRQ during XDP set prog
Date: Thu, 30 Jul 2026 15:35:09 +0200 [thread overview]
Message-ID: <ad3249e5-c607-4516-bf2e-63879e168272@lunn.ch> (raw)
In-Reply-To: <amtQjCV6Oi7UI97t@aspen.lan>
> After review I found that moving the disable to stmmac_xdp_release()
> does and removing the call the stmmac_init_chan() gets things most of
> the way there. After these changes every action in stmmac_xdp_release()
> can now be traced by to corresponding restore code in stmmac_xdp_open().
Great, thanks for finding time to look at this.
> It's not fully symmetric because activity in open does not appear in
> reverse order compared to release. However it definitely moves things
> in the right direction ....
We cannot expect stmmac to be fixed all at once, it has too many
issues. Maybe we can ask developers who need to touch some code to
spend a little bit of time to also do some fixup in that area. So we
slowly chip away at the problems.
Thanks
Andrew
next prev parent reply other threads:[~2026-07-30 13:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-06 16:17 [PATCH] net: stmmac: Avoid freeing and re-requesting IRQ during XDP set prog Daniel Thompson
2026-07-07 9:48 ` Daniel Thompson
2026-07-07 12:30 ` Andrew Lunn
2026-07-30 13:24 ` Daniel Thompson
2026-07-30 13:35 ` Andrew Lunn [this message]
2026-07-07 10:42 ` Maciej Fijalkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad3249e5-c607-4516-bf2e-63879e168272@lunn.ch \
--to=andrew@lunn.ch \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=daniel@riscstar.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=elder@riscstar.com \
--cc=hawk@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox