From: Florian Fainelli <f.fainelli@gmail.com>
To: Vivien Didelot <vivien.didelot@gmail.com>
Cc: netdev@vger.kernel.org, andrew@lunn.ch, davem@davemloft.net,
idosch@mellanox.com, jiri@mellanox.com,
ilias.apalodimas@linaro.org, ivan.khoronzhuk@linaro.org,
roopa@cumulusnetworks.com, nikolay@cumulusnetworks.com
Subject: Re: [PATCH net-next v2 07/12] net: dsa: Add ability to program multicast filter for CPU port
Date: Wed, 30 Jan 2019 14:55:53 -0800 [thread overview]
Message-ID: <ad59db87-4ad6-f51e-12c6-303cb5c2d807@gmail.com> (raw)
In-Reply-To: <20190130172859.GB3207@t480s.localdomain>
On 1/30/19 2:28 PM, Vivien Didelot wrote:
> Hi Florian,
>
> On Tue, 29 Jan 2019 16:55:43 -0800, Florian Fainelli <f.fainelli@gmail.com> wrote:
>
>> +static int dsa_slave_sync_unsync_mdb_addr(struct net_device *dev,
>> + const unsigned char *addr, bool add)
>> +{
>> + struct switchdev_obj_port_mdb mdb = {
>> + .obj = {
>> + .id = SWITCHDEV_OBJ_ID_HOST_MDB,
>> + .flags = SWITCHDEV_F_DEFER,
>> + },
>> + .vid = 0,
>> + };
>> + int ret = -EOPNOTSUPP;
>
> Assignment unneeded here.
>
>> +
>> + ether_addr_copy(mdb.addr, addr);
>> + if (add)
>> + ret = switchdev_port_obj_add(dev, &mdb.obj, NULL);
>> + else
>> + ret = switchdev_port_obj_del(dev, &mdb.obj);
>> +
>> + return ret;
>> +}
>> +
>> +static int dsa_slave_sync_mdb_addr(struct net_device *dev,
>> + const unsigned char *addr)
>> +{
>> + return dsa_slave_sync_unsync_mdb_addr(dev, addr, true);
>> +}
>> +
>> +static int dsa_slave_unsync_mdb_addr(struct net_device *dev,
>> + const unsigned char *addr)
>> +{
>> + return dsa_slave_sync_unsync_mdb_addr(dev, addr, false);
>> +}
>
> This wrapper isn't necessary IMO. I'd go with something like:
>
> static int dsa_slave_sync(struct net_device *dev, const unsigned char *addr)
> {
> struct switchdev_obj_port_mdb mdb = {
> .obj.id = SWITCHDEV_OBJ_ID_HOST_MDB,
> .obj.flags = SWITCHDEV_F_DEFER,
> };
>
> ether_addr_copy(mdb.addr, addr);
>
> return switchdev_port_obj_add(dev, &mdb.obj, NULL);
> }
>
> static int dsa_slave_unsync(struct net_device *dev, const unsigned char *addr)
> {
> struct switchdev_obj_port_mdb mdb = {
> .obj.id = SWITCHDEV_OBJ_ID_HOST_MDB,
> .obj.flags = SWITCHDEV_F_DEFER,
> };
>
> ether_addr_copy(mdb.addr, addr);
>
> return switchdev_port_obj_del(dev, &mdb.obj);
> }
>
> We may eventually wrap this cryptic netdevery in:
>
> static int dsa_slave_mc_sync(struct net_device *dev)
> {
> return __hw_addr_sync_dev(&dev->mc, dev, dsa_slave_sync, dsa_slave_unsync);
> }
>
> static void dsa_slave_mc_unsync(struct net_device *dev)
> {
> __hw_addr_unsync_dev(&dev->mc, dev, dsa_slave_sync);
> }
>
>> +
>> static int dsa_slave_open(struct net_device *dev)
>> {
>> struct net_device *master = dsa_slave_to_master(dev);
>> @@ -126,6 +159,8 @@ static int dsa_slave_close(struct net_device *dev)
>>
>> dev_mc_unsync(master, dev);
>> dev_uc_unsync(master, dev);
>> + __hw_addr_unsync_dev(&dev->mc, dev, dsa_slave_unsync_mdb_addr);
>> +
>> if (dev->flags & IFF_ALLMULTI)
>> dev_set_allmulti(master, -1);
>> if (dev->flags & IFF_PROMISC)
>> @@ -150,7 +185,17 @@ static void dsa_slave_change_rx_flags(struct net_device *dev, int change)
>> static void dsa_slave_set_rx_mode(struct net_device *dev)
>> {
>> struct net_device *master = dsa_slave_to_master(dev);
>> + struct dsa_port *dp = dsa_slave_to_port(dev);
>>
>> + /* If the port is bridged, the bridge takes care of sending
>> + * SWITCHDEV_OBJ_ID_HOST_MDB to program the host's MC filter
>> + */
>> + if (netdev_mc_empty(dev) || dp->bridge_dev)
>> + goto out;
>> +
>> + __hw_addr_sync_dev(&dev->mc, dev, dsa_slave_sync_mdb_addr,
>> + dsa_slave_unsync_mdb_addr);
>
> And check the returned error code.
All good points, I have now incorporated your suggestions, thanks!
--
Florian
next prev parent reply other threads:[~2019-01-30 22:56 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-30 0:55 [PATCH net-next v2 00/12] net: dsa: management mode for bcm_sf2 Florian Fainelli
2019-01-30 0:55 ` [PATCH net-next v2 01/12] net: bridge: multicast: Propagate br_mc_disabled_update() return Florian Fainelli
2019-01-30 7:36 ` Ido Schimmel
2019-01-31 1:00 ` Florian Fainelli
2019-01-31 7:50 ` Ido Schimmel
2019-02-01 1:19 ` Florian Fainelli
2019-02-02 15:47 ` Ido Schimmel
2019-02-11 19:05 ` Florian Fainelli
2019-01-30 0:55 ` [PATCH net-next v2 02/12] net: dsa: b53: Fix default VLAN ID Florian Fainelli
2019-01-30 0:55 ` [PATCH net-next v2 03/12] net: dsa: b53: Properly account for VLAN filtering Florian Fainelli
2019-01-30 0:55 ` [PATCH net-next v2 04/12] net: systemport: Fix reception of BPDUs Florian Fainelli
2019-01-30 0:55 ` [PATCH net-next v2 05/12] net: dsa: b53: Define registers for IGMP snooping Florian Fainelli
2019-01-30 0:55 ` [PATCH net-next v2 06/12] net: dsa: b53: Add support for MDB Florian Fainelli
2019-01-30 0:55 ` [PATCH net-next v2 07/12] net: dsa: Add ability to program multicast filter for CPU port Florian Fainelli
2019-01-30 22:28 ` Vivien Didelot
2019-01-30 22:55 ` Florian Fainelli [this message]
2019-01-30 0:55 ` [PATCH net-next v2 08/12] net: dsa: Add ndo_vlan_rx_{add,kill}_vid implementation Florian Fainelli
2019-01-30 22:38 ` Vivien Didelot
2019-01-30 0:55 ` [PATCH net-next v2 09/12] net: dsa: Make VLAN filtering use DSA notifiers Florian Fainelli
2019-01-30 0:55 ` [PATCH net-next v2 10/12] net: dsa: Wire up multicast IGMP snooping attribute notification Florian Fainelli
2019-01-30 16:06 ` Andrew Lunn
2019-01-30 22:32 ` Florian Fainelli
2019-01-30 22:46 ` Andrew Lunn
2019-01-30 23:02 ` Florian Fainelli
2019-01-30 0:55 ` [PATCH net-next v2 11/12] net: dsa: b53: Add support for toggling IGMP snooping Florian Fainelli
2019-01-30 0:55 ` [PATCH net-next v2 12/12] net: dsa: bcm_sf2: Enable management mode Florian Fainelli
2019-01-30 7:38 ` [PATCH net-next v2 00/12] net: dsa: management mode for bcm_sf2 Ido Schimmel
2019-01-30 22:23 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad59db87-4ad6-f51e-12c6-303cb5c2d807@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=idosch@mellanox.com \
--cc=ilias.apalodimas@linaro.org \
--cc=ivan.khoronzhuk@linaro.org \
--cc=jiri@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=roopa@cumulusnetworks.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).