From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CD53C282D8 for ; Wed, 30 Jan 2019 22:56:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 26315218D2 for ; Wed, 30 Jan 2019 22:56:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lwnX6epg" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732127AbfA3W4E (ORCPT ); Wed, 30 Jan 2019 17:56:04 -0500 Received: from mail-yb1-f194.google.com ([209.85.219.194]:40707 "EHLO mail-yb1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726802AbfA3W4E (ORCPT ); Wed, 30 Jan 2019 17:56:04 -0500 Received: by mail-yb1-f194.google.com with SMTP id y13so536771ybr.7 for ; Wed, 30 Jan 2019 14:56:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=qoBwVOrkh5G1Fvtvf4aB7bIHyHUQj/lkhFLkV81mSWs=; b=lwnX6epgQJrt/6TzDRFfYFo0eL61Df+iSPVc2K0UO9btKgMkzWciCbHOFpQzxePmsK L65N0YRYJWaXparN8p3djn2PV/5RiBHo6hQV1G4SgZyO1gfB1zWgsDP/O/EosuiZQVJf fLy3bEPJdXf1B7KeM5Pq0z3qS0b5vRuBl3tZ42OCKUcnPst1OQo81Wu42gLTutqQn0nq 0/scgEf3f7ShOfCw4oPQAwQ/XrtNzyUvn1zCCyuJFwalw6DDhncItRfbFFaUqbItlqJT XDInQuo4/e32XAxrJ7LtZj0Jjg7HKAYeKzjICRUnHlutUFZm87N8kWQAKLTnH46pkRE9 rgPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=qoBwVOrkh5G1Fvtvf4aB7bIHyHUQj/lkhFLkV81mSWs=; b=JxdxGhe3RaM9+gbtEKphvh4XDe9bXOu1V/jlG9TYgme8WUboOt2hpseHCqejeNWsDn kwyGzE31C4KITMWEb2mUsljdVaoZmRcp500Fp+t32ff0xohWgCktHHxH7T61CnquDKnO nCijjBN0QM+B2OcyCvJk3EE6H12hMKMbnKyfqvhQg+2ybtKbZjym+G4X0As+lw2GYdEX wOwEvehEhI+cpQyw3DvsIJgXMdwnMky9uvRLoyzChHM8QR0YBiqqSWHhRSgKSxCSmVHE PBgt7//NBW2AnIBTCWpP9U70dE2UGsd3K/6+v5eVcbHA8LgATcHKLhui8Rps4cDeFdcg D+6Q== X-Gm-Message-State: AJcUukdWn3YOLgxCDWhm95rpw4G5OXcQcCo2bpzmYpZABOLfDV66yYf9 8nbVO6U2LB8oFuM1gpzll527iicx X-Google-Smtp-Source: ALg8bN7YKPsxQCkKn5GCrOAoeekyKfOuXIEpNREimomgp2uBCTxstqFxAyQ0KwuVUa30WijOH89SeA== X-Received: by 2002:a25:9d87:: with SMTP id v7mr30726931ybp.388.1548888962382; Wed, 30 Jan 2019 14:56:02 -0800 (PST) Received: from [10.67.48.225] ([192.19.223.250]) by smtp.googlemail.com with ESMTPSA id w1sm949567ywd.49.2019.01.30.14.56.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 30 Jan 2019 14:56:01 -0800 (PST) Subject: Re: [PATCH net-next v2 07/12] net: dsa: Add ability to program multicast filter for CPU port To: Vivien Didelot Cc: netdev@vger.kernel.org, andrew@lunn.ch, davem@davemloft.net, idosch@mellanox.com, jiri@mellanox.com, ilias.apalodimas@linaro.org, ivan.khoronzhuk@linaro.org, roopa@cumulusnetworks.com, nikolay@cumulusnetworks.com References: <20190130005548.2212-1-f.fainelli@gmail.com> <20190130005548.2212-8-f.fainelli@gmail.com> <20190130172859.GB3207@t480s.localdomain> From: Florian Fainelli Openpgp: preference=signencrypt Autocrypt: addr=f.fainelli@gmail.com; prefer-encrypt=mutual; keydata= mQGiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz7QnRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+iGYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSC5BA0ESM+4EhAQAL/o09boR9D3Vk1Tt7+gpYr3 WQ6hgYVON905q2ndEoA2J0dQxJNRw3snabHDDzQBAcqOvdi7YidfBVdKi0wxHhSuRBfuOppu pdXkb7zxuPQuSveCLqqZWRQ+Cc2QgF7SBqgznbe6Ngout5qXY5Dcagk9LqFNGhJQzUGHAsIs hap1f0B1PoUyUNeEInV98D8Xd/edM3mhO9nRpUXRK9Bvt4iEZUXGuVtZLT52nK6Wv2EZ1TiT OiqZlf1P+vxYLBx9eKmabPdm3yjalhY8yr1S1vL0gSA/C6W1o/TowdieF1rWN/MYHlkpyj9c Rpc281gAO0AP3V1G00YzBEdYyi0gaJbCEQnq8Vz1vDXFxHzyhgGz7umBsVKmYwZgA8DrrB0M oaP35wuGR3RJcaG30AnJpEDkBYHznI2apxdcuTPOHZyEilIRrBGzDwGtAhldzlBoBwE3Z3MY 31TOpACu1ZpNOMysZ6xiE35pWkwc0KYm4hJA5GFfmWSN6DniimW3pmdDIiw4Ifcx8b3mFrRO BbDIW13E51j9RjbO/nAaK9ndZ5LRO1B/8Fwat7bLzmsCiEXOJY7NNpIEpkoNoEUfCcZwmLrU +eOTPzaF6drw6ayewEi5yzPg3TAT6FV3oBsNg3xlwU0gPK3v6gYPX5w9+ovPZ1/qqNfOrbsE FRuiSVsZQ5s3AAMFD/9XjlnnVDh9GX/r/6hjmr4U9tEsM+VQXaVXqZuHKaSmojOLUCP/YVQo 7IiYaNssCS4FCPe4yrL4FJJfJAsbeyDykMN7wAnBcOkbZ9BPJPNCbqU6dowLOiy8AuTYQ48m vIyQ4Ijnb6GTrtxIUDQeOBNuQC/gyyx3nbL/lVlHbxr4tb6YkhkO6shjXhQh7nQb33FjGO4P WU11Nr9i/qoV8QCo12MQEo244RRA6VMud06y/E449rWZFSTwGqb0FS0seTcYNvxt8PB2izX+ HZA8SL54j479ubxhfuoTu5nXdtFYFj5Lj5x34LKPx7MpgAmj0H7SDhpFWF2FzcC1bjiW9mjW HaKaX23Awt97AqQZXegbfkJwX2Y53ufq8Np3e1542lh3/mpiGSilCsaTahEGrHK+lIusl6mz Joil+u3k01ofvJMK0ZdzGUZ/aPMZ16LofjFA+MNxWrZFrkYmiGdv+LG45zSlZyIvzSiG2lKy kuVag+IijCIom78P9jRtB1q1Q5lwZp2TLAJlz92DmFwBg1hyFzwDADjZ2nrDxKUiybXIgZp9 aU2d++ptEGCVJOfEW4qpWCCLPbOT7XBr+g/4H3qWbs3j/cDDq7LuVYIe+wchy/iXEJaQVeTC y5arMQorqTFWlEOgRA8OP47L9knl9i4xuR0euV6DChDrguup2aJVU4hPBBgRAgAPAhsMBQJU X9LxBQkeXB3fAAoJEGFXmRW1Y3YOj4UAn3nrFLPZekMeqX5aD/aq/dsbXSfyAKC45Go0YyxV HGuUuzv+GKZ6nsysJ7kCDQRXG8fwARAA6q/pqBi5PjHcOAUgk2/2LR5LjjesK50bCaD4JuNc YDhFR7Vs108diBtsho3w8WRd9viOqDrhLJTroVckkk74OY8r+3t1E0Dd4wHWHQZsAeUvOwDM PQMqTUBFuMi6ydzTZpFA2wBR9x6ofl8Ax+zaGBcFrRlQnhsuXLnM1uuvS39+pmzIjasZBP2H UPk5ifigXcpelKmj6iskP3c8QN6x6GjUSmYx+xUfs/GNVSU1XOZn61wgPDbgINJd/THGdqiO iJxCLuTMqlSsmh1+E1dSdfYkCb93R/0ZHvMKWlAx7MnaFgBfsG8FqNtZu3PCLfizyVYYjXbV WO1A23riZKqwrSJAATo5iTS65BuYxrFsFNPrf7TitM8E76BEBZk0OZBvZxMuOs6Z1qI8YKVK UrHVGFq3NbuPWCdRul9SX3VfOunr9Gv0GABnJ0ET+K7nspax0xqq7zgnM71QEaiaH17IFYGS sG34V7Wo3vyQzsk7qLf9Ajno0DhJ+VX43g8+AjxOMNVrGCt9RNXSBVpyv2AMTlWCdJ5KI6V4 KEzWM4HJm7QlNKE6RPoBxJVbSQLPd9St3h7mxLcne4l7NK9eNgNnneT7QZL8fL//s9K8Ns1W t60uQNYvbhKDG7+/yLcmJgjF74XkGvxCmTA1rW2bsUriM533nG9gAOUFQjURkwI8jvMAEQEA AYkCaAQYEQIACQUCVxvH8AIbAgIpCRBhV5kVtWN2DsFdIAQZAQIABgUCVxvH8AAKCRCH0Jac RAcHBIkHD/9nmfog7X2ZXMzL9ktT++7x+W/QBrSTCTmq8PK+69+INN1ZDOrY8uz6htfTLV9+ e2W6G8/7zIvODuHk7r+yQ585XbplgP0V5Xc8iBHdBgXbqnY5zBrcH+Q/oQ2STalEvaGHqNoD UGyLQ/fiKoLZTPMur57Fy1c9rTuKiSdMgnT0FPfWVDfpR2Ds0gpqWePlRuRGOoCln5GnREA/ 2MW2rWf+CO9kbIR+66j8b4RUJqIK3dWn9xbENh/aqxfonGTCZQ2zC4sLd25DQA4w1itPo+f5 V/SQxuhnlQkTOCdJ7b/mby/pNRz1lsLkjnXueLILj7gNjwTabZXYtL16z24qkDTI1x3g98R/ xunb3/fQwR8FY5/zRvXJq5us/nLvIvOmVwZFkwXc+AF+LSIajqQz9XbXeIP/BDjlBNXRZNdo dVuSU51ENcMcilPr2EUnqEAqeczsCGpnvRCLfVQeSZr2L9N4svNhhfPOEscYhhpHTh0VPyxI pPBNKq+byuYPMyk3nj814NKhImK0O4gTyCK9b+gZAVvQcYAXvSouCnTZeJRrNHJFTgTgu6E0 caxTGgc5zzQHeX67eMzrGomG3ZnIxmd1sAbgvJUDaD2GrYlulfwGWwWyTNbWRvMighVdPkSF 6XFgQaosWxkV0OELLy2N485YrTr2Uq64VKyxpncLh50e2RnyAJ9Za0Dx0yyp44iD1OvHtkEI M5kY0ACeNhCZJvZ5g4C2Lc9fcTHu8jxmEkI= Message-ID: Date: Wed, 30 Jan 2019 14:55:53 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190130172859.GB3207@t480s.localdomain> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 1/30/19 2:28 PM, Vivien Didelot wrote: > Hi Florian, > > On Tue, 29 Jan 2019 16:55:43 -0800, Florian Fainelli wrote: > >> +static int dsa_slave_sync_unsync_mdb_addr(struct net_device *dev, >> + const unsigned char *addr, bool add) >> +{ >> + struct switchdev_obj_port_mdb mdb = { >> + .obj = { >> + .id = SWITCHDEV_OBJ_ID_HOST_MDB, >> + .flags = SWITCHDEV_F_DEFER, >> + }, >> + .vid = 0, >> + }; >> + int ret = -EOPNOTSUPP; > > Assignment unneeded here. > >> + >> + ether_addr_copy(mdb.addr, addr); >> + if (add) >> + ret = switchdev_port_obj_add(dev, &mdb.obj, NULL); >> + else >> + ret = switchdev_port_obj_del(dev, &mdb.obj); >> + >> + return ret; >> +} >> + >> +static int dsa_slave_sync_mdb_addr(struct net_device *dev, >> + const unsigned char *addr) >> +{ >> + return dsa_slave_sync_unsync_mdb_addr(dev, addr, true); >> +} >> + >> +static int dsa_slave_unsync_mdb_addr(struct net_device *dev, >> + const unsigned char *addr) >> +{ >> + return dsa_slave_sync_unsync_mdb_addr(dev, addr, false); >> +} > > This wrapper isn't necessary IMO. I'd go with something like: > > static int dsa_slave_sync(struct net_device *dev, const unsigned char *addr) > { > struct switchdev_obj_port_mdb mdb = { > .obj.id = SWITCHDEV_OBJ_ID_HOST_MDB, > .obj.flags = SWITCHDEV_F_DEFER, > }; > > ether_addr_copy(mdb.addr, addr); > > return switchdev_port_obj_add(dev, &mdb.obj, NULL); > } > > static int dsa_slave_unsync(struct net_device *dev, const unsigned char *addr) > { > struct switchdev_obj_port_mdb mdb = { > .obj.id = SWITCHDEV_OBJ_ID_HOST_MDB, > .obj.flags = SWITCHDEV_F_DEFER, > }; > > ether_addr_copy(mdb.addr, addr); > > return switchdev_port_obj_del(dev, &mdb.obj); > } > > We may eventually wrap this cryptic netdevery in: > > static int dsa_slave_mc_sync(struct net_device *dev) > { > return __hw_addr_sync_dev(&dev->mc, dev, dsa_slave_sync, dsa_slave_unsync); > } > > static void dsa_slave_mc_unsync(struct net_device *dev) > { > __hw_addr_unsync_dev(&dev->mc, dev, dsa_slave_sync); > } > >> + >> static int dsa_slave_open(struct net_device *dev) >> { >> struct net_device *master = dsa_slave_to_master(dev); >> @@ -126,6 +159,8 @@ static int dsa_slave_close(struct net_device *dev) >> >> dev_mc_unsync(master, dev); >> dev_uc_unsync(master, dev); >> + __hw_addr_unsync_dev(&dev->mc, dev, dsa_slave_unsync_mdb_addr); >> + >> if (dev->flags & IFF_ALLMULTI) >> dev_set_allmulti(master, -1); >> if (dev->flags & IFF_PROMISC) >> @@ -150,7 +185,17 @@ static void dsa_slave_change_rx_flags(struct net_device *dev, int change) >> static void dsa_slave_set_rx_mode(struct net_device *dev) >> { >> struct net_device *master = dsa_slave_to_master(dev); >> + struct dsa_port *dp = dsa_slave_to_port(dev); >> >> + /* If the port is bridged, the bridge takes care of sending >> + * SWITCHDEV_OBJ_ID_HOST_MDB to program the host's MC filter >> + */ >> + if (netdev_mc_empty(dev) || dp->bridge_dev) >> + goto out; >> + >> + __hw_addr_sync_dev(&dev->mc, dev, dsa_slave_sync_mdb_addr, >> + dsa_slave_unsync_mdb_addr); > > And check the returned error code. All good points, I have now incorporated your suggestions, thanks! -- Florian