netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ahmed Abdelsalam <ahabdels@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
	Jonathan Corbet <corbet@lwn.net>,
	netdev@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org, andrea.mayer@uniroma2.it
Subject: Re: [net-next v5 2/2] seg6: Add documentation for seg6_inherit_inner_ipv4_dscp sysctl
Date: Tue, 25 Aug 2020 18:01:01 +0200	[thread overview]
Message-ID: <ad5dfe4a-da8e-aed2-4a32-cd617ad795b2@gmail.com> (raw)
In-Reply-To: <20200825085127.50ba9c82@kicinski-fedora-PC1C0HJN>



On 25/08/2020 17:51, Jakub Kicinski wrote:
> On Tue, 25 Aug 2020 12:18:44 +0000 Ahmed Abdelsalam wrote:
>> +	Enable the SRv6 encapsulation to inherit the DSCP value of the inner IPv4 packet.
>> +
>> +	Default: FALSE (Do not inherit DSCP)
>> +
>>   ``conf/default/*``:
>>   	Change the interface-specific default settings.
>>   
> 
> Checkpatch complains about whitespace:
> 
> ERROR: trailing whitespace
> #24: FILE: Documentation/networking/ip-sysctl.rst:1802:
> +seg6_inherit_inner_ipv4_dscp - BOOLEAN                                                                                                                                                                                                                                                                                                        $
> 
sorry forgot to run checkpatch on this one before sending.

patch fixed and resent.

  reply	other threads:[~2020-08-25 16:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-25 12:18 [net-next v5 2/2] seg6: Add documentation for seg6_inherit_inner_ipv4_dscp sysctl Ahmed Abdelsalam
2020-08-25 15:51 ` Jakub Kicinski
2020-08-25 16:01   ` Ahmed Abdelsalam [this message]
2020-08-25 16:23     ` David Miller
  -- strict thread matches above, loose matches on Subject: below --
2020-08-25 15:58 Ahmed Abdelsalam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ad5dfe4a-da8e-aed2-4a32-cd617ad795b2@gmail.com \
    --to=ahabdels@gmail.com \
    --cc=andrea.mayer@uniroma2.it \
    --cc=corbet@lwn.net \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).