From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shannon Nelson Subject: Re: [PATCH v3 net-next 4/9] sunvnet: add driver stats for ethtool support Date: Mon, 13 Feb 2017 09:15:17 -0800 Message-ID: References: <1486748305-240339-1-git-send-email-shannon.nelson@oracle.com> <1486748305-240339-5-git-send-email-shannon.nelson@oracle.com> <20170210162208.69485824@xeon-e3> <20170211.210101.1450332574457722492.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org To: David Miller , stephen@networkplumber.org Return-path: In-Reply-To: <20170211.210101.1450332574457722492.davem@davemloft.net> Sender: sparclinux-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 2/11/2017 6:01 PM, David Miller wrote: > From: Stephen Hemminger > Date: Fri, 10 Feb 2017 16:22:08 -0800 > >> On Fri, 10 Feb 2017 09:38:20 -0800 >> Shannon Nelson wrote: >> >>> +static void vsw_get_ethtool_stats(struct net_device *dev, >>> + struct ethtool_stats *estats, u64 *data) >>> +{ >>> + int i = 0; >>> + >>> + data[i++] = dev->stats.rx_packets; >>> + data[i++] = dev->stats.tx_packets; >>> + data[i++] = dev->stats.rx_bytes; >>> + data[i++] = dev->stats.tx_bytes; >>> + data[i++] = dev->stats.rx_errors; >>> + data[i++] = dev->stats.tx_errors; >>> + data[i++] = dev->stats.rx_dropped; >>> + data[i++] = dev->stats.tx_dropped; >>> + data[i++] = dev->stats.multicast; >> >> Please do not duplicate regular network statistics into ethtool. >> This doesn't really add any value. > > Agreed. > Okay, I'll drop this patch. sln