From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.netfilter.org (mail.netfilter.org [217.70.190.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A60F53D5656; Fri, 3 Apr 2026 21:02:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.190.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775250122; cv=none; b=EL+z8SaStZauvA6u/vp2Ryrxkw1ff4u4TT9e9bsslSp1ob0lP29G+3vlsC5Cx4lnKCqfxGLqD/LHuevo8ECWyiWdXQ7C9IuL+wU3dHCYYyJKWzNZVoPjwNkMsamwxD8LNuPghpTiruz4uOz4AxV+WsxAlP3bs04GLNUJ1Pc1wmw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775250122; c=relaxed/simple; bh=OiLcugNzhOcn3+ZqTqNHyFc+1w+Of5vLCmgFDm/2EwQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rpTug87Wa+viwaWm6eYNSMcVxeulCfOU7dx9fcjIwWDMS+s82xRGKhi0LSeYJ9lmfJapkei6kg3ixivUh0WfJVtzfr2JJxHw85C5NhXW6TPPi/gM7eujeDM1owuhkRlIl9egT4iqZrTtTmleoy1Rm+60Hv+i9wwsN+CghUyooB8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=netfilter.org; spf=pass smtp.mailfrom=netfilter.org; dkim=pass (2048-bit key) header.d=netfilter.org header.i=@netfilter.org header.b=Ra07SwbT; arc=none smtp.client-ip=217.70.190.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=netfilter.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=netfilter.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=netfilter.org header.i=@netfilter.org header.b="Ra07SwbT" Received: from netfilter.org (mail-agni [217.70.190.124]) by mail.netfilter.org (Postfix) with UTF8SMTPSA id 5489E60251; Fri, 3 Apr 2026 23:01:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netfilter.org; s=2025; t=1775250118; bh=Bik4T78PiVQ6FVf5qYxp+z3Qx6Y8fK8iKEYDKmRuU0M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ra07SwbTcDgF/6SfYn5ARiLngAbIomIrg2hBExbZ4dCq4Uzicc6O/8/uNSC7Iggt1 n/Bhk9YW76SH8Y/u7OgT4cef50decbZTX9TPO8Ip9VcpUW6kD5/06c68CIjpyHiQjx 0Rzn4YRuCIAyxI6QV21u4ESbR5KXvQEIYMe8nNN0LmkPlIEYwcPK+BWaea0NycR0WE Ggn3COvQnDjF0M884nJwJwp9zhBGadJEpGeDyAC+P5M7+x+W6/tWwHHvcSFd9UIliO uKpJNByxgjBQHUDZINiLt+vCCSQfe/kZYccGXqKztkpoZjXhriGNEdLs6uEh7FtwUC 5r/bXzaV0pQwQ== Date: Fri, 3 Apr 2026 23:01:55 +0200 From: Pablo Neira Ayuso To: Marino Dzalto Cc: fw@strlen.de, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] netfilter: xt_HL: add pr_fmt, default case and NULL checks Message-ID: References: <20260403193929.89449-1-marino.dzalto@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260403193929.89449-1-marino.dzalto@gmail.com> On Fri, Apr 03, 2026 at 09:39:29PM +0200, Marino Dzalto wrote: > diff --git a/net/netfilter/xt_hl.c b/net/netfilter/xt_hl.c > index c1a70f8f0..9434d5ca8 100644 > --- a/net/netfilter/xt_hl.c > +++ b/net/netfilter/xt_hl.c [...] > static bool hl_mt6(const struct sk_buff *skb, struct xt_action_param *par) > { > const struct ip6t_hl_info *info = par->matchinfo; > - const struct ipv6hdr *ip6h = ipv6_hdr(skb); > + const struct ipv6hdr *ip6h; > + > + if (!skb) > + return false; No skb !? This codebase is frozen, I don't see any benefit in this update.