From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11F7B32695F for ; Mon, 6 Apr 2026 18:37:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775500637; cv=none; b=sGN8xiVWywmt392hKH1AUOeUqS/9RVsl/txnsOVoeYkyBNFmgYXjbVm1EFJTgkpB5UBciAGj2pfFMdUiduuliIbL9shSLWJ5AJfxomiZ/YEdOA5SGbQP4Y1nWPJ87lSOm33y9O8RTD+2vxJEKkp6W9k+bvvPNGsCjeszOsVpC2I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775500637; c=relaxed/simple; bh=CP12LEi5xWikBKv139k1WmbpUqAApCKC/R78cqzPPLY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UVIvNe6yxxSsXH6KHgbMw+RmfyCUyeTdLU1pSEXZmcfmeSbABNlcwFpI3gHpvnzoJmNt94vyqQp1W8rAYoA7RqTKA1q4ae4JHTr+fy8S80M4Oo2u7oZSlOTeQt2ACKYa9VU3+ucPyybBfJaePTqCS8iLGJRCEum9eBFVK9Ap1q0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to; spf=none smtp.mailfrom=dama.to; dkim=pass (2048-bit key) header.d=dama-to.20251104.gappssmtp.com header.i=@dama-to.20251104.gappssmtp.com header.b=c+wwKQ9t; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=dama.to Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=dama-to.20251104.gappssmtp.com header.i=@dama-to.20251104.gappssmtp.com header.b="c+wwKQ9t" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-354bc7c2c46so2518681a91.0 for ; Mon, 06 Apr 2026 11:37:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dama-to.20251104.gappssmtp.com; s=20251104; t=1775500635; x=1776105435; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=KzoMkeGQjHqq5m5NUQcYMb2CsDvxm3DrHbtl/8KcFh8=; b=c+wwKQ9tI3hqYicFLui9G/kJDHKCN91dlAa2DRP8CORBmpDqyeCQu6PiVzBSRP6Wys RY2KnO4lS05cubdBuIU1kEsA/8rsO2Ft74mddjcMF/mwb1zOQ8Wg9vw+bl+vb7SbfXEd RiiclPV9y/klQIyhav6e9P4TqJMMhwltLGtc+XBa1kYBvCqTxa1rMBj01awUw+Gb/bd0 BYyyrqFK9pkjNitJJiRw8W7orV4qveL2Ao+3f0tB5EkRI0P6BKf048k19NFky9mgpMTq 9d2+St15L4hx31TbUQqBOkXdAcjnk5uEF1xVUk+CpMsX8KUb5EFADGj3XyyuatNZFikz ohZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775500635; x=1776105435; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KzoMkeGQjHqq5m5NUQcYMb2CsDvxm3DrHbtl/8KcFh8=; b=L+VxuiyzajiAahbZSEsvVjhJ2TwVZIvPwo7i4q+QW5RWOsi/aHeOkyHPoqssLRChGK 0m5kRo40YbEQ1/UtGlo/DBidNvEqQh1EmmdDbYUzyuirJ7Cg06NlAAEsY5/+dFsx28yK /whlrgJeCalM31VHMx7JetMHgBR9W8pQBV/pILJkltxI5NOxsAJ0pQo+/AI8cIaGc+EG 2fXlHONXHiXPUz+witBC+4c1a9ZcNowom8mwioM7uQlQ9EIA18hytCax3mjuDvXTn+c1 9OHueymv1WIB9BS9QEOdK+ZvmBFA0yDb4oL7YrtZ8AnaX4osX4rbPogo80x7rHVIaum/ AF2w== X-Forwarded-Encrypted: i=1; AJvYcCUZK/sV0oeFWau+o4hk0c92iNY4wLiMtIFPh6ABu/rUX8nQpTdG2cq7cRRhs65ad4ycAtvg3H8=@vger.kernel.org X-Gm-Message-State: AOJu0Yxn1JR0zkv3gIsSWdZUiIaJm2GYHAJT7qAn5vDZObTv/Nja68CF VPbQv8c85LPAacJ43LC+On/jVsOMUfU5gDcL69u7e1Y0dLDya2uIxtLZgabGAX7ihPc= X-Gm-Gg: AeBDietxw3+NTFvpZEVXtQic4rhC4D66MxvpHe+Edkf458ruYYksFFrywZU7mqVGNjD y5L1XlJ9z3C/CJXQBOcfhl4DHf087Es12GNEHDkyxGhiLAgtgTFnLoCj78JMy+VkBKS6JoaJ41v jZGClpXXILEk0DiiN4p2WdDJEz6Hd+ZXwcGowKlLRmBpU8thU5l9UtVbzoBn+ziobJg383B7xVg G8bB6p88n0JcGGidSM/S+dzoL0b1woZkq33hhvWxJNcfScSD0BTL+vBXEL8sQwrXTpyIatU1eP4 Gnjm0LU6v7JL71x4m2R4XTlAODvoifeGBujAbKWTXrRjITLjOpBc116IjvX2lKH2c1L6uCO5hdK Xi8ME6AHwPnx3D0cn/4XNIho+wSKd1bumd4Kl+4EVeXFOQBE+7jGZa+gMXovQOHNYBrPKOH0EJL vR0c8i4kMyrPOSIOQ= X-Received: by 2002:a17:902:e748:b0:2b0:571f:6f09 with SMTP id d9443c01a7336-2b2818934camr150347155ad.44.1775500635409; Mon, 06 Apr 2026 11:37:15 -0700 (PDT) Received: from localhost ([2a03:2880:2ff:46::]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b27479d0fbsm191461085ad.35.2026.04.06.11.37.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Apr 2026 11:37:15 -0700 (PDT) Date: Mon, 6 Apr 2026 11:37:14 -0700 From: Joe Damato To: Eric Dumazet Cc: "David S . Miller" , Jakub Kicinski , Paolo Abeni , Simon Horman , Andrew Lunn , netdev@vger.kernel.org, eric.dumazet@gmail.com Subject: Re: [PATCH net-next 1/2] net: qdisc_pkt_len_segs_init() cleanup Message-ID: Mail-Followup-To: Joe Damato , Eric Dumazet , "David S . Miller" , Jakub Kicinski , Paolo Abeni , Simon Horman , Andrew Lunn , netdev@vger.kernel.org, eric.dumazet@gmail.com References: <20260403221540.3297753-1-edumazet@google.com> <20260403221540.3297753-2-edumazet@google.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260403221540.3297753-2-edumazet@google.com> On Fri, Apr 03, 2026 at 10:15:39PM +0000, Eric Dumazet wrote: > Reduce indentation level by returning early if the transport header > was not set. > > Add an unlikely() clause as this is not the common case. > > No functional change. > > Signed-off-by: Eric Dumazet > --- > net/core/dev.c | 62 +++++++++++++++++++++++++------------------------- > 1 file changed, 31 insertions(+), 31 deletions(-) Reviewed-by: Joe Damato