From: Charles Perry <charles.perry@microchip.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Charles Perry <charles.perry@microchip.com>,
<netdev@vger.kernel.org>, Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
"Florian Fainelli" <florian.fainelli@broadcom.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next] net: phy: fix a return path in get_phy_c45_ids()
Date: Wed, 8 Apr 2026 07:48:55 -0700 [thread overview]
Message-ID: <adZq1++hD2mcTDum@bby-cbu-swbuild03.eng.microchip.com> (raw)
In-Reply-To: <bcc4943d-137f-46d0-b5fd-385577c1259e@lunn.ch>
On Wed, Apr 08, 2026 at 03:48:22PM +0200, Andrew Lunn wrote:
> On Wed, Apr 08, 2026 at 06:31:44AM -0700, Charles Perry wrote:
> > The return value of phy_c45_probe_present() is store in "ret", not
> > "phy_reg", fix this. "phy_reg" always has a positive value if we reach
> > this return path (since it would have returned earlier otherwise), which
> > means that the original goal of the patch of not considering -ENODEV
> > fatal wasn't achieved.
> >
> > Fixes: 17b447539408 ("net: phy: c45 scanning: Don't consider -ENODEV fatal")
> > Signed-off-by: Charles Perry <charles.perry@microchip.com>
>
> Thanks for fixing this.
>
> The Subject line should be [PATCH net] since this is a Fix.
Ok, I'll resend this with the proper patch prefix.
Thanks,
Charles
>
> Otherwise:
>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
>
> Andrew
prev parent reply other threads:[~2026-04-08 14:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-08 13:31 [PATCH net-next] net: phy: fix a return path in get_phy_c45_ids() Charles Perry
2026-04-08 13:48 ` Andrew Lunn
2026-04-08 14:48 ` Charles Perry [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adZq1++hD2mcTDum@bby-cbu-swbuild03.eng.microchip.com \
--to=charles.perry@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=florian.fainelli@broadcom.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox