From: Roland Dreier <rdreier@cisco.com>
To: ggrundstrom@neteffect.com
Cc: ewg@lists.openfabrics.org, general@lists.openfabrics.org,
netdev@vger.kernel.org
Subject: Re: [PATCH 10/14 v2] nes: eeprom and phy routines
Date: Wed, 31 Oct 2007 13:26:29 -0700 [thread overview]
Message-ID: <ada1wbbghe2.fsf@cisco.com> (raw)
In-Reply-To: <200710192021.l9JKLGFU021817@neteffect.com> (ggrundstrom@neteffect.com's message of "Fri, 19 Oct 2007 15:21:16 -0500")
> + /* TODO: deal with EEPROM endian issues */
This is pretty scary. Is the driver broken on big-endian systems now?
> +/*
> +"Everything you wanted to know about CRC algorithms, but were afraid to ask
> + for fear that errors in your understanding might be detected." Version : 3.
etc etc... can all this be replaced with what's in lib/crc32.c? (I
hope so)
- R.
next prev parent reply other threads:[~2007-10-31 20:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-19 20:21 [PATCH 10/14 v2] nes: eeprom and phy routines ggrundstrom
2007-10-31 20:26 ` Roland Dreier [this message]
2007-10-31 21:47 ` Glenn Grundstrom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ada1wbbghe2.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=ewg@lists.openfabrics.org \
--cc=general@lists.openfabrics.org \
--cc=ggrundstrom@neteffect.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).