From: Roland Dreier <rdreier@cisco.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, aluno3@poczta.onet.pl,
herbert@gondor.apana.org.au, general@lists.openfabrics.org
Subject: Re: [ofa-general] NetEffect, iw_nes and kernel warning
Date: Fri, 30 Jan 2009 19:54:12 -0800 [thread overview]
Message-ID: <ada3af0qgez.fsf@cisco.com> (raw)
In-Reply-To: <20090130.135107.116108989.davem@davemloft.net> (David Miller's message of "Fri, 30 Jan 2009 13:51:07 -0800 (PST)")
> > I don't believe this is accurate. Calling skb_linearize() (on a kernel
> > with CONFIG_HIGHMEM set) can end up calling local_bh_enable() in
> > kunmap_skb_frag(), which can obviously cause problems if the initial
> > context relies on having BHs disabled (as hard_start_xmit does).
> local_bh_{enable,disable}() nests, so this is not a problem
Duh. OK, then the only bugs seem to be that iw_nes does skb_linearize
with irqs off (due to being an LLTX driver), and mv643xx_eth leaks an
skb on its error path if skb_linearize fails.
- R.
next prev parent reply other threads:[~2009-01-31 3:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <497EF9AC.70104@poczta.onet.pl>
2009-01-27 23:53 ` [ofa-general] NetEffect, iw_nes and kernel warning Roland Dreier
2009-01-28 0:07 ` David Miller
2009-01-28 0:17 ` Stephen Hemminger
2009-01-28 16:36 ` Tung, Chien Tin
2009-01-28 18:05 ` Roland Dreier
2009-01-28 19:05 ` Stephen Hemminger
2009-01-28 21:52 ` Roland Dreier
2009-01-30 6:57 ` Herbert Xu
2009-01-30 8:22 ` Eilon Greenstein
2009-01-30 16:25 ` Stephen Hemminger
2009-01-30 17:35 ` Roland Dreier
2009-01-30 21:51 ` David Miller
2009-01-31 3:54 ` Roland Dreier [this message]
2009-04-21 9:09 ` Lennert Buytenhek
2009-04-21 12:49 ` Herbert Xu
2009-04-21 12:50 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ada3af0qgez.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=aluno3@poczta.onet.pl \
--cc=davem@davemloft.net \
--cc=general@lists.openfabrics.org \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).