From: Roland Dreier <rdreier@cisco.com>
To: Yi Zou <yi.zou@intel.com>
Cc: netdev@vger.kernel.org, devel@open-fcoe.org
Subject: Re: [PATCH 1/2] net: add ETH_P_FCOE for Fibre Channel over Ethernet (FCoE)
Date: Mon, 06 Oct 2008 15:33:37 -0700 [thread overview]
Message-ID: <ada3aj9pd4u.fsf@cisco.com> (raw)
In-Reply-To: <20081006220920.3308.18862.stgit@zyfc9ini.jf.intel.com> (Yi Zou's message of "Mon, 06 Oct 2008 15:09:20 -0700")
> #define ETH_P_AOE 0x88A2 /* ATA over Ethernet */
> #define ETH_P_TIPC 0x88CA /* TIPC */
> +#define ETH_P_FCOE 0x8906 /* Fibre Channel over Ethernet */
trivial -- but the patch format makes it pretty obvious -- it would
probably be nice to use tabs to align things on the FCOE line the same
way the other lines in the file do, rather than using spaces.
next prev parent reply other threads:[~2008-10-06 22:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-06 22:09 [PATCH 0/2] New flags for Fibre Channel over Ethernet (FCoE) Yi Zou
[not found] ` <20081006220524.3308.64889.stgit-23BaheqE+Bznoz6Kjl9f4RL4W9x8LtSr@public.gmane.org>
2008-10-06 22:09 ` [PATCH 1/2] net: add ETH_P_FCOE " Yi Zou
2008-10-06 22:33 ` Roland Dreier [this message]
2008-10-06 23:11 ` Zou, Yi
2008-10-06 22:09 ` [PATCH 2/2] net: define feature flags for FCoE offloads Yi Zou
2008-10-06 22:37 ` Ben Hutchings
2008-10-06 23:13 ` Zou, Yi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ada3aj9pd4u.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=devel@open-fcoe.org \
--cc=netdev@vger.kernel.org \
--cc=yi.zou@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).